From: SeongJae Park <sj@kernel.org>
To: Yuanchu Xie <yuanchu@google.com>
Cc: Shuah Khan <shuah@kernel.org>, Markus Boehme <markubo@amazon.de>,
SeongJae Park <sj@kernel.org>,
rientjes@google.com, Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] selftests/damon: suppress compiler warnings for huge_count_read_write
Date: Wed, 4 May 2022 00:11:53 +0000 [thread overview]
Message-ID: <20220504001153.119485-1-sj@kernel.org> (raw)
In-Reply-To: <20220504000358.1174849-1-yuanchu@google.com>
Hi Yuanchu, thank you for this patch!
On Wed, 4 May 2022 00:03:57 +0000 Yuanchu Xie <yuanchu@google.com> wrote:
> The test case added in commit db7a347b26fe ("mm/damon/dbgfs:
> use '__GFP_NOWARN' for user-specified size buffer allocation")
> intentionally writes and reads with a large count to cause
> allocation failure and check for kernel warnings. We suppress
> the compiler warnings for these calls as they work as intended.
>
> Signed-off-by: Yuanchu Xie <yuanchu@google.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Thanks,
SJ
[...]
> ---
> tools/testing/selftests/damon/Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/testing/selftests/damon/Makefile b/tools/testing/selftests/damon/Makefile
> index 0470c5f3e690..a300b4c5b373 100644
> --- a/tools/testing/selftests/damon/Makefile
> +++ b/tools/testing/selftests/damon/Makefile
> @@ -1,6 +1,9 @@
> # SPDX-License-Identifier: GPL-2.0
> # Makefile for damon selftests
>
> +CFLAGS += -Wno-stringop-overread
> +CFLAGS += -Wno-stringop-overflow
> +
> TEST_GEN_FILES += huge_count_read_write
>
> TEST_FILES = _chk_dependency.sh _debugfs_common.sh
> --
> 2.36.0.464.gb9c8b46e94-goog
>
next prev parent reply other threads:[~2022-05-04 0:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 20:20 [PATCH RESEND] selftests/damon: add damon to selftests root Makefile Yuanchu Xie
2022-04-24 19:35 ` David Rientjes
2022-04-25 19:37 ` Shuah Khan
2022-04-25 20:03 ` Shuah Khan
2022-05-04 0:03 ` [PATCH v2 1/2] selftests/damon: suppress compiler warnings for huge_count_read_write Yuanchu Xie
2022-05-04 0:03 ` [PATCH v2 2/2] selftests/damon: add damon to selftests root Makefile Yuanchu Xie
2022-05-04 0:16 ` SeongJae Park
2022-05-04 4:50 ` David Rientjes
2022-05-04 0:11 ` SeongJae Park [this message]
2022-05-04 18:29 ` [PATCH v3] selftests/damon: suppress compiler warnings for huge_count_read_write Yuanchu Xie
2022-05-04 18:32 ` Yuanchu Xie
2022-05-04 18:45 ` SeongJae Park
2022-05-04 22:12 ` Yuanchu Xie
2022-05-17 1:07 ` Yuanchu Xie
2022-05-17 16:04 ` SeongJae Park
2022-05-25 0:55 ` Yuanchu Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220504001153.119485-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=markubo@amazon.de \
--cc=rientjes@google.com \
--cc=shuah@kernel.org \
--cc=yuanchu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).