Re: [PATCH] HID: logitech-hidpp: support Color LED feature (8071).

From: Pavel Machek <pavel@ucw.cz>
To: "Manuel Schönlaub" <manuel.schoenlaub@gmail.com>
Cc: "Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
	"Filipe Laíns" <lains@riseup.net>,
	"Jiri Kosina" <jikos@kernel.org>,
	"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] HID: logitech-hidpp: support Color LED feature (8071).
Date: Thu, 5 May 2022 10:32:05 +0200	[thread overview]
Message-ID: <20220505083205.GC14065@duo.ucw.cz> (raw)
In-Reply-To: <Yj0a+OwfSqDVMyTK@hermes>

[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]

Hi!

> > > While I realize that there is e.g. ratbagd which supports a great deal of the
> > > HIDPP features and should allow you to control LEDs, unfortunately for my G305
> > > it does not support the LED (and as far as I remember my G403 does not
> > > work at all with it).
> > >
> > > Then I figured that actually having the LEDs in kernel would allow led triggers
> > > to work with them, so you could do fancy stuff like showing disk or CPU activity
> > > or free physical memory... and here we are now.
> > 
> > The one thing that concerns me with those gaming LEDs, is that there
> > is much more than just color/intensity.
> > Those LEDs have effects that you can enable (breathing, pulse, color
> > changing, etc...) and I am not sure how much you are going to be able
> > to sync with the simple LED class.
> > 
> Sure. 
> I actually had thought a bit about that and would say that the concept
> of breathing, pulse etc.. can be modeled quite well with hardware patterns. 

Yes please.

Note that many devices have different patterns with different
limitations; we need to somehow solve that, anyway.

Best regards,
							Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]