From: "Clément Léger" <clement.leger@bootlin.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Herve Codina" <herve.codina@bootlin.com>,
"Miquèl Raynal" <miquel.raynal@bootlin.com>,
"Milan Stevanovic" <milan.stevanovic@se.com>,
"Jimmy Lalande" <jimmy.lalande@se.com>,
"Pascal Eberhard" <pascal.eberhard@se.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v3 04/12] net: pcs: add Renesas MII converter driver
Date: Thu, 5 May 2022 14:32:36 +0200 [thread overview]
Message-ID: <20220505143236.31fc6b58@fixe.home> (raw)
In-Reply-To: <CAMuHMdU1dF25eKeihBO3xRarW-acG0vUSggWfKOwG3v=7eN+bg@mail.gmail.com>
Le Thu, 5 May 2022 09:16:38 +0200,
Geert Uytterhoeven <geert@linux-m68k.org> a écrit :
> Hi Clément,
>
> On Wed, May 4, 2022 at 11:31 AM Clément Léger <clement.leger@bootlin.com> wrote:
> > Add a PCS driver for the MII converter that is present on the Renesas
> > RZ/N1 SoC. This MII converter is reponsible for converting MII to
> > RMII/RGMII or act as a MII pass-trough. Exposing it as a PCS allows to
> > reuse it in both the switch driver and the stmmac driver. Currently,
> > this driver only allows the PCS to be used by the dual Cortex-A7
> > subsystem since the register locking system is not used.
> >
> > Signed-off-by: Clément Léger <clement.leger@bootlin.com>
>
> Thanks for your patch!
>
> > --- /dev/null
> > +++ b/drivers/net/pcs/pcs-rzn1-miic.c
>
> > +static int miic_probe(struct platform_device *pdev)
> > +{
> > + struct device *dev = &pdev->dev;
> > + struct miic *miic;
> > + u32 mode_cfg;
> > + int ret;
> > +
> > + ret = miic_parse_dt(dev, &mode_cfg);
> > + if (ret < 0)
> > + return -EINVAL;
> > +
> > + miic = devm_kzalloc(dev, sizeof(*miic), GFP_KERNEL);
> > + if (!miic)
> > + return -ENOMEM;
> > +
> > + spin_lock_init(&miic->lock);
> > + miic->dev = dev;
> > + miic->base = devm_platform_ioremap_resource(pdev, 0);
> > + if (!miic->base)
> > + return -EINVAL;
> > +
> > + pm_runtime_enable(dev);
> > + ret = pm_runtime_resume_and_get(dev);
> > + if (ret < 0)
>
> Missing pm_runtime_disable(dev).
Maybe using devm_pm_runtime_enable() would be sufficient and avoid such
calls.
>
> > + return ret;
> > +
> > + ret = miic_init_hw(miic, mode_cfg);
> > + if (ret)
> > + goto disable_runtime_pm;
> > +
> > + /* miic_create() relies on that fact that data are attached to the
> > + * platform device to determine if the driver is ready so this needs to
> > + * be the last thing to be done after everything is initialized
> > + * properly.
> > + */
> > + platform_set_drvdata(pdev, miic);
> > +
> > + return 0;
> > +
> > +disable_runtime_pm:
> > + pm_runtime_put(dev);
>
> Missing pm_runtime_disable(dev).
>
> > +
> > + return ret;
> > +}
> > +
> > +static int miic_remove(struct platform_device *pdev)
> > +{
> > + pm_runtime_put(&pdev->dev);
>
> Missing pm_runtime_disable(dev).
>
> > +
> > + return 0;
> > +}
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com
next prev parent reply other threads:[~2022-05-05 12:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 9:29 [PATCH net-next v3 00/12] add support for Renesas RZ/N1 ethernet subsystem devices Clément Léger
2022-05-04 9:29 ` [PATCH net-next v3 01/12] net: dsa: add support for ethtool get_rmon_stats() Clément Léger
2022-05-04 15:50 ` Vladimir Oltean
2022-05-04 9:29 ` [PATCH net-next v3 02/12] net: dsa: add Renesas RZ/N1 switch tag driver Clément Léger
2022-05-04 16:00 ` Vladimir Oltean
2022-05-05 13:48 ` Clément Léger
2022-05-04 9:29 ` [PATCH net-next v3 03/12] dt-bindings: net: pcs: add bindings for Renesas RZ/N1 MII converter Clément Léger
2022-05-04 9:29 ` [PATCH net-next v3 04/12] net: pcs: add Renesas MII converter driver Clément Léger
2022-05-05 7:16 ` Geert Uytterhoeven
2022-05-05 12:32 ` Clément Léger [this message]
2022-05-05 13:00 ` Geert Uytterhoeven
2022-05-05 13:03 ` Clément Léger
2022-05-04 9:29 ` [PATCH net-next v3 05/12] dt-bindings: net: dsa: add bindings for Renesas RZ/N1 Advanced 5 port switch Clément Léger
2022-05-04 9:29 ` [PATCH net-next v3 06/12] net: dsa: rzn1-a5psw: add Renesas RZ/N1 advanced 5 port switch driver Clément Léger
2022-05-04 16:14 ` Vladimir Oltean
2022-05-05 12:59 ` Clément Léger
2022-05-04 9:29 ` [PATCH net-next v3 07/12] net: dsa: rzn1-a5psw: add statistics support Clément Léger
2022-05-04 9:29 ` [PATCH net-next v3 08/12] net: dsa: rzn1-a5psw: add FDB support Clément Léger
2022-05-04 16:24 ` Vladimir Oltean
2022-05-05 13:44 ` Clément Léger
2022-05-05 16:30 ` Vladimir Oltean
2022-05-04 9:29 ` [PATCH net-next v3 09/12] ARM: dts: r9a06g032: describe MII converter Clément Léger
2022-05-04 9:29 ` [PATCH net-next v3 10/12] ARM: dts: r9a06g032: describe GMAC2 Clément Léger
2022-05-04 9:29 ` [PATCH net-next v3 11/12] ARM: dts: r9a06g032: describe switch Clément Léger
2022-05-04 9:30 ` [PATCH net-next v3 12/12] MAINTAINERS: add Renesas RZ/N1 switch related driver entry Clément Léger
2022-05-05 7:29 ` [PATCH net-next v3 00/12] add support for Renesas RZ/N1 ethernet subsystem devices Geert Uytterhoeven
2022-05-05 9:48 ` Clément Léger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220505143236.31fc6b58@fixe.home \
--to=clement.leger@bootlin.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=jimmy.lalande@se.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=milan.stevanovic@se.com \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=pascal.eberhard@se.com \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).