From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E632C433F5 for ; Fri, 6 May 2022 01:53:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1388170AbiEFB46 (ORCPT ); Thu, 5 May 2022 21:56:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345307AbiEFB44 (ORCPT ); Thu, 5 May 2022 21:56:56 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1512B2B1A9; Thu, 5 May 2022 18:53:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AE82F6204C; Fri, 6 May 2022 01:53:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA6DAC385A4; Fri, 6 May 2022 01:53:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651801994; bh=4j5KB+Ahm7k1P9XIxIkr92yIiBjJ5oXszlFyUFGvtLQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=U07jtolEjea8+39Z56AzTqwJdfh13Mqlc0Fk8txgFE91sX8XE1XVzUh+S+yY8459g YlMcJPR9HvEelQO3IHbX9VNR+F4wF/bAlkidK3H92bxqR9h4MNUQT6km6OczcA1LZ9 /vuG/Xzcz1KNXs59CIPnEdr1QV3o/K4Mxp51wy4U+gBuYgh3NwQfy5dFVD4bjLijUd vsX2mRlvIT4Elz6QlD/ty7dGVxB9++DSecntvYB/J9lLAeJnubYouvoMPKTZ6Xm5M7 Hetty/ajeSMGnLUN8UY0UQuJwuK7qsRsVGC5IyW1eHdkxJ+KE/NHnLcdyjVDgYZDOT kxb87gx49w8Qw== Date: Thu, 5 May 2022 18:53:12 -0700 From: Jakub Kicinski To: Min Li Cc: richardcochran@gmail.com, lee.jones@linaro.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net v4 2/2] ptp: ptp_clockmatrix: return -EBUSY if phase pull-in is in progress Message-ID: <20220505185312.3a56cadc@kernel.org> In-Reply-To: <1651697455-1588-2-git-send-email-min.li.xe@renesas.com> References: <1651697455-1588-1-git-send-email-min.li.xe@renesas.com> <1651697455-1588-2-git-send-email-min.li.xe@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 4 May 2022 16:50:55 -0400 Min Li wrote: > + err = idtcm_output_enable(channel, enable, perout->index); > > if (err) { no empty line between call and error check