From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4319FC43219 for ; Fri, 6 May 2022 05:15:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1389083AbiEFFSn (ORCPT ); Fri, 6 May 2022 01:18:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1389072AbiEFFSl (ORCPT ); Fri, 6 May 2022 01:18:41 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACEE65DA1D; Thu, 5 May 2022 22:14:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1651814099; x=1683350099; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=EuZ6FqmQJ4Xjr48jwOSqZ5PGTAu7X/b9U9fyGNl9HmQ=; b=aurEh7L1LfAPWucgQsVr8ilYaOs6F+pMQL5nSghwdQ9BARAxf/t0FuKD /S8WfISIa4KL4W5+6Ohj+lCBkoS8gixwpTXxPqL35LsVzrY/nspg8yrDl oC52rzNcLzZXplbSd3OEgJY9gGGnapFiTVn7hvFrSxEpsvIHpA34jnuW4 I=; Received: from unknown (HELO ironmsg01-sd.qualcomm.com) ([10.53.140.141]) by alexa-out-sd-01.qualcomm.com with ESMTP; 05 May 2022 22:14:59 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg01-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2022 22:14:58 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 5 May 2022 22:14:58 -0700 Received: from hu-pkondeti-hyd.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 5 May 2022 22:14:51 -0700 Date: Fri, 6 May 2022 10:44:48 +0530 From: Pavan Kondeti To: Krishna Kurapati PSSNV CC: Matthias Kaehlcke , Krzysztof Kozlowski , Rob Herring , "Andy Gross" , Bjorn Andersson , Greg Kroah-Hartman , Felipe Balbi , Stephen Boyd , Doug Anderson , Mathias Nyman , , , , , , , , , Sandeep Maheswaram Subject: Re: [v15 3/6] usb: dwc3: core: Host wake up support from system suspend Message-ID: <20220506051448.GE4640@hu-pkondeti-hyd.qualcomm.com> References: <1651740973-7944-1-git-send-email-quic_kriskura@quicinc.com> <1651740973-7944-4-git-send-email-quic_kriskura@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 06, 2022 at 10:41:01AM +0530, Krishna Kurapati PSSNV wrote: > > On 5/6/2022 4:18 AM, Matthias Kaehlcke wrote: > >On Thu, May 05, 2022 at 02:26:10PM +0530, Krishna Kurapati wrote: > >>From: Sandeep Maheswaram > >> > >>During suspend read the status of all port and set hs phy mode > >>based on current speed. Use this hs phy mode to configure wakeup > >>interrupts in qcom glue driver. > >> > >>Check wakeup-source property for dwc3 core node to set the > >>wakeup capability. Drop the device_init_wakeup call from > >>runtime suspend and resume. > >> > >>Also check during suspend if any wakeup capable devices are > >>connected to the controller (directly or through hubs), if there > >>are none set a flag to indicate that the PHY is powered > >>down during suspend. > >> > >>Signed-off-by: Sandeep Maheswaram > >>Signed-off-by: Krishna Kurapati > >>--- > >> drivers/usb/dwc3/core.c | 33 ++++++++++++++++++++------------- > >> drivers/usb/dwc3/core.h | 4 ++++ > >> drivers/usb/dwc3/host.c | 24 ++++++++++++++++++++++++ > >> 3 files changed, 48 insertions(+), 13 deletions(-) > >> > >>diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > >>index 950e238..cf377f5 100644 > >>--- a/drivers/usb/dwc3/core.c > >>+++ b/drivers/usb/dwc3/core.c > >>@@ -33,6 +33,7 @@ > >> #include > >> #include > >> #include > >>+#include > >This is not needed anymore > > > >> #include "core.h" > >> #include "gadget.h" > >>@@ -1787,6 +1788,7 @@ static int dwc3_probe(struct platform_device *pdev) > >> platform_set_drvdata(pdev, dwc); > >> dwc3_cache_hwparams(dwc); > >>+ device_init_wakeup(&pdev->dev, of_property_read_bool(dev->of_node, "wakeup-source")); > >> spin_lock_init(&dwc->lock); > >> mutex_init(&dwc->mutex); > >>@@ -1936,6 +1938,7 @@ static int dwc3_suspend_common(struct dwc3 *dwc, pm_message_t msg) > >> { > >> unsigned long flags; > >> u32 reg; > >>+ struct usb_hcd *hcd = platform_get_drvdata(dwc->xhci); > >This isn't used anymore, delete it > My bad, Will fix this in next version. > >> switch (dwc->current_dr_role) { > >> case DWC3_GCTL_PRTCAP_DEVICE: > >>@@ -1948,10 +1951,7 @@ static int dwc3_suspend_common(struct dwc3 *dwc, pm_message_t msg) > >> dwc3_core_exit(dwc); > >> break; > >> case DWC3_GCTL_PRTCAP_HOST: > >>- if (!PMSG_IS_AUTO(msg)) { > >>- dwc3_core_exit(dwc); > >>- break; > >>- } > >>+ dwc3_check_phy_speed_mode(dwc); > >> /* Let controller to suspend HSPHY before PHY driver suspends */ > >> if (dwc->dis_u2_susphy_quirk || > >>@@ -1967,6 +1967,16 @@ static int dwc3_suspend_common(struct dwc3 *dwc, pm_message_t msg) > >> phy_pm_runtime_put_sync(dwc->usb2_generic_phy); > >> phy_pm_runtime_put_sync(dwc->usb3_generic_phy); > >>+ > >>+ if (!PMSG_IS_AUTO(msg)) { > >>+ if (device_may_wakeup(dwc->dev) && > >>+ device_wakeup_path(dwc->dev)) { > >nit: the indentation is odd, align it with device_may_wakeup()? > Sure, Will take care of it. > >>+ dwc->phy_power_off = false; > >>+ } else { > >>+ dwc->phy_power_off = true; > >>+ dwc3_core_exit(dwc); > >As commented earlier, taking the controller and PHYs completely down causes a > >significant power draw in some USB clients. Let's clarify what the specific > >benefits are of doing dwc3_core_exit() vs. entering a low power mode. > Sure, once we come to a conclusion on this, I will refresh the patches. I think, Matthias is asking you to clarify in the commit description. we can even quote Matthias observations. Thanks, Pavan