From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ian Cowan <ian@linux.cowan.aero>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
Corentin Labbe <clabbe@baylibre.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
mjpeg-users@lists.sourceforge.net, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] staging: media: zoran: replace dprintk with new debugging macros
Date: Fri, 6 May 2022 10:14:55 +0300 [thread overview]
Message-ID: <20220506071455.GC4031@kadam> (raw)
In-Reply-To: <YnSyZEF8n7luVvHM@fedora>
On Fri, May 06, 2022 at 01:30:12AM -0400, Ian Cowan wrote:
> On Thu, Apr 28, 2022 at 10:15:03AM +0200, Hans Verkuil wrote:
> > Hi Ian,
> >
> > When I compiled this patch series with smatch I got these warnings:
> >
> > zoran/videocodec.c:45 videocodec_attach() warn: variable dereferenced before check 'master' (see line 40)
> > zoran/videocodec.c:115 videocodec_detach() warn: variable dereferenced before check 'codec' (see line 111)
> > zoran/videocodec.c:168 videocodec_register() warn: variable dereferenced before check 'codec' (see line 166)
> > zoran/videocodec.c:200 videocodec_unregister() warn: variable dereferenced before check 'codec' (see line 198)
> >
> > And I also got this warning when checking the kerneldoc:
> >
> > zoran/zoran.h:307: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> >
> > Can you fix this and post a v3?
> >
> > Thanks!
> >
> > Hans
>
> I just resubmitted v3.
>
> What did you use to see these issues? When I ran the checkpatch script
> and compiled, I did not see any of this.
>
I have written a blog entry about checking kernel code with Smatch:
https://staticthinking.wordpress.com/2022/04/25/how-to-run-smatch-on-your-code/
regards,
dan carpenter
next prev parent reply other threads:[~2022-05-06 7:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 14:41 [PATCH v2 4/4] staging: media: zoran: replace dprintk with new debugging macros Ian Cowan
2022-04-28 8:15 ` Hans Verkuil
2022-05-02 15:44 ` Ian Cowan
2022-05-06 5:30 ` Ian Cowan
2022-05-06 7:14 ` Dan Carpenter [this message]
2022-05-06 20:49 ` Ian Cowan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220506071455.GC4031@kadam \
--to=dan.carpenter@oracle.com \
--cc=clabbe@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=ian@linux.cowan.aero \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mjpeg-users@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).