From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E558C433F5 for ; Fri, 6 May 2022 12:35:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1392050AbiEFMjf (ORCPT ); Fri, 6 May 2022 08:39:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1392080AbiEFMjL (ORCPT ); Fri, 6 May 2022 08:39:11 -0400 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C48011C1E; Fri, 6 May 2022 05:35:24 -0700 (PDT) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 574461C000E; Fri, 6 May 2022 12:35:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1651840523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H2Bk3mQ20dGxFwnkKyvshpUua/wpum6W/dZbHZ7rm1Y=; b=g9gnkmhIb6svEygm5WDSRv6YcrjnfsEQPpH8RsytHfDx0bynTua6C23Cnk+Qa3teGWjU8b vc4shpPdG5xxiUh8mTSQNueJ3Iqi6V2/TfITKAk5ligg0xv2CAFTjFx659sM/X5RhVE/Ml 5122xb2Ph32OvMZNpRTT3rXOm0IqUUbwKqy0IuB+rvWgg/+4bJA3DGAkdnWhVj7rlJkhgx XeoEfu/kz4i0FCSAtkLEkcIFgw9X+zXEQO9fnhpeZr/D1YU/sBLwKOFmNxmQKx9lAwwxX+ F5K5Qd0bi/nWcT10WT97TqyRu958m79YPralpcevRha3m+IYMMkygwUBDzfQpQ== Date: Fri, 6 May 2022 14:35:18 +0200 From: Herve Codina To: Geert Uytterhoeven Cc: Krzysztof Kozlowski , Rob Herring , Marek Vasut , Yoshihiro Shimoda , Bjorn Helgaas , Krzysztof Kozlowski , Magnus Damm , Lorenzo Pieralisi , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , linux-pci , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Sergey Shtylyov , Thomas Petazzoni , Clement Leger , Miquel Raynal Subject: Re: [PATCH v5 2/6] dt-bindings: PCI: renesas,pci-rcar-gen2: Add device tree support for r9a06g032 Message-ID: <20220506143518.3ed9765b@bootlin.com> In-Reply-To: References: <20220429134143.628428-1-herve.codina@bootlin.com> <20220429134143.628428-4-herve.codina@bootlin.com> <29ba3db6-e5c7-06d3-29d9-918ee5b34555@linaro.org> <5a89e9bf-1004-500a-75e1-995732629937@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi All, On Tue, 3 May 2022 11:37:31 +0200 Geert Uytterhoeven wrote: > Hi Krzysztof, >=20 > On Tue, May 3, 2022 at 11:29 AM Krzysztof Kozlowski > wrote: > > On 03/05/2022 08:51, Geert Uytterhoeven wrote: =20 > > >>>> This should not be a reason why a property is or is not required. = Either > > >>>> this is required for device operation or not. If it is required, s= hould > > >>>> be in the bindings. Otherwise what are you going to do in the futu= re? > > >>>> Add a required property breaking the ABI? =20 > > >>> > > >>> The problem is that there are no bindings for the reset controller > > >>> (actually the reset controller feature of the system-controller) ye= t. > > >>> Yeah, we can just add #reset-cells =3D <1> to the system-controller > > >>> device node, but we cannot add the actual resets properties to the > > >>> consumers, until the actual cell values are defined. =20 > > >> > > >> Sounds like you should implement providers first. Or just live with = the > > >> warning as a reminder to implement the reset provider? =20 > > > > > > I'd go for the latter. The upstream r9a06g032.dtsi is still under act= ive > > > development. Until very recently, the only device supported was the > > > serial console. =20 > > > > For clocks we use in such cases fixed-clock placeholders or empty > > phandles. Maybe something like that would work here as well? =20 >=20 > I don't think that works for resets. > Besides, the driver doesn't need or use the reset anyway. >=20 Finally, related to the "resets" property, what should I do ? (a) Keep the property as not required an change the commit log (b) Set the property as required and live with a warning (Rob's suggestion) Regards, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com