* [PATCH] irqchip/gic-v3: fix missing of_node_put() in gic_populate_ppi_part()
@ 2022-05-07 3:35 Yang Yingliang
2022-05-08 9:37 ` Marc Zyngier
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2022-05-07 3:35 UTC (permalink / raw)
To: linux-kernel, linux-arm-kernel; +Cc: tglx, maz
If kcalloc() fails, refcount of 'parts_node' should be decreased.
Fixes: 52085d3f2028 ("irqchip/gic-v3: Dynamically allocate PPI partition descriptors")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/irqchip/irq-gic-v3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
index b252d5534547..27a35aec2e48 100644
--- a/drivers/irqchip/irq-gic-v3.c
+++ b/drivers/irqchip/irq-gic-v3.c
@@ -1865,7 +1865,7 @@ static void __init gic_populate_ppi_partitions(struct device_node *gic_node)
gic_data.ppi_descs = kcalloc(gic_data.ppi_nr, sizeof(*gic_data.ppi_descs), GFP_KERNEL);
if (!gic_data.ppi_descs)
- return;
+ goto out_put_node;
nr_parts = of_get_child_count(parts_node);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] irqchip/gic-v3: fix missing of_node_put() in gic_populate_ppi_part()
2022-05-07 3:35 [PATCH] irqchip/gic-v3: fix missing of_node_put() in gic_populate_ppi_part() Yang Yingliang
@ 2022-05-08 9:37 ` Marc Zyngier
0 siblings, 0 replies; 2+ messages in thread
From: Marc Zyngier @ 2022-05-08 9:37 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-kernel, linux-arm-kernel, tglx
On Sat, 07 May 2022 04:35:06 +0100,
Yang Yingliang <yangyingliang@huawei.com> wrote:
>
> If kcalloc() fails, refcount of 'parts_node' should be decreased.
>
> Fixes: 52085d3f2028 ("irqchip/gic-v3: Dynamically allocate PPI partition descriptors")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/irqchip/irq-gic-v3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
> index b252d5534547..27a35aec2e48 100644
> --- a/drivers/irqchip/irq-gic-v3.c
> +++ b/drivers/irqchip/irq-gic-v3.c
> @@ -1865,7 +1865,7 @@ static void __init gic_populate_ppi_partitions(struct device_node *gic_node)
>
> gic_data.ppi_descs = kcalloc(gic_data.ppi_nr, sizeof(*gic_data.ppi_descs), GFP_KERNEL);
> if (!gic_data.ppi_descs)
> - return;
> + goto out_put_node;
>
> nr_parts = of_get_child_count(parts_node);
>
If you are concerned about this, then why not also address the memory
leak that occur on the same path?
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-08 9:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-07 3:35 [PATCH] irqchip/gic-v3: fix missing of_node_put() in gic_populate_ppi_part() Yang Yingliang
2022-05-08 9:37 ` Marc Zyngier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).