From: kernel test robot <lkp@intel.com>
To: Qin Jian <qinjian@cqplus1.com>, krzysztof.kozlowski@linaro.org
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
robh+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
tglx@linutronix.de, maz@kernel.org, p.zabel@pengutronix.de,
linux@armlinux.org.uk, arnd@arndb.de,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Qin Jian <qinjian@cqplus1.com>
Subject: Re: [PATCH v14 7/9] irqchip: Add Sunplus SP7021 interrupt controller driver
Date: Sat, 7 May 2022 03:26:08 +0800 [thread overview]
Message-ID: <202205070356.RRuPT69d-lkp@intel.com> (raw)
In-Reply-To: <7e469fb049959f88cf2b37649e6f3eb1d0fd3440.1651805790.git.qinjian@cqplus1.com>
Hi Qin,
I love your patch! Perhaps something to improve:
[auto build test WARNING on pza/reset/next]
[also build test WARNING on clk/clk-next tip/irq/core linus/master v5.18-rc5 next-20220506]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Qin-Jian/Add-Sunplus-SP7021-SoC-Support/20220506-113239
base: https://git.pengutronix.de/git/pza/linux reset/next
config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20220507/202205070356.RRuPT69d-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 5e004fb787698440a387750db7f8028e7cb14cfc)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/e4d57016693163887d81dfa4c0b0db3e4437cf2b
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Qin-Jian/Add-Sunplus-SP7021-SoC-Support/20220506-113239
git checkout e4d57016693163887d81dfa4c0b0db3e4437cf2b
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/irqchip/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/irqchip/irq-sp7021-intc.c:170:16: warning: cast to smaller integer type 'int' from 'void *' [-Wvoid-pointer-to-int-cast]
int ext_num = (int)irq_desc_get_handler_data(desc);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/irqchip/irq-sp7021-intc.c:218:69: warning: cast to 'void *' from smaller integer type 'int' [-Wint-to-void-pointer-cast]
irq_set_chained_handler_and_data(irq, sp_intc_handle_ext_cascaded, (void *)i);
^~~~~~~~~
2 warnings generated.
vim +170 drivers/irqchip/irq-sp7021-intc.c
166
167 static void sp_intc_handle_ext_cascaded(struct irq_desc *desc)
168 {
169 struct irq_chip *chip = irq_desc_get_chip(desc);
> 170 int ext_num = (int)irq_desc_get_handler_data(desc);
171 int hwirq;
172
173 chained_irq_enter(chip, desc);
174
175 while ((hwirq = sp_intc_get_ext_irq(ext_num)) >= 0) {
176 if (unlikely(IS_GPIO_INT(hwirq) && TEST_STATE(hwirq, _IS_ACTIVE))) { // WORKAROUND
177 ASSIGN_STATE(hwirq, _IS_ACTIVE, false);
178 sp_intc_assign_bit(hwirq, REG_INTR_POLARITY, TEST_STATE(hwirq, _IS_LOW));
179 } else {
180 generic_handle_domain_irq(sp_intc.domain, hwirq);
181 }
182 }
183
184 chained_irq_exit(chip, desc);
185 }
186
187 static struct irq_chip sp_intc_chip = {
188 .name = "sp_intc",
189 .irq_ack = sp_intc_ack_irq,
190 .irq_mask = sp_intc_mask_irq,
191 .irq_unmask = sp_intc_unmask_irq,
192 .irq_set_type = sp_intc_set_type,
193 };
194
195 static int sp_intc_irq_domain_map(struct irq_domain *domain,
196 unsigned int irq, irq_hw_number_t hwirq)
197 {
198 irq_set_chip_and_handler(irq, &sp_intc_chip, handle_level_irq);
199 irq_set_chip_data(irq, &sp_intc_chip);
200 irq_set_noprobe(irq);
201
202 return 0;
203 }
204
205 static const struct irq_domain_ops sp_intc_dm_ops = {
206 .xlate = irq_domain_xlate_twocell,
207 .map = sp_intc_irq_domain_map,
208 };
209
210 static int sp_intc_irq_map(struct device_node *node, int i)
211 {
212 unsigned int irq;
213
214 irq = irq_of_parse_and_map(node, i);
215 if (!irq)
216 return -ENOENT;
217
> 218 irq_set_chained_handler_and_data(irq, sp_intc_handle_ext_cascaded, (void *)i);
219
220 return 0;
221 }
222
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-05-06 19:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 3:23 [PATCH v14 0/9] Add Sunplus SP7021 SoC Support Qin Jian
2022-05-06 3:23 ` [PATCH v14 1/9] dt-bindings: arm: sunplus: Add bindings for Sunplus SP7021 SoC boards Qin Jian
2022-05-06 3:23 ` [PATCH v14 2/9] dt-bindings: reset: Add bindings for SP7021 reset driver Qin Jian
2022-05-06 3:23 ` [PATCH v14 3/9] reset: Add Sunplus " Qin Jian
2022-05-06 3:23 ` [PATCH v14 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver Qin Jian
2022-05-06 6:33 ` Krzysztof Kozlowski
2022-05-06 3:23 ` [PATCH v14 5/9] clk: Add Sunplus " Qin Jian
2022-05-06 3:23 ` [PATCH v14 6/9] dt-bindings: interrupt-controller: Add bindings for SP7021 interrupt controller Qin Jian
2022-05-06 6:35 ` Krzysztof Kozlowski
2022-05-06 7:01 ` qinjian[覃健]
2022-05-06 7:15 ` Krzysztof Kozlowski
2022-05-06 3:23 ` [PATCH v14 7/9] irqchip: Add Sunplus SP7021 interrupt controller driver Qin Jian
2022-05-06 11:01 ` Marc Zyngier
2022-05-06 19:26 ` kernel test robot [this message]
2022-05-06 3:23 ` [PATCH v14 8/9] ARM: sunplus: Add initial support for Sunplus SP7021 SoC Qin Jian
2022-05-06 11:25 ` kernel test robot
2022-05-06 3:23 ` [PATCH v14 9/9] ARM: sp7021_defconfig: Add Sunplus SP7021 defconfig Qin Jian
2022-05-06 7:31 ` [PATCH v14 0/9] Add Sunplus SP7021 SoC Support Arnd Bergmann
2022-05-06 8:34 ` qinjian[覃健]
2022-05-06 8:49 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202205070356.RRuPT69d-lkp@intel.com \
--to=lkp@intel.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=llvm@lists.linux.dev \
--cc=maz@kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=qinjian@cqplus1.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).