From: Lukasz Majewski <lukma@denx.de>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com
Subject: Re: [PATCH 1/2] ASoC: wm8940: add devicetree support
Date: Tue, 10 May 2022 09:24:38 +0200 [thread overview]
Message-ID: <20220510092438.528ef474@ktm> (raw)
In-Reply-To: <YnkxIe1nVUiKNmdq@sirena.org.uk>
[-- Attachment #1: Type: text/plain, Size: 908 bytes --]
Hi Mark,
> On Mon, May 09, 2022 at 02:10:55PM +0200, Lukasz Majewski wrote:
>
> > This adds devicetree support to the wm8940 codec driver.
> > With a DT-based kernel, there is no board-specific setting
> > to select the driver so allow it to be manually chosen.
> >
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > ---
> > sound/soc/codecs/Kconfig | 2 +-
> > sound/soc/codecs/wm8940.c | 7 +++++++
> > 2 files changed, 8 insertions(+), 1 deletion(-)
>
> You need to provide a binding document for any new bindings you add in
> code.
The second patch in this series adds proper *.yaml file to Linux source
tree.
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-05-10 7:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 12:10 [PATCH 1/2] ASoC: wm8940: add devicetree support Lukasz Majewski
2022-05-09 12:46 ` Charles Keepax
2022-05-09 15:20 ` Mark Brown
2022-05-10 7:24 ` Lukasz Majewski [this message]
2022-05-10 11:13 ` Mark Brown
2022-05-10 11:33 ` Lukasz Majewski
2022-05-09 18:05 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220510092438.528ef474@ktm \
--to=lukma@denx.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).