linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ulf Hansson <ulf.hansson@linaro.org>
To: "Rafael J . Wysocki" <rafael@kernel.org>, linux-pm@vger.kernel.org
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Maulik Shah <quic_mkshah@quicinc.com>,
	Gabriel Fernandez <gabriel.fernandez@foss.st.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Dmitry Osipenko <digetx@gmail.com>,
	Kevin Hilman <khilman@kernel.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 13/14] PM: domains: Measure power-on/off latencies in genpd based on a governor
Date: Wed, 11 May 2022 16:57:03 +0200	[thread overview]
Message-ID: <20220511145704.698189-14-ulf.hansson@linaro.org> (raw)
In-Reply-To: <20220511145704.698189-1-ulf.hansson@linaro.org>

The measurements of the power-on|off latencies in genpd for a PM domain are
superfluous, unless the corresponding genpd has a governor assigned to it,
which would make use of the data.

Therefore, let's improve the behaviour in genpd by making the measurements
conditional, based upon if there's a governor assigned.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
 drivers/base/power/domain.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index a7de5fb8f073..83b073cdd0ed 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -509,6 +509,7 @@ static int _genpd_power_on(struct generic_pm_domain *genpd, bool timed)
 	if (!genpd->power_on)
 		goto out;
 
+	timed = timed && genpd->gd;
 	if (!timed) {
 		ret = genpd->power_on(genpd);
 		if (ret)
@@ -527,8 +528,7 @@ static int _genpd_power_on(struct generic_pm_domain *genpd, bool timed)
 		goto out;
 
 	genpd->states[state_idx].power_on_latency_ns = elapsed_ns;
-	if (genpd->gd)
-		genpd->gd->max_off_time_changed = true;
+	genpd->gd->max_off_time_changed = true;
 	pr_debug("%s: Power-%s latency exceeded, new value %lld ns\n",
 		 genpd->name, "on", elapsed_ns);
 
@@ -559,6 +559,7 @@ static int _genpd_power_off(struct generic_pm_domain *genpd, bool timed)
 	if (!genpd->power_off)
 		goto out;
 
+	timed = timed && genpd->gd;
 	if (!timed) {
 		ret = genpd->power_off(genpd);
 		if (ret)
@@ -577,8 +578,7 @@ static int _genpd_power_off(struct generic_pm_domain *genpd, bool timed)
 		goto out;
 
 	genpd->states[state_idx].power_off_latency_ns = elapsed_ns;
-	if (genpd->gd)
-		genpd->gd->max_off_time_changed = true;
+	genpd->gd->max_off_time_changed = true;
 	pr_debug("%s: Power-%s latency exceeded, new value %lld ns\n",
 		 genpd->name, "off", elapsed_ns);
 
-- 
2.25.1


  parent reply	other threads:[~2022-05-11 14:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-11 14:56 [PATCH 00/14] PM: domains: Various improvements for genpd Ulf Hansson
2022-05-11 14:56 ` [PATCH 01/14] PM: domains: Add GENPD_FLAG_RPM_ALWAYS_ON for the always-on governor Ulf Hansson
2022-05-11 14:56 ` [PATCH 02/14] PM: domains: Drop redundant code for genpd " Ulf Hansson
2022-05-11 14:56 ` [PATCH 03/14] PM: domains: Don't check PM_QOS_FLAG_NO_POWER_OFF in genpd Ulf Hansson
2022-05-11 14:56 ` [PATCH 04/14] PM: domains: Rename irq_safe_dev_in_no_sleep_domain() " Ulf Hansson
2022-05-11 14:56 ` [PATCH 05/14] PM: domains: Skip another warning in irq_safe_dev_in_sleep_domain() Ulf Hansson
2022-05-11 14:56 ` [PATCH 06/14] PM: domains: Allocate gpd_timing_data dynamically based on governor Ulf Hansson
2022-05-11 14:56 ` [PATCH 07/14] PM: domains: Move the next_wakeup variable into the struct gpd_timing_data Ulf Hansson
2022-05-11 14:56 ` [PATCH 08/14] PM: domains: Measure suspend/resume latencies in genpd based on governor Ulf Hansson
2022-05-11 14:56 ` [PATCH 09/14] PM: domains: Fixup QoS latency measurements for IRQ safe devices in genpd Ulf Hansson
2022-05-11 14:57 ` [PATCH 10/14] PM: domains: Fix initialization of genpd's next_wakeup Ulf Hansson
2022-05-11 14:57 ` [PATCH 11/14] PM: domains: Clean up some code in pm_genpd_init() and genpd_remove() Ulf Hansson
2022-05-11 14:57 ` [PATCH 12/14] PM: domains: Allocate governor data dynamically based on a genpd governor Ulf Hansson
2022-05-11 14:57 ` Ulf Hansson [this message]
2022-05-11 14:57 ` [PATCH 14/14] PM: domains: Trust domain-idle-states from DT to be correct by genpd Ulf Hansson
2022-05-19 18:37 ` [PATCH 00/14] PM: domains: Various improvements for genpd Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220511145704.698189-14-ulf.hansson@linaro.org \
    --to=ulf.hansson@linaro.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=digetx@gmail.com \
    --cc=gabriel.fernandez@foss.st.com \
    --cc=geert+renesas@glider.be \
    --cc=khilman@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=quic_mkshah@quicinc.com \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).