From: Sudeep Holla <sudeep.holla@arm.com>
To: 王擎 <wangqing@vivo.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dietmar.eggemann@arm.com" <dietmar.eggemann@arm.com>
Subject: Re: [PATCH V2] arch_topology: support parsing cluster_id from DT
Date: Fri, 13 May 2022 09:46:54 +0100 [thread overview]
Message-ID: <20220513084654.woxpjvtmtxx7cpik@bogus> (raw)
In-Reply-To: <SL2PR06MB3082CAA7318834D00872DE0DBDCA9@SL2PR06MB3082.apcprd06.prod.outlook.com>
On Fri, May 13, 2022 at 08:30:10AM +0000, 王擎 wrote:
>
> >> From: Wang Qing <wangqing@vivo.com>
> >>
> >> Use nested cluster structures in DT to support describing multi-level
> >> cluster topologies and increase the parsing of nested cluster.
> >>
> >> Notice: the clusters describing in DT currently are not physical
> >> boundaries, since changing "cluster" to "socket" is too involved and error
> >> prone, this patch will not have any effect on one-level cluster topo, but
> >> can support the mutil-level cluster topo to support CLUSTER_SCHED.
> >
> >Sorry the socket/package_id is broken. If we are playing with cluster_id
> >which is now wrongly presented as package_id, you are forced to fix that
> >too. We don't want to break that in a different way or leave that as is
> >since the cluster_id and package ids now show up as same now. Earlier the
> >cluster_id was -1.
> >
> >I had a look when I started reviewing your patch. Assuming we don't need
> >nested cluster support yet, I have some patches(not built or tested
> >unfortunately yet). Let me know your thoughts. If you think you still
> >need support for some kind of nested cluster, build that on top of this.
> >Also I haven't bothered about sched domains as this purely relates to
> >topology and how this is mapped to sched domain is orthogonal.
> >
> >If anything is broken, that needs to be fixed separately there. I see the
> >idea here is correct and would like to push the patches once I build/test
> >and get some review/more testing.
> >
> >Regards,
> >Sudeep
>
> You have to modify all DTS(rename "cluster" to "socket"), otherwise,
> new package_id = -1 and new cluster_id = old package_id.
>
Nope. I am handling absence of socket nodes and that is a must for backward
compatibility with existing DT.
> This will affect MC and CLS useage, do you have any plans about this?
>
I don't have much knowledge on scheduler domains and I will defer that to
the experts. I am just trying to get the topology read from DT correct and
to align with PPTT. Though LLC is not yet considered but that is not part
of cpu-map. I am trying to get only the /cpu-map part of topology correct
at first. We(you, me or anyone interested) can get the LLC part updated
after that.
--
Regards,
Sudeep
next prev parent reply other threads:[~2022-05-13 8:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 9:52 [PATCH V2] arch_topology: support parsing cluster_id from DT Qing Wang
2022-05-12 10:58 ` Dietmar Eggemann
2022-05-12 11:21 ` 王擎
2022-05-12 14:17 ` Sudeep Holla
2022-05-13 8:30 ` 王擎
2022-05-13 8:46 ` Sudeep Holla [this message]
2022-05-13 8:36 ` Dietmar Eggemann
2022-05-13 8:56 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220513084654.woxpjvtmtxx7cpik@bogus \
--to=sudeep.holla@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=wangqing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).