From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39F1FC433F5 for ; Fri, 13 May 2022 23:14:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233366AbiEMXOi (ORCPT ); Fri, 13 May 2022 19:14:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230098AbiEMXOe (ORCPT ); Fri, 13 May 2022 19:14:34 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A093320CB5 for ; Fri, 13 May 2022 16:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652483661; x=1684019661; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+wjfqOqIYe6TZTMHFU68r4+WktU+l0Y6oPd5aHItbaM=; b=Mah62wU8ASEQE1z70AZpSnzFUBLvtPJuqVJ3Mt1gQrhJ0/84a7PfWviq Z/PSEKxIFaRpTOhB0xC5aLD03avu4vapzKtH79L4cD1wh/t3ZnrSgQ0rP v45JYY77S8659Q+VqAMwPf/+bAs+/6Li/f2cAYa5GfWX5OnILlnGJffFh 00ZcySfLIbavc65EiwxIlsF99jcxopppAk5zo4b8gO1ax9AdUwIMgqARZ 7f6TSfcLqohQjZgg/tBnxCVy7jorN7GYBiW6r+2CamyYfi8PXEc2/3fyO its2hLyPXkNvRBXEt0whNg4jnnjGctQJbR+fQ/hcNlOeLmuJBAZxITPTe A==; X-IronPort-AV: E=McAfee;i="6400,9594,10346"; a="356855218" X-IronPort-AV: E=Sophos;i="5.91,223,1647327600"; d="scan'208";a="356855218" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2022 16:14:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,223,1647327600"; d="scan'208";a="815594245" Received: from ranerica-svr.sc.intel.com ([172.25.110.23]) by fmsmga006.fm.intel.com with ESMTP; 13 May 2022 16:14:19 -0700 Date: Fri, 13 May 2022 16:17:54 -0700 From: Ricardo Neri To: Nicholas Piggin Cc: Thomas Gleixner , x86@kernel.org, Andi Kleen , Andrew Morton , Lu Baolu , David Woodhouse , Stephane Eranian , iommu@lists.linux-foundation.org, Joerg Roedel , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "Ravi V. Shankar" , Ricardo Neri , Suravee Suthikulpanit , Tony Luck Subject: Re: [PATCH v6 24/29] watchdog/hardlockup: Use parse_option_str() to handle "nmi_watchdog" Message-ID: <20220513231754.GB9074@ranerica-svr.sc.intel.com> References: <20220506000008.30892-1-ricardo.neri-calderon@linux.intel.com> <20220506000008.30892-25-ricardo.neri-calderon@linux.intel.com> <1652179333.fnu2fjiffn.astroid@bobo.none> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1652179333.fnu2fjiffn.astroid@bobo.none> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 10, 2022 at 08:46:41PM +1000, Nicholas Piggin wrote: > Excerpts from Ricardo Neri's message of May 6, 2022 10:00 am: > > Prepare hardlockup_panic_setup() to handle a comma-separated list of > > options. Thus, it can continue parsing its own command-line options while > > ignoring parameters that are relevant only to specific implementations of > > the hardlockup detector. Such implementations may use an early_param to > > parse their own options. > > It can't really handle comma separated list though, until the next > patch. nmi_watchdog=panic,0 does not make sense, so you lost error > handling of that. Yes that is true. All possible combinations need to be checked. > > And is it kosher to double handle options like this? I'm sure it > happens but it's ugly. > > Would you consider just add a new option for x86 and avoid changing > this? Less code and patches. Sure, I can not modify this code and add a x86-specific command-line option. Thanks and BR, Ricardo