From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0681DC433EF for ; Sat, 14 May 2022 15:07:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233822AbiENPHW (ORCPT ); Sat, 14 May 2022 11:07:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233745AbiENPHI (ORCPT ); Sat, 14 May 2022 11:07:08 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BDD6632C; Sat, 14 May 2022 08:07:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 05214B80908; Sat, 14 May 2022 15:07:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF8A7C36AE2; Sat, 14 May 2022 15:07:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652540824; bh=EcqRIDx0ujmGekBnNMQW7sqA4Kb1kqn6wGKblyiQebw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pTtbCq04Jj+ptLzxk8Myg/jYgkkLDnbdKAKhLkLXZWCPhsIvFG2CMZ8SGTzlx35Yd HKCPvn4Gbnzdt4yg7kjSvGiPoXlSDMmU/Iblb/2Lj3t1YqzQALCOlAA6JVWC/d6OXH A7GRKSC6AwmOSgQw6HIvuXazc0NAeOPIv75U0gC/sKZtvl/fyxQzNBqcFYGssdlf0Z wXL8J3vi3mm6cqDz2qFuEE2Yq6xWn8e6qO2STYYKDV9MJPBE3VzddcDZkGrK1/o8Gf ISg5+rxBaaXAy6e6vosMrtn4CRm6biA4HG1jx+9mJs3e0LJ7wcjC20D8w0ZT0ZI0lS uQZLTp+1Z56+Q== Date: Sat, 14 May 2022 16:15:39 +0100 From: Jonathan Cameron To: Alexandru Ardelean Cc: LI Qingwu , Lars-Peter Clausen , mchehab+huawei@kernel.org, linux-iio , LKML , Rob Herring , Mike Looijmans , devicetree Subject: Re: [PATCH V2 1/6] iio: accel: bmi088: Modified the scale calculate Message-ID: <20220514161539.3805bf87@jic23-huawei> In-Reply-To: References: <20220510141753.3878390-1-Qing-wu.Li@leica-geosystems.com.cn> <20220510141753.3878390-2-Qing-wu.Li@leica-geosystems.com.cn> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 May 2022 10:14:47 +0300 Alexandru Ardelean wrote: > On Tue, May 10, 2022 at 5:17 PM LI Qingwu > wrote: > > > > The units after application of scale are 100*m/s^2, > > The scale calculation is only for the device > > with the range of 3, 6, 12, and 24g, > > but some other chips have a range of 2, 4, 6, and 8g. > > > > Modified the formula to a scale list. > > The scales in the list are calculated by 1/sensitivity*9.8. > > The new units after the application of scale are m/s^2. > > > > Strictly on the code: > > Reviewed-by: Alexandru Ardelean > > On the change of IIO_VAL_FRACTIONAL_LOG2 -> IIO_VAL_INT_PLUS_MICRO is > still up for discussion. It's fine as far as I'm concerned. Jonathan > > > Signed-off-by: LI Qingwu > > --- > > drivers/iio/accel/bmi088-accel-core.c | 12 +++++++----- > > 1 file changed, 7 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/iio/accel/bmi088-accel-core.c b/drivers/iio/accel/bmi088-accel-core.c > > index a06dae5c971d..9300313b63cb 100644 > > --- a/drivers/iio/accel/bmi088-accel-core.c > > +++ b/drivers/iio/accel/bmi088-accel-core.c > > @@ -119,6 +119,7 @@ struct bmi088_accel_chip_info { > > u8 chip_id; > > const struct iio_chan_spec *channels; > > int num_channels; > > + const int scale_table[4][2]; > > }; > > > > struct bmi088_accel_data { > > @@ -280,6 +281,7 @@ static int bmi088_accel_read_raw(struct iio_dev *indio_dev, > > struct bmi088_accel_data *data = iio_priv(indio_dev); > > struct device *dev = regmap_get_device(data->regmap); > > int ret; > > + int reg; > > > > switch (mask) { > > case IIO_CHAN_INFO_RAW: > > @@ -330,13 +332,12 @@ static int bmi088_accel_read_raw(struct iio_dev *indio_dev, > > return ret; > > > > ret = regmap_read(data->regmap, > > - BMI088_ACCEL_REG_ACC_RANGE, val); > > + BMI088_ACCEL_REG_ACC_RANGE, ®); > > if (ret) > > goto out_read_raw_pm_put; > > - > > - *val2 = 15 - (*val & 0x3); > > - *val = 3 * 980; > > - ret = IIO_VAL_FRACTIONAL_LOG2; > > + *val = data->chip_info->scale_table[reg&0x03][0]; > > + *val2 = data->chip_info->scale_table[reg&0x03][1]; > > + ret = IIO_VAL_INT_PLUS_MICRO; > > > > goto out_read_raw_pm_put; > > default: > > @@ -432,6 +433,7 @@ static const struct bmi088_accel_chip_info bmi088_accel_chip_info_tbl[] = { > > .chip_id = 0x1E, > > .channels = bmi088_accel_channels, > > .num_channels = ARRAY_SIZE(bmi088_accel_channels), > > + .scale_table = {{0, 897}, {0, 1795}, {0, 3590}, {0, 7179}}, > > }, > > }; > > > > -- > > 2.25.1 > >