From: Jonathan Cameron <jic23@kernel.org>
To: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>
Cc: lars@metafoo.de, mchehab+huawei@kernel.org,
ardeleanalex@gmail.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
mike.looijmans@topic.nl, devicetree@vger.kernel.org
Subject: Re: [PATCH V2 4/6] iio: accel: bmi088: Add support for bmi085 accel
Date: Sat, 14 May 2022 16:42:44 +0100 [thread overview]
Message-ID: <20220514164244.09637098@jic23-huawei> (raw)
In-Reply-To: <20220510141753.3878390-5-Qing-wu.Li@leica-geosystems.com.cn>
On Tue, 10 May 2022 14:17:51 +0000
LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn> wrote:
> Add supports for BMI085, an Inertial Measurement Unit,
> with an accelerometer and gyroscope.
> The commit adds the accelerometer driver for the SPI interface.
> The gyroscope part is already supported by the BMG160 driver.
> Different from BMI088, the BMI085 accelerometer has the range of
> +/-2, 4, 6, and 8g.
>
> Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com>
> Signed-off-by: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>
Hi,
A request to change the ordering of id table entries below.
> ---
> drivers/iio/accel/bmi088-accel-core.c | 7 +++++++
> drivers/iio/accel/bmi088-accel-spi.c | 1 +
> 2 files changed, 8 insertions(+)
>
> diff --git a/drivers/iio/accel/bmi088-accel-core.c b/drivers/iio/accel/bmi088-accel-core.c
> index de2385e4dad5..13bb3d96a3a6 100644
> --- a/drivers/iio/accel/bmi088-accel-core.c
> +++ b/drivers/iio/accel/bmi088-accel-core.c
> @@ -465,6 +465,13 @@ static const struct bmi088_accel_chip_info bmi088_accel_chip_info_tbl[] = {
> .num_channels = ARRAY_SIZE(bmi088_accel_channels),
> .scale_table = {{0, 897}, {0, 1795}, {0, 3590}, {0, 7179}},
> },
> + [1] = {
> + .name = "bmi085-accel",
> + .chip_id = 0x1F,
Probably makes sense to keep these entries in order of chip_id - so leave the
order as you have it for this array.
> + .channels = bmi088_accel_channels,
> + .num_channels = ARRAY_SIZE(bmi088_accel_channels),
> + .scale_table = {{0, 598}, {0, 1196}, {0, 2393}, {0, 4785}},
> + },
> };
>
> static const struct iio_info bmi088_accel_info = {
> diff --git a/drivers/iio/accel/bmi088-accel-spi.c b/drivers/iio/accel/bmi088-accel-spi.c
> index 0fed0081e1fd..e7a1daab8f3c 100644
> --- a/drivers/iio/accel/bmi088-accel-spi.c
> +++ b/drivers/iio/accel/bmi088-accel-spi.c
> @@ -61,6 +61,7 @@ static int bmi088_accel_remove(struct spi_device *spi)
>
> static const struct spi_device_id bmi088_accel_id[] = {
> {"bmi088-accel", },
> + {"bmi085-accel", },
Alphabetical / numeric order preferred.
> {}
> };
> MODULE_DEVICE_TABLE(spi, bmi088_accel_id);
next prev parent reply other threads:[~2022-05-14 15:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 14:17 [PATCH V2 0/6] iio: accel: bmi088: support BMI085 BMI090L LI Qingwu
2022-05-10 14:17 ` [PATCH V2 1/6] iio: accel: bmi088: Modified the scale calculate LI Qingwu
2022-05-12 7:14 ` Alexandru Ardelean
2022-05-14 15:15 ` Jonathan Cameron
2022-05-14 15:32 ` Jonathan Cameron
2022-05-10 14:17 ` [PATCH V2 2/6] iio: accel: bmi088: Make it possible to config scales LI Qingwu
2022-05-14 15:35 ` Jonathan Cameron
2022-05-10 14:17 ` [PATCH V2 3/6] iio: accel: bmi088: modified the device name LI Qingwu
2022-05-12 7:31 ` Alexandru Ardelean
2022-05-12 16:18 ` LI Qingwu
2022-05-13 6:20 ` Alexandru Ardelean
2022-05-14 15:29 ` Jonathan Cameron
2022-05-14 15:40 ` Jonathan Cameron
2022-05-10 14:17 ` [PATCH V2 4/6] iio: accel: bmi088: Add support for bmi085 accel LI Qingwu
2022-05-14 15:42 ` Jonathan Cameron [this message]
2022-05-10 14:17 ` [PATCH V2 5/6] iio: accel: bmi088: Add support for bmi090l accel LI Qingwu
2022-05-14 15:44 ` Jonathan Cameron
2022-05-10 14:17 ` [PATCH V2 6/6] dt-bindings: iio: accel: Add bmi085 and bmi090l bindings LI Qingwu
2022-05-12 7:32 ` Alexandru Ardelean
2022-05-14 15:49 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220514164244.09637098@jic23-huawei \
--to=jic23@kernel.org \
--cc=Qing-wu.Li@leica-geosystems.com.cn \
--cc=ardeleanalex@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mike.looijmans@topic.nl \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).