From: Martin Kaiser <martin@kaiser.cx>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Michael Straube <straube.linux@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Martin Kaiser <martin@kaiser.cx>
Subject: [PATCH 1/7] staging: r8188eu: get addba resp status from ieee80211_mgmt
Date: Sat, 14 May 2022 18:47:34 +0200 [thread overview]
Message-ID: <20220514164740.282552-2-martin@kaiser.cx> (raw)
In-Reply-To: <20220514164740.282552-1-martin@kaiser.cx>
Read the addba response status from struct ieee80211_mgmt instead of
parsing the incoming frame ourselves.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/core/rtw_mlme_ext.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
index 8a9236ba7c66..4d8337d0dc20 100644
--- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
+++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
@@ -1471,7 +1471,7 @@ unsigned int OnAction_back(struct adapter *padapter, struct recv_frame *precv_fr
struct sta_info *psta = NULL;
struct recv_reorder_ctrl *preorder_ctrl;
unsigned char *frame_body;
- unsigned short tid, status;
+ unsigned short tid;
struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info;
u8 *pframe = precv_frame->rx_data;
@@ -1505,9 +1505,8 @@ unsigned int OnAction_back(struct adapter *padapter, struct recv_frame *precv_fr
issue_action_BA(padapter, mgmt->sa, WLAN_ACTION_ADDBA_RESP, 37);/* reject ADDBA Req */
break;
case WLAN_ACTION_ADDBA_RESP:
- status = get_unaligned_le16(&frame_body[3]);
tid = ((frame_body[5] >> 2) & 0x7);
- if (status == 0) { /* successful */
+ if (mgmt->u.action.u.addba_resp.status == 0) { /* successful */
psta->htpriv.agg_enable_bitmap |= 1 << tid;
psta->htpriv.candidate_tid_bitmap &= ~BIT(tid);
} else {
--
2.30.2
next prev parent reply other threads:[~2022-05-14 16:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-14 16:47 [PATCH 0/7] staging: r8188eu: more cleanups in OnAction_back Martin Kaiser
2022-05-14 16:47 ` Martin Kaiser [this message]
2022-05-14 16:47 ` [PATCH 2/7] staging: r8188eu: read addba resp tid from ieee80211_mgmt Martin Kaiser
2022-05-14 16:47 ` [PATCH 3/7] staging: r8188eu: merge process_addba_req into OnAction_back Martin Kaiser
2022-05-14 16:47 ` [PATCH 4/7] staging: r8188eu: replace if with ternary operator Martin Kaiser
2022-05-14 17:54 ` Joe Perches
2022-05-14 16:47 ` [PATCH 5/7] staging: r8188eu: use BIT(tid) instead of manual shift Martin Kaiser
2022-05-14 16:47 ` [PATCH 6/7] staging: r8188eu: check for initiator vs recipient Martin Kaiser
2022-05-14 16:47 ` [PATCH 7/7] staging: r8188eu: use the tid in delba processing Martin Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220514164740.282552-2-martin@kaiser.cx \
--to=martin@kaiser.cx \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).