From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B901C433EF for ; Mon, 16 May 2022 10:52:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242842AbiEPKwM (ORCPT ); Mon, 16 May 2022 06:52:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243005AbiEPKvb (ORCPT ); Mon, 16 May 2022 06:51:31 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7A215FA3; Mon, 16 May 2022 03:51:29 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id y21so17763442edo.2; Mon, 16 May 2022 03:51:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eiB8mF0XJDqU0woKp11msaKYyY3CXweFfzvmA5fnUk4=; b=f2s3GQqn4S9PGH3nB9DZ1rq4h0LJXkbhxdXM1/U7wD3heov1oWhN472Sx3Hjpr6NJj +OCg7DPOuLR4hGqQYgWKjHr6Da5gYpHKkauPMmG8U+9Yw0f7rpmjWYJtGpsozF8GivQx t3HWLgaMyKY6FWfp25x249Z5GaIfnVSSoFaUjpzbJQ7VXYpxGf+7O4mRu5irCNg0OX2u PZK93jVt3Y/W+s77rCO/0ie+4oYB8WYZIaBOXDgBwvrS1llrSXX4dAey8cyj6eliwj0p X9mspNM4FvI3COVaAoPVHkWb/oXpgOvzNNyuyiJftWbPb4F9YDKex3ghIIeJUKe0TPVX QkIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eiB8mF0XJDqU0woKp11msaKYyY3CXweFfzvmA5fnUk4=; b=cxgedUHsaf3ayK8iI9hBnULaGqjGMavCcqe/0laO5ZsnAqEKoKhVKvGQINNiUxYVYQ i3onW+7XVHGQAH7YCdYrWlMnmuQCn9QjQfw5Cfrp2dKZnZPKmqjOUn+6Pcu+mO5/Am5L /SbYNUbffWeks9OFq7LLlfa+JEWHlP+Lw/pItdqWW+2oS15AYKmZ/XFb0YjKJrlOCSSz aCVlFHAE7rO8jFscOR9K6+xVdyKuqIZYKYmIsADz1XoOxpFkAGvq5vO/JaHVwUHuV7Cq jvM+CBXnXBcYiz+gQGTJav7g41upJpBZTqgb4JtsCGZtYP9nUryxoqBt0chIh6rEYTcV dmiw== X-Gm-Message-State: AOAM530HDpab6KLO5rlwHPBU5NweupM2MzurjtxG+hrzcyjHCyNVwQdF XY54x5F30s1uUpmJ7jsAdE8= X-Google-Smtp-Source: ABdhPJwOGLvumB5LTauGi5+AAvQjocjyBJVYONPHP+vtp9P9rvLzPF5ZLJ8lkrdX7RbbD4/UdGiW7A== X-Received: by 2002:a05:6402:176b:b0:42a:a828:5d79 with SMTP id da11-20020a056402176b00b0042aa8285d79mr7888664edb.272.1652698288181; Mon, 16 May 2022 03:51:28 -0700 (PDT) Received: from skbuf ([188.25.160.86]) by smtp.gmail.com with ESMTPSA id hx9-20020a170906846900b006fa9384a0b5sm3553841ejc.61.2022.05.16.03.51.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 May 2022 03:51:27 -0700 (PDT) Date: Mon, 16 May 2022 13:51:26 +0300 From: Vladimir Oltean To: Arun Ramadoss Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Russell King , Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Oleksij Rempel , Marek Vasut , Michael Grzeschik , Eric Dumazet Subject: Re: [RFC Patch net-next v2 2/9] net: dsa: microchip: move ksz_chip_data to ksz_common Message-ID: <20220516105126.iwrytpsynzlt6xsz@skbuf> References: <20220513102219.30399-1-arun.ramadoss@microchip.com> <20220513102219.30399-3-arun.ramadoss@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220513102219.30399-3-arun.ramadoss@microchip.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 13, 2022 at 03:52:12PM +0530, Arun Ramadoss wrote: > This patch moves the ksz_chip_data in ksz8795 and ksz9477 to ksz_common. > At present, the dev->chip_id is iterated with the ksz_chip_data and then > copy its value to the ksz_dev structure. These values are declared as > constant. > Instead of copying the values and referencing it, this patch update the > dev->info to the ksz_chip_data based on the chip_id in the init > function. And also update the ksz_chip_data values for the LAN937x based > switches. > > Signed-off-by: Arun Ramadoss > --- Thanks, this looks good. I see that dev->info is assigned in ksz_switch_register and I had to look to see whether there is any dev->info dereference from before the call to ksz_switch_register(), and it looks like we're ok. Reviewed-by: Vladimir Oltean