linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v4 01/10] dt-bindings: vendor-prefixes: add Methode Electronics
@ 2022-05-16 12:48 Robert Marko
  2022-05-16 12:48 ` [PATCH v4 02/10] dt-bindings: marvell: convert Armada 37xx compatibles to YAML Robert Marko
                   ` (8 more replies)
  0 siblings, 9 replies; 16+ messages in thread
From: Robert Marko @ 2022-05-16 12:48 UTC (permalink / raw)
  To: robh+dt, krzysztof.kozlowski+dt, andrew, gregory.clement,
	sebastian.hesselbarth, kostap, devicetree, linux-kernel,
	linux-arm-kernel
  Cc: Robert Marko, Krzysztof Kozlowski

Add vendor prefix for Methode Electronics, Inc. (https://www.methode.com)

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 8fc6ed566cf9..2ee5a62363ea 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -768,6 +768,8 @@ patternProperties:
     description: Cisco Meraki, LLC
   "^merrii,.*":
     description: Merrii Technology Co., Ltd.
+  "^methode,.*":
+    description: Methode Electronics, Inc.
   "^micrel,.*":
     description: Micrel Inc.
   "^microchip,.*":
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v4 02/10] dt-bindings: marvell: convert Armada 37xx compatibles to YAML
  2022-05-16 12:48 [PATCH v4 01/10] dt-bindings: vendor-prefixes: add Methode Electronics Robert Marko
@ 2022-05-16 12:48 ` Robert Marko
  2022-05-16 12:48 ` [PATCH v4 03/10] arm64: dts: marvell: espressobin-ultra: add generic Espressobin compatible Robert Marko
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 16+ messages in thread
From: Robert Marko @ 2022-05-16 12:48 UTC (permalink / raw)
  To: robh+dt, krzysztof.kozlowski+dt, andrew, gregory.clement,
	sebastian.hesselbarth, kostap, devicetree, linux-kernel,
	linux-arm-kernel
  Cc: Robert Marko, Krzysztof Kozlowski

Convert the Armada 37xx SoC compatibles to YAML.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes in v4:
* Change the title to "Marvell Armada 37xx Platforms"
* Update the 3720 SoC boards description to include "boards"

Changes in v3:
* Alphabetical ordering
* Remove Armada 3710 SoC as there are no boards currently
---
 .../bindings/arm/marvell/armada-37xx.txt      | 26 -----------
 .../bindings/arm/marvell/armada-37xx.yaml     | 46 +++++++++++++++++++
 2 files changed, 46 insertions(+), 26 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/arm/marvell/armada-37xx.yaml

diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt b/Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt
index f6d6642d81c0..29fa93dad52b 100644
--- a/Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt
+++ b/Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt
@@ -1,21 +1,3 @@
-Marvell Armada 37xx Platforms Device Tree Bindings
---------------------------------------------------
-
-Boards using a SoC of the Marvell Armada 37xx family must carry the
-following root node property:
-
- - compatible: must contain "marvell,armada3710"
-
-In addition, boards using the Marvell Armada 3720 SoC shall have the
-following property before the previous one:
-
- - compatible: must contain "marvell,armada3720"
-
-Example:
-
-compatible = "marvell,armada-3720-db", "marvell,armada3720", "marvell,armada3710";
-
-
 Power management
 ----------------
 
@@ -48,11 +30,3 @@ avs: avs@11500 {
 	compatible = "marvell,armada-3700-avs", "syscon";
 	reg = <0x11500 0x40>;
 }
-
-
-CZ.NIC's Turris Mox SOHO router Device Tree Bindings
-----------------------------------------------------
-
-Required root node property:
-
- - compatible: must contain "cznic,turris-mox"
diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-37xx.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-37xx.yaml
new file mode 100644
index 000000000000..cd7a77d1fdc0
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/marvell/armada-37xx.yaml
@@ -0,0 +1,46 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/marvell/armada-37xx.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Marvell Armada 37xx Platforms
+
+maintainers:
+  - Robert Marko <robert.marko@sartura.hr>
+
+properties:
+  $nodename:
+    const: '/'
+  compatible:
+    oneOf:
+      - description: Armada 3720 SoC boards
+        items:
+          - enum:
+              - cznic,turris-mox
+              - globalscale,espressobin
+              - marvell,armada-3720-db
+              - methode,udpu
+          - const: marvell,armada3720
+          - const: marvell,armada3710
+
+      - description: Globalscale Espressobin boards
+        items:
+          - enum:
+              - globalscale,espressobin-emmc
+              - globalscale,espressobin-ultra
+              - globalscale,espressobin-v7
+          - const: globalscale,espressobin
+          - const: marvell,armada3720
+          - const: marvell,armada3710
+
+      - description: Globalscale Espressobin V7 boards
+        items:
+          - enum:
+              - globalscale,espressobin-v7-emmc
+          - const: globalscale,espressobin-v7
+          - const: globalscale,espressobin
+          - const: marvell,armada3720
+          - const: marvell,armada3710
+
+additionalProperties: true
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v4 03/10] arm64: dts: marvell: espressobin-ultra: add generic Espressobin compatible
  2022-05-16 12:48 [PATCH v4 01/10] dt-bindings: vendor-prefixes: add Methode Electronics Robert Marko
  2022-05-16 12:48 ` [PATCH v4 02/10] dt-bindings: marvell: convert Armada 37xx compatibles to YAML Robert Marko
@ 2022-05-16 12:48 ` Robert Marko
  2022-05-16 12:48 ` [PATCH v4 04/10] arm64: dts: marvell: uDPU: add missing SoC compatible Robert Marko
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 16+ messages in thread
From: Robert Marko @ 2022-05-16 12:48 UTC (permalink / raw)
  To: robh+dt, krzysztof.kozlowski+dt, andrew, gregory.clement,
	sebastian.hesselbarth, kostap, devicetree, linux-kernel,
	linux-arm-kernel
  Cc: Robert Marko, Krzysztof Kozlowski

Espressobin Ultra is part of the Espressobin family and shares the basic
design, so add the generic "globalscale,espressobin" compatible to it as
well.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
index 070725b81be5..1b2ed63ae6a2 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
@@ -12,8 +12,8 @@
 
 / {
 	model = "Globalscale Marvell ESPRESSOBin Ultra Board";
-	compatible = "globalscale,espressobin-ultra", "marvell,armada3720",
-		     "marvell,armada3710";
+	compatible = "globalscale,espressobin-ultra", "globalscale,espressobin",
+		     "marvell,armada3720", "marvell,armada3710";
 
 	aliases {
 		/* ethernet1 is WAN port */
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v4 04/10] arm64: dts: marvell: uDPU: add missing SoC compatible
  2022-05-16 12:48 [PATCH v4 01/10] dt-bindings: vendor-prefixes: add Methode Electronics Robert Marko
  2022-05-16 12:48 ` [PATCH v4 02/10] dt-bindings: marvell: convert Armada 37xx compatibles to YAML Robert Marko
  2022-05-16 12:48 ` [PATCH v4 03/10] arm64: dts: marvell: espressobin-ultra: add generic Espressobin compatible Robert Marko
@ 2022-05-16 12:48 ` Robert Marko
  2022-05-16 12:48 ` [PATCH v4 05/10] arm64: dts: marvell: uDPU: align LED-s with bindings Robert Marko
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 16+ messages in thread
From: Robert Marko @ 2022-05-16 12:48 UTC (permalink / raw)
  To: robh+dt, krzysztof.kozlowski+dt, andrew, gregory.clement,
	sebastian.hesselbarth, kostap, devicetree, linux-kernel,
	linux-arm-kernel
  Cc: Robert Marko, Krzysztof Kozlowski

According to the bindings, all boards using Armada 37xx SoC-s must have
"marvell,armada3710" compatible while 3720 based ones should also have
"marvell,armada3720" before it.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
index a35317d24d6c..4ae1688e6627 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
@@ -16,7 +16,7 @@
 
 / {
 	model = "Methode uDPU Board";
-	compatible = "methode,udpu", "marvell,armada3720";
+	compatible = "methode,udpu", "marvell,armada3720", "marvell,armada3710";
 
 	chosen {
 		stdout-path = "serial0:115200n8";
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v4 05/10] arm64: dts: marvell: uDPU: align LED-s with bindings
  2022-05-16 12:48 [PATCH v4 01/10] dt-bindings: vendor-prefixes: add Methode Electronics Robert Marko
                   ` (2 preceding siblings ...)
  2022-05-16 12:48 ` [PATCH v4 04/10] arm64: dts: marvell: uDPU: add missing SoC compatible Robert Marko
@ 2022-05-16 12:48 ` Robert Marko
  2022-05-16 12:48 ` [PATCH v4 06/10] arm64: dts: marvell: uDPU: remove LED node pinctrl-names Robert Marko
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 16+ messages in thread
From: Robert Marko @ 2022-05-16 12:48 UTC (permalink / raw)
  To: robh+dt, krzysztof.kozlowski+dt, andrew, gregory.clement,
	sebastian.hesselbarth, kostap, devicetree, linux-kernel,
	linux-arm-kernel
  Cc: Robert Marko, Krzysztof Kozlowski

According to bindings they LED-s should be prefixed with "led" in this
use case, so fix accordingly.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
index 4ae1688e6627..f216777acacc 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
@@ -31,32 +31,32 @@ leds {
 		pinctrl-names = "default";
 		compatible = "gpio-leds";
 
-		power1 {
+		led-power1 {
 			label = "udpu:green:power";
 			gpios = <&gpionb 11 GPIO_ACTIVE_LOW>;
 		};
 
-		power2 {
+		led-power2 {
 			label = "udpu:red:power";
 			gpios = <&gpionb 12 GPIO_ACTIVE_LOW>;
 		};
 
-		network1 {
+		led-network1 {
 			label = "udpu:green:network";
 			gpios = <&gpionb 13 GPIO_ACTIVE_LOW>;
 		};
 
-		network2 {
+		led-network2 {
 			label = "udpu:red:network";
 			gpios = <&gpionb 14 GPIO_ACTIVE_LOW>;
 		};
 
-		alarm1 {
+		led-alarm1 {
 			label = "udpu:green:alarm";
 			gpios = <&gpionb 15 GPIO_ACTIVE_LOW>;
 		};
 
-		alarm2 {
+		led-alarm2 {
 			label = "udpu:red:alarm";
 			gpios = <&gpionb 16 GPIO_ACTIVE_LOW>;
 		};
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v4 06/10] arm64: dts: marvell: uDPU: remove LED node pinctrl-names
  2022-05-16 12:48 [PATCH v4 01/10] dt-bindings: vendor-prefixes: add Methode Electronics Robert Marko
                   ` (3 preceding siblings ...)
  2022-05-16 12:48 ` [PATCH v4 05/10] arm64: dts: marvell: uDPU: align LED-s with bindings Robert Marko
@ 2022-05-16 12:48 ` Robert Marko
  2022-05-16 12:48 ` [PATCH v4 07/10] arm64: dts: marvell: rename temp sensor nodes Robert Marko
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 16+ messages in thread
From: Robert Marko @ 2022-05-16 12:48 UTC (permalink / raw)
  To: robh+dt, krzysztof.kozlowski+dt, andrew, gregory.clement,
	sebastian.hesselbarth, kostap, devicetree, linux-kernel,
	linux-arm-kernel
  Cc: Robert Marko, Krzysztof Kozlowski

Using pinctrl-names requires the appropriate pinctrl-0 property, otherwise
it is not utilized at all.

Since its not required, just remove it.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
index f216777acacc..b89c7455612d 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
@@ -28,7 +28,6 @@ memory@0 {
 	};
 
 	leds {
-		pinctrl-names = "default";
 		compatible = "gpio-leds";
 
 		led-power1 {
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v4 07/10] arm64: dts: marvell: rename temp sensor nodes
  2022-05-16 12:48 [PATCH v4 01/10] dt-bindings: vendor-prefixes: add Methode Electronics Robert Marko
                   ` (4 preceding siblings ...)
  2022-05-16 12:48 ` [PATCH v4 06/10] arm64: dts: marvell: uDPU: remove LED node pinctrl-names Robert Marko
@ 2022-05-16 12:48 ` Robert Marko
  2022-05-16 12:48 ` [PATCH v4 08/10] arm64: dts: marvell: split Methode uDPU DTS Robert Marko
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 16+ messages in thread
From: Robert Marko @ 2022-05-16 12:48 UTC (permalink / raw)
  To: robh+dt, krzysztof.kozlowski+dt, andrew, gregory.clement,
	sebastian.hesselbarth, kostap, devicetree, linux-kernel,
	linux-arm-kernel
  Cc: Robert Marko, Krzysztof Kozlowski

Rename the temperature sensor nodes to use "temp-sensor" which matches
their device class instead of IC specific naming.

Remove the status = "okay" which is not required as its default anyway.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
index b89c7455612d..f21a855fc608 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
@@ -152,14 +152,12 @@ &i2c1 {
 	scl-gpios = <&gpionb 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
 	sda-gpios = <&gpionb 3 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
 
-	nct375@48 {
-		status = "okay";
+	temp-sensor@48 {
 		compatible = "ti,tmp75c";
 		reg = <0x48>;
 	};
 
-	nct375@49 {
-		status = "okay";
+	temp-sensor@49 {
 		compatible = "ti,tmp75c";
 		reg = <0x49>;
 	};
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v4 08/10] arm64: dts: marvell: split Methode uDPU DTS
  2022-05-16 12:48 [PATCH v4 01/10] dt-bindings: vendor-prefixes: add Methode Electronics Robert Marko
                   ` (5 preceding siblings ...)
  2022-05-16 12:48 ` [PATCH v4 07/10] arm64: dts: marvell: rename temp sensor nodes Robert Marko
@ 2022-05-16 12:48 ` Robert Marko
  2022-05-16 12:48 ` [PATCH v4 09/10] dt-bindings: marvell: armada-37xx: add Methode eDPU compatible Robert Marko
  2022-05-16 12:48 ` [PATCH v4 10/10] arm64: dts: marvell: add support for Methode eDPU Robert Marko
  8 siblings, 0 replies; 16+ messages in thread
From: Robert Marko @ 2022-05-16 12:48 UTC (permalink / raw)
  To: robh+dt, krzysztof.kozlowski+dt, andrew, gregory.clement,
	sebastian.hesselbarth, kostap, devicetree, linux-kernel,
	linux-arm-kernel
  Cc: Robert Marko, Krzysztof Kozlowski

Split the Methode uDPU DTS into a common DTSI as preparation for adding
support for Methode eDPU which is based on the uDPU to avoid duplication.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../boot/dts/marvell/armada-3720-uDPU.dts     | 150 +---------------
 .../boot/dts/marvell/armada-3720-uDPU.dtsi    | 160 ++++++++++++++++++
 2 files changed, 161 insertions(+), 149 deletions(-)
 create mode 100644 arch/arm64/boot/dts/marvell/armada-3720-uDPU.dtsi

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
index f21a855fc608..a75734d88a4f 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
@@ -1,66 +1,13 @@
 // SPDX-License-Identifier: (GPL-2.0+ OR MIT)
-/*
- * Device tree for the uDPU board.
- * Based on Marvell Armada 3720 development board (DB-88F3720-DDR3)
- * Copyright (C) 2016 Marvell
- * Copyright (C) 2019 Methode Electronics
- * Copyright (C) 2019 Telus
- *
- * Vladimir Vid <vladimir.vid@sartura.hr>
- */
 
 /dts-v1/;
 
-#include <dt-bindings/gpio/gpio.h>
-#include "armada-372x.dtsi"
+#include "armada-3720-uDPU.dtsi"
 
 / {
 	model = "Methode uDPU Board";
 	compatible = "methode,udpu", "marvell,armada3720", "marvell,armada3710";
 
-	chosen {
-		stdout-path = "serial0:115200n8";
-	};
-
-	memory@0 {
-		device_type = "memory";
-		reg = <0x00000000 0x00000000 0x00000000 0x20000000>;
-	};
-
-	leds {
-		compatible = "gpio-leds";
-
-		led-power1 {
-			label = "udpu:green:power";
-			gpios = <&gpionb 11 GPIO_ACTIVE_LOW>;
-		};
-
-		led-power2 {
-			label = "udpu:red:power";
-			gpios = <&gpionb 12 GPIO_ACTIVE_LOW>;
-		};
-
-		led-network1 {
-			label = "udpu:green:network";
-			gpios = <&gpionb 13 GPIO_ACTIVE_LOW>;
-		};
-
-		led-network2 {
-			label = "udpu:red:network";
-			gpios = <&gpionb 14 GPIO_ACTIVE_LOW>;
-		};
-
-		led-alarm1 {
-			label = "udpu:green:alarm";
-			gpios = <&gpionb 15 GPIO_ACTIVE_LOW>;
-		};
-
-		led-alarm2 {
-			label = "udpu:red:alarm";
-			gpios = <&gpionb 16 GPIO_ACTIVE_LOW>;
-		};
-	};
-
 	sfp_eth0: sfp-eth0 {
 		compatible = "sff,sfp";
 		i2c-bus = <&i2c0>;
@@ -70,55 +17,6 @@ sfp_eth0: sfp-eth0 {
 		tx-fault-gpio = <&gpiosb 5 GPIO_ACTIVE_HIGH>;
 		maximum-power-milliwatt = <3000>;
 	};
-
-	sfp_eth1: sfp-eth1 {
-		compatible = "sff,sfp";
-		i2c-bus = <&i2c1>;
-		los-gpio = <&gpiosb 7 GPIO_ACTIVE_HIGH>;
-		mod-def0-gpio = <&gpiosb 8 GPIO_ACTIVE_LOW>;
-		tx-disable-gpio = <&gpiosb 9 GPIO_ACTIVE_HIGH>;
-		tx-fault-gpio = <&gpiosb 10 GPIO_ACTIVE_HIGH>;
-		maximum-power-milliwatt = <3000>;
-	};
-};
-
-&sdhci0 {
-	status = "okay";
-	bus-width = <8>;
-	mmc-ddr-1_8v;
-	mmc-hs400-1_8v;
-	marvell,pad-type = "fixed-1-8v";
-	non-removable;
-	no-sd;
-	no-sdio;
-};
-
-&spi0 {
-	status = "okay";
-	pinctrl-names = "default";
-	pinctrl-0 = <&spi_quad_pins>;
-
-	flash@0 {
-		compatible = "jedec,spi-nor";
-		reg = <0>;
-		spi-max-frequency = <54000000>;
-
-		partitions {
-			compatible = "fixed-partitions";
-			#address-cells = <1>;
-			#size-cells = <1>;
-
-			partition@0 {
-				label = "firmware";
-				reg = <0x0 0x180000>;
-			};
-
-			partition@180000 {
-				label = "u-boot-env";
-				reg = <0x180000 0x10000>;
-			};
-		};
-	};
 };
 
 &pinctrl_nb {
@@ -126,11 +24,6 @@ i2c1_recovery_pins: i2c1-recovery-pins {
 		groups = "i2c1";
 		function = "gpio";
 	};
-
-	i2c2_recovery_pins: i2c2-recovery-pins {
-		groups = "i2c2";
-		function = "gpio";
-	};
 };
 
 &i2c0 {
@@ -143,48 +36,7 @@ &i2c0 {
 	sda-gpios = <&gpionb 1 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
 };
 
-&i2c1 {
-	status = "okay";
-	pinctrl-names = "default", "recovery";
-	pinctrl-0 = <&i2c2_pins>;
-	pinctrl-1 = <&i2c2_recovery_pins>;
-	/delete-property/mrvl,i2c-fast-mode;
-	scl-gpios = <&gpionb 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
-	sda-gpios = <&gpionb 3 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
-
-	temp-sensor@48 {
-		compatible = "ti,tmp75c";
-		reg = <0x48>;
-	};
-
-	temp-sensor@49 {
-		compatible = "ti,tmp75c";
-		reg = <0x49>;
-	};
-};
-
 &eth0 {
 	phy-mode = "sgmii";
-	status = "okay";
-	managed = "in-band-status";
-	phys = <&comphy1 0>;
 	sfp = <&sfp_eth0>;
 };
-
-&eth1 {
-	phy-mode = "sgmii";
-	status = "okay";
-	managed = "in-band-status";
-	phys = <&comphy0 1>;
-	sfp = <&sfp_eth1>;
-};
-
-&usb3 {
-	status = "okay";
-	phys = <&usb2_utmi_otg_phy>;
-	phy-names = "usb2-utmi-otg-phy";
-};
-
-&uart0 {
-	status = "okay";
-};
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dtsi b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dtsi
new file mode 100644
index 000000000000..3f79923376fb
--- /dev/null
+++ b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dtsi
@@ -0,0 +1,160 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Device tree for the uDPU board.
+ * Based on Marvell Armada 3720 development board (DB-88F3720-DDR3)
+ * Copyright (C) 2016 Marvell
+ * Copyright (C) 2019 Methode Electronics
+ * Copyright (C) 2019 Telus
+ *
+ * Vladimir Vid <vladimir.vid@sartura.hr>
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include "armada-372x.dtsi"
+
+/ {
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
+	memory@0 {
+		device_type = "memory";
+		reg = <0x00000000 0x00000000 0x00000000 0x20000000>;
+	};
+
+	leds {
+		compatible = "gpio-leds";
+
+		led-power1 {
+			label = "udpu:green:power";
+			gpios = <&gpionb 11 GPIO_ACTIVE_LOW>;
+		};
+
+		led-power2 {
+			label = "udpu:red:power";
+			gpios = <&gpionb 12 GPIO_ACTIVE_LOW>;
+		};
+
+		led-network1 {
+			label = "udpu:green:network";
+			gpios = <&gpionb 13 GPIO_ACTIVE_LOW>;
+		};
+
+		led-network2 {
+			label = "udpu:red:network";
+			gpios = <&gpionb 14 GPIO_ACTIVE_LOW>;
+		};
+
+		led-alarm1 {
+			label = "udpu:green:alarm";
+			gpios = <&gpionb 15 GPIO_ACTIVE_LOW>;
+		};
+
+		led-alarm2 {
+			label = "udpu:red:alarm";
+			gpios = <&gpionb 16 GPIO_ACTIVE_LOW>;
+		};
+	};
+
+	sfp_eth1: sfp-eth1 {
+		compatible = "sff,sfp";
+		i2c-bus = <&i2c1>;
+		los-gpio = <&gpiosb 7 GPIO_ACTIVE_HIGH>;
+		mod-def0-gpio = <&gpiosb 8 GPIO_ACTIVE_LOW>;
+		tx-disable-gpio = <&gpiosb 9 GPIO_ACTIVE_HIGH>;
+		tx-fault-gpio = <&gpiosb 10 GPIO_ACTIVE_HIGH>;
+		maximum-power-milliwatt = <3000>;
+	};
+};
+
+&sdhci0 {
+	status = "okay";
+	bus-width = <8>;
+	mmc-ddr-1_8v;
+	mmc-hs400-1_8v;
+	marvell,pad-type = "fixed-1-8v";
+	non-removable;
+	no-sd;
+	no-sdio;
+};
+
+&spi0 {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&spi_quad_pins>;
+
+	flash@0 {
+		compatible = "jedec,spi-nor";
+		reg = <0>;
+		spi-max-frequency = <54000000>;
+
+		partitions {
+			compatible = "fixed-partitions";
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			partition@0 {
+				label = "firmware";
+				reg = <0x0 0x180000>;
+			};
+
+			partition@180000 {
+				label = "u-boot-env";
+				reg = <0x180000 0x10000>;
+			};
+		};
+	};
+};
+
+&pinctrl_nb {
+	i2c2_recovery_pins: i2c2-recovery-pins {
+		groups = "i2c2";
+		function = "gpio";
+	};
+};
+
+&i2c1 {
+	status = "okay";
+	pinctrl-names = "default", "recovery";
+	pinctrl-0 = <&i2c2_pins>;
+	pinctrl-1 = <&i2c2_recovery_pins>;
+	/delete-property/mrvl,i2c-fast-mode;
+	scl-gpios = <&gpionb 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
+	sda-gpios = <&gpionb 3 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
+
+	temp-sensor@48 {
+		compatible = "ti,tmp75c";
+		reg = <0x48>;
+	};
+
+	temp-sensor@49 {
+		compatible = "ti,tmp75c";
+		reg = <0x49>;
+	};
+};
+
+&eth0 {
+	status = "okay";
+	managed = "in-band-status";
+	phys = <&comphy1 0>;
+};
+
+&eth1 {
+	phy-mode = "sgmii";
+	status = "okay";
+	managed = "in-band-status";
+	phys = <&comphy0 1>;
+	sfp = <&sfp_eth1>;
+};
+
+&usb3 {
+	status = "okay";
+	phys = <&usb2_utmi_otg_phy>;
+	phy-names = "usb2-utmi-otg-phy";
+};
+
+&uart0 {
+	status = "okay";
+};
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v4 09/10] dt-bindings: marvell: armada-37xx: add Methode eDPU compatible
  2022-05-16 12:48 [PATCH v4 01/10] dt-bindings: vendor-prefixes: add Methode Electronics Robert Marko
                   ` (6 preceding siblings ...)
  2022-05-16 12:48 ` [PATCH v4 08/10] arm64: dts: marvell: split Methode uDPU DTS Robert Marko
@ 2022-05-16 12:48 ` Robert Marko
  2022-05-16 12:48 ` [PATCH v4 10/10] arm64: dts: marvell: add support for Methode eDPU Robert Marko
  8 siblings, 0 replies; 16+ messages in thread
From: Robert Marko @ 2022-05-16 12:48 UTC (permalink / raw)
  To: robh+dt, krzysztof.kozlowski+dt, andrew, gregory.clement,
	sebastian.hesselbarth, kostap, devicetree, linux-kernel,
	linux-arm-kernel
  Cc: Robert Marko, Krzysztof Kozlowski

Document compatible for the Methode eDPU Armada 3720 based board.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes in v3:
* Alphabetical ordering
---
 Documentation/devicetree/bindings/arm/marvell/armada-37xx.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-37xx.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-37xx.yaml
index cd7a77d1fdc0..6905d29f3108 100644
--- a/Documentation/devicetree/bindings/arm/marvell/armada-37xx.yaml
+++ b/Documentation/devicetree/bindings/arm/marvell/armada-37xx.yaml
@@ -20,6 +20,7 @@ properties:
               - cznic,turris-mox
               - globalscale,espressobin
               - marvell,armada-3720-db
+              - methode,edpu
               - methode,udpu
           - const: marvell,armada3720
           - const: marvell,armada3710
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v4 10/10] arm64: dts: marvell: add support for Methode eDPU
  2022-05-16 12:48 [PATCH v4 01/10] dt-bindings: vendor-prefixes: add Methode Electronics Robert Marko
                   ` (7 preceding siblings ...)
  2022-05-16 12:48 ` [PATCH v4 09/10] dt-bindings: marvell: armada-37xx: add Methode eDPU compatible Robert Marko
@ 2022-05-16 12:48 ` Robert Marko
  2022-08-08 11:42   ` Robert Marko
  8 siblings, 1 reply; 16+ messages in thread
From: Robert Marko @ 2022-05-16 12:48 UTC (permalink / raw)
  To: robh+dt, krzysztof.kozlowski+dt, andrew, gregory.clement,
	sebastian.hesselbarth, kostap, devicetree, linux-kernel,
	linux-arm-kernel
  Cc: Robert Marko, Krzysztof Kozlowski

Methode eDPU is an Armada 3720 powered board based on the Methode uDPU.

They feature the same CPU, RAM, and storage as well as the form factor.

However, eDPU only has one SFP slot plus a copper G.hn port.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes in v2:
* Make the DTS split a separate commit
---
 arch/arm64/boot/dts/marvell/Makefile             |  1 +
 arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts | 14 ++++++++++++++
 2 files changed, 15 insertions(+)
 create mode 100644 arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts

diff --git a/arch/arm64/boot/dts/marvell/Makefile b/arch/arm64/boot/dts/marvell/Makefile
index 1c794cdcb8e6..104d7d7e8215 100644
--- a/arch/arm64/boot/dts/marvell/Makefile
+++ b/arch/arm64/boot/dts/marvell/Makefile
@@ -1,6 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 # Mvebu SoC Family
 dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-db.dtb
+dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-eDPU.dtb
 dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin.dtb
 dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-emmc.dtb
 dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-ultra.dtb
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
new file mode 100644
index 000000000000..57fc698e55d0
--- /dev/null
+++ b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
@@ -0,0 +1,14 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+
+/dts-v1/;
+
+#include "armada-3720-uDPU.dtsi"
+
+/ {
+	model = "Methode eDPU Board";
+	compatible = "methode,edpu", "marvell,armada3720", "marvell,armada3710";
+};
+
+&eth0 {
+	phy-mode = "2500base-x";
+};
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH v4 10/10] arm64: dts: marvell: add support for Methode eDPU
  2022-05-16 12:48 ` [PATCH v4 10/10] arm64: dts: marvell: add support for Methode eDPU Robert Marko
@ 2022-08-08 11:42   ` Robert Marko
  2022-08-30  7:42     ` Gregory CLEMENT
  0 siblings, 1 reply; 16+ messages in thread
From: Robert Marko @ 2022-08-08 11:42 UTC (permalink / raw)
  To: robh+dt, krzysztof.kozlowski+dt, andrew, gregory.clement,
	sebastian.hesselbarth, kostap, devicetree, linux-kernel,
	linux-arm-kernel
  Cc: Krzysztof Kozlowski

On Mon, May 16, 2022 at 2:48 PM Robert Marko <robert.marko@sartura.hr> wrote:
>
> Methode eDPU is an Armada 3720 powered board based on the Methode uDPU.
>
> They feature the same CPU, RAM, and storage as well as the form factor.
>
> However, eDPU only has one SFP slot plus a copper G.hn port.
>
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Changes in v2:
> * Make the DTS split a separate commit
> ---
>  arch/arm64/boot/dts/marvell/Makefile             |  1 +
>  arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts | 14 ++++++++++++++
>  2 files changed, 15 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
>
> diff --git a/arch/arm64/boot/dts/marvell/Makefile b/arch/arm64/boot/dts/marvell/Makefile
> index 1c794cdcb8e6..104d7d7e8215 100644
> --- a/arch/arm64/boot/dts/marvell/Makefile
> +++ b/arch/arm64/boot/dts/marvell/Makefile
> @@ -1,6 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0
>  # Mvebu SoC Family
>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-db.dtb
> +dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-eDPU.dtb
>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin.dtb
>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-emmc.dtb
>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-ultra.dtb
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
> new file mode 100644
> index 000000000000..57fc698e55d0
> --- /dev/null
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
> @@ -0,0 +1,14 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +
> +/dts-v1/;
> +
> +#include "armada-3720-uDPU.dtsi"
> +
> +/ {
> +       model = "Methode eDPU Board";
> +       compatible = "methode,edpu", "marvell,armada3720", "marvell,armada3710";
> +};
> +
> +&eth0 {
> +       phy-mode = "2500base-x";
> +};
> --
> 2.36.1
>

Hi Gregory,
Is there something else that I can improve in the series?

Regards,
Robert

-- 
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@sartura.hr
Web: www.sartura.hr

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v4 10/10] arm64: dts: marvell: add support for Methode eDPU
  2022-08-08 11:42   ` Robert Marko
@ 2022-08-30  7:42     ` Gregory CLEMENT
  2022-08-31 11:12       ` Robert Marko
  0 siblings, 1 reply; 16+ messages in thread
From: Gregory CLEMENT @ 2022-08-30  7:42 UTC (permalink / raw)
  To: Robert Marko, robh+dt, krzysztof.kozlowski+dt, andrew,
	sebastian.hesselbarth, kostap, devicetree, linux-kernel,
	linux-arm-kernel
  Cc: Krzysztof Kozlowski

Robert Marko <robert.marko@sartura.hr> writes:

> On Mon, May 16, 2022 at 2:48 PM Robert Marko <robert.marko@sartura.hr> wrote:
>>
>> Methode eDPU is an Armada 3720 powered board based on the Methode uDPU.
>>
>> They feature the same CPU, RAM, and storage as well as the form factor.
>>
>> However, eDPU only has one SFP slot plus a copper G.hn port.
>>
>> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> Changes in v2:
>> * Make the DTS split a separate commit
>> ---
>>  arch/arm64/boot/dts/marvell/Makefile             |  1 +
>>  arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts | 14 ++++++++++++++
>>  2 files changed, 15 insertions(+)
>>  create mode 100644 arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
>>
>> diff --git a/arch/arm64/boot/dts/marvell/Makefile b/arch/arm64/boot/dts/marvell/Makefile
>> index 1c794cdcb8e6..104d7d7e8215 100644
>> --- a/arch/arm64/boot/dts/marvell/Makefile
>> +++ b/arch/arm64/boot/dts/marvell/Makefile
>> @@ -1,6 +1,7 @@
>>  # SPDX-License-Identifier: GPL-2.0
>>  # Mvebu SoC Family
>>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-db.dtb
>> +dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-eDPU.dtb
>>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin.dtb
>>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-emmc.dtb
>>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-ultra.dtb
>> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
>> new file mode 100644
>> index 000000000000..57fc698e55d0
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
>> @@ -0,0 +1,14 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +
>> +/dts-v1/;
>> +
>> +#include "armada-3720-uDPU.dtsi"
>> +
>> +/ {
>> +       model = "Methode eDPU Board";
>> +       compatible = "methode,edpu", "marvell,armada3720", "marvell,armada3710";
>> +};
>> +
>> +&eth0 {
>> +       phy-mode = "2500base-x";
>> +};
>> --
>> 2.36.1
>>
>
> Hi Gregory,
Hello Roberto,

> Is there something else that I can improve in the series?

Sorry for having missed this series. At first view it seems OK, I am
going to have a closer look this week.

Gregory


>
> Regards,
> Robert
>
> -- 
> Robert Marko
> Staff Embedded Linux Engineer
> Sartura Ltd.
> Lendavska ulica 16a
> 10000 Zagreb, Croatia
> Email: robert.marko@sartura.hr
> Web: www.sartura.hr

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v4 10/10] arm64: dts: marvell: add support for Methode eDPU
  2022-08-30  7:42     ` Gregory CLEMENT
@ 2022-08-31 11:12       ` Robert Marko
  2022-09-02 15:22         ` Gregory CLEMENT
  0 siblings, 1 reply; 16+ messages in thread
From: Robert Marko @ 2022-08-31 11:12 UTC (permalink / raw)
  To: Gregory CLEMENT
  Cc: robh+dt, krzysztof.kozlowski+dt, andrew, sebastian.hesselbarth,
	kostap, devicetree, linux-kernel, linux-arm-kernel,
	Krzysztof Kozlowski

On Tue, Aug 30, 2022 at 9:42 AM Gregory CLEMENT
<gregory.clement@bootlin.com> wrote:
>
> Robert Marko <robert.marko@sartura.hr> writes:
>
> > On Mon, May 16, 2022 at 2:48 PM Robert Marko <robert.marko@sartura.hr> wrote:
> >>
> >> Methode eDPU is an Armada 3720 powered board based on the Methode uDPU.
> >>
> >> They feature the same CPU, RAM, and storage as well as the form factor.
> >>
> >> However, eDPU only has one SFP slot plus a copper G.hn port.
> >>
> >> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> ---
> >> Changes in v2:
> >> * Make the DTS split a separate commit
> >> ---
> >>  arch/arm64/boot/dts/marvell/Makefile             |  1 +
> >>  arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts | 14 ++++++++++++++
> >>  2 files changed, 15 insertions(+)
> >>  create mode 100644 arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
> >>
> >> diff --git a/arch/arm64/boot/dts/marvell/Makefile b/arch/arm64/boot/dts/marvell/Makefile
> >> index 1c794cdcb8e6..104d7d7e8215 100644
> >> --- a/arch/arm64/boot/dts/marvell/Makefile
> >> +++ b/arch/arm64/boot/dts/marvell/Makefile
> >> @@ -1,6 +1,7 @@
> >>  # SPDX-License-Identifier: GPL-2.0
> >>  # Mvebu SoC Family
> >>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-db.dtb
> >> +dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-eDPU.dtb
> >>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin.dtb
> >>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-emmc.dtb
> >>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-ultra.dtb
> >> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
> >> new file mode 100644
> >> index 000000000000..57fc698e55d0
> >> --- /dev/null
> >> +++ b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
> >> @@ -0,0 +1,14 @@
> >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> >> +
> >> +/dts-v1/;
> >> +
> >> +#include "armada-3720-uDPU.dtsi"
> >> +
> >> +/ {
> >> +       model = "Methode eDPU Board";
> >> +       compatible = "methode,edpu", "marvell,armada3720", "marvell,armada3710";
> >> +};
> >> +
> >> +&eth0 {
> >> +       phy-mode = "2500base-x";
> >> +};
> >> --
> >> 2.36.1
> >>
> >
> > Hi Gregory,
> Hello Roberto,
>
> > Is there something else that I can improve in the series?
>
> Sorry for having missed this series. At first view it seems OK, I am
> going to have a closer look this week.

Thanks, that sounds good.

Regards,
Robert
>
> Gregory
>
>
> >
> > Regards,
> > Robert
> >
> > --
> > Robert Marko
> > Staff Embedded Linux Engineer
> > Sartura Ltd.
> > Lendavska ulica 16a
> > 10000 Zagreb, Croatia
> > Email: robert.marko@sartura.hr
> > Web: www.sartura.hr
>
> --
> Gregory Clement, Bootlin
> Embedded Linux and Kernel engineering
> http://bootlin.com



-- 
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@sartura.hr
Web: www.sartura.hr

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v4 10/10] arm64: dts: marvell: add support for Methode eDPU
  2022-08-31 11:12       ` Robert Marko
@ 2022-09-02 15:22         ` Gregory CLEMENT
  2022-09-02 16:13           ` Gregory CLEMENT
  0 siblings, 1 reply; 16+ messages in thread
From: Gregory CLEMENT @ 2022-09-02 15:22 UTC (permalink / raw)
  To: Robert Marko
  Cc: robh+dt, krzysztof.kozlowski+dt, andrew, sebastian.hesselbarth,
	kostap, devicetree, linux-kernel, linux-arm-kernel,
	Krzysztof Kozlowski

Robert Marko <robert.marko@sartura.hr> writes:

> On Tue, Aug 30, 2022 at 9:42 AM Gregory CLEMENT
> <gregory.clement@bootlin.com> wrote:
>>
>> Robert Marko <robert.marko@sartura.hr> writes:
>>
>> > On Mon, May 16, 2022 at 2:48 PM Robert Marko <robert.marko@sartura.hr> wrote:
>> >>
>> >> Methode eDPU is an Armada 3720 powered board based on the Methode uDPU.
>> >>
>> >> They feature the same CPU, RAM, and storage as well as the form factor.
>> >>
>> >> However, eDPU only has one SFP slot plus a copper G.hn port.
>> >>
>> >> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
>> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> >> ---
>> >> Changes in v2:
>> >> * Make the DTS split a separate commit
>> >> ---
>> >>  arch/arm64/boot/dts/marvell/Makefile             |  1 +
>> >>  arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts | 14 ++++++++++++++
>> >>  2 files changed, 15 insertions(+)
>> >>  create mode 100644 arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
>> >>
>> >> diff --git a/arch/arm64/boot/dts/marvell/Makefile b/arch/arm64/boot/dts/marvell/Makefile
>> >> index 1c794cdcb8e6..104d7d7e8215 100644
>> >> --- a/arch/arm64/boot/dts/marvell/Makefile
>> >> +++ b/arch/arm64/boot/dts/marvell/Makefile
>> >> @@ -1,6 +1,7 @@
>> >>  # SPDX-License-Identifier: GPL-2.0
>> >>  # Mvebu SoC Family
>> >>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-db.dtb
>> >> +dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-eDPU.dtb
>> >>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin.dtb
>> >>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-emmc.dtb
>> >>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-ultra.dtb
>> >> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
>> >> new file mode 100644
>> >> index 000000000000..57fc698e55d0
>> >> --- /dev/null
>> >> +++ b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
>> >> @@ -0,0 +1,14 @@
>> >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> >> +
>> >> +/dts-v1/;
>> >> +
>> >> +#include "armada-3720-uDPU.dtsi"
>> >> +
>> >> +/ {
>> >> +       model = "Methode eDPU Board";
>> >> +       compatible = "methode,edpu", "marvell,armada3720", "marvell,armada3710";
>> >> +};
>> >> +
>> >> +&eth0 {
>> >> +       phy-mode = "2500base-x";
>> >> +};
>> >> --
>> >> 2.36.1
>> >>
>> >
>> > Hi Gregory,
>> Hello Roberto,
>>
>> > Is there something else that I can improve in the series?
>>
>> Sorry for having missed this series. At first view it seems OK, I am
>> going to have a closer look this week.
>
> Thanks, that sounds good.

Hello,

could you send again patch 8, I managed to apply all the other ones
excepting this one.

Thanks,

Gregory


>
> Regards,
> Robert
>>
>> Gregory
>>
>>
>> >
>> > Regards,
>> > Robert
>> >
>> > --
>> > Robert Marko
>> > Staff Embedded Linux Engineer
>> > Sartura Ltd.
>> > Lendavska ulica 16a
>> > 10000 Zagreb, Croatia
>> > Email: robert.marko@sartura.hr
>> > Web: www.sartura.hr
>>
>> --
>> Gregory Clement, Bootlin
>> Embedded Linux and Kernel engineering
>> http://bootlin.com
>
>
>
> -- 
> Robert Marko
> Staff Embedded Linux Engineer
> Sartura Ltd.
> Lendavska ulica 16a
> 10000 Zagreb, Croatia
> Email: robert.marko@sartura.hr
> Web: www.sartura.hr

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v4 10/10] arm64: dts: marvell: add support for Methode eDPU
  2022-09-02 15:22         ` Gregory CLEMENT
@ 2022-09-02 16:13           ` Gregory CLEMENT
  2022-09-02 17:26             ` Robert Marko
  0 siblings, 1 reply; 16+ messages in thread
From: Gregory CLEMENT @ 2022-09-02 16:13 UTC (permalink / raw)
  To: Robert Marko
  Cc: robh+dt, krzysztof.kozlowski+dt, andrew, sebastian.hesselbarth,
	kostap, devicetree, linux-kernel, linux-arm-kernel,
	Krzysztof Kozlowski

Gregory CLEMENT <gregory.clement@bootlin.com> writes:

> Robert Marko <robert.marko@sartura.hr> writes:
>
>> On Tue, Aug 30, 2022 at 9:42 AM Gregory CLEMENT
>> <gregory.clement@bootlin.com> wrote:
>>>
>>> Robert Marko <robert.marko@sartura.hr> writes:
>>>
>>> > On Mon, May 16, 2022 at 2:48 PM Robert Marko <robert.marko@sartura.hr> wrote:
>>> >>
>>> >> Methode eDPU is an Armada 3720 powered board based on the Methode uDPU.
>>> >>
>>> >> They feature the same CPU, RAM, and storage as well as the form factor.
>>> >>
>>> >> However, eDPU only has one SFP slot plus a copper G.hn port.
>>> >>
>>> >> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
>>> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> >> ---
>>> >> Changes in v2:
>>> >> * Make the DTS split a separate commit
>>> >> ---
>>> >>  arch/arm64/boot/dts/marvell/Makefile             |  1 +
>>> >>  arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts | 14 ++++++++++++++
>>> >>  2 files changed, 15 insertions(+)
>>> >>  create mode 100644 arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
>>> >>
>>> >> diff --git a/arch/arm64/boot/dts/marvell/Makefile b/arch/arm64/boot/dts/marvell/Makefile
>>> >> index 1c794cdcb8e6..104d7d7e8215 100644
>>> >> --- a/arch/arm64/boot/dts/marvell/Makefile
>>> >> +++ b/arch/arm64/boot/dts/marvell/Makefile
>>> >> @@ -1,6 +1,7 @@
>>> >>  # SPDX-License-Identifier: GPL-2.0
>>> >>  # Mvebu SoC Family
>>> >>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-db.dtb
>>> >> +dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-eDPU.dtb
>>> >>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin.dtb
>>> >>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-emmc.dtb
>>> >>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-ultra.dtb
>>> >> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
>>> >> new file mode 100644
>>> >> index 000000000000..57fc698e55d0
>>> >> --- /dev/null
>>> >> +++ b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
>>> >> @@ -0,0 +1,14 @@
>>> >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>>> >> +
>>> >> +/dts-v1/;
>>> >> +
>>> >> +#include "armada-3720-uDPU.dtsi"
>>> >> +
>>> >> +/ {
>>> >> +       model = "Methode eDPU Board";
>>> >> +       compatible = "methode,edpu", "marvell,armada3720", "marvell,armada3710";
>>> >> +};
>>> >> +
>>> >> +&eth0 {
>>> >> +       phy-mode = "2500base-x";
>>> >> +};
>>> >> --
>>> >> 2.36.1
>>> >>
>>> >
>>> > Hi Gregory,
>>> Hello Roberto,
>>>
>>> > Is there something else that I can improve in the series?
>>>
>>> Sorry for having missed this series. At first view it seems OK, I am
>>> going to have a closer look this week.
>>
>> Thanks, that sounds good.
>
> Hello,
>
> could you send again patch 8, I managed to apply all the other ones
> excepting this one.

Finally I managed to sort it out, all the series is applied on mvebu/dt64

Thanks,

Gregory
>
>
>>
>> Regards,
>> Robert
>>>
>>> Gregory
>>>
>>>
>>> >
>>> > Regards,
>>> > Robert
>>> >
>>> > --
>>> > Robert Marko
>>> > Staff Embedded Linux Engineer
>>> > Sartura Ltd.
>>> > Lendavska ulica 16a
>>> > 10000 Zagreb, Croatia
>>> > Email: robert.marko@sartura.hr
>>> > Web: www.sartura.hr
>>>
>>> --
>>> Gregory Clement, Bootlin
>>> Embedded Linux and Kernel engineering
>>> http://bootlin.com
>>
>>
>>
>> -- 
>> Robert Marko
>> Staff Embedded Linux Engineer
>> Sartura Ltd.
>> Lendavska ulica 16a
>> 10000 Zagreb, Croatia
>> Email: robert.marko@sartura.hr
>> Web: www.sartura.hr
>
> -- 
> Gregory Clement, Bootlin
> Embedded Linux and Kernel engineering
> http://bootlin.com
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v4 10/10] arm64: dts: marvell: add support for Methode eDPU
  2022-09-02 16:13           ` Gregory CLEMENT
@ 2022-09-02 17:26             ` Robert Marko
  0 siblings, 0 replies; 16+ messages in thread
From: Robert Marko @ 2022-09-02 17:26 UTC (permalink / raw)
  To: Gregory CLEMENT
  Cc: robh+dt, krzysztof.kozlowski+dt, andrew, sebastian.hesselbarth,
	kostap, devicetree, linux-kernel, linux-arm-kernel,
	Krzysztof Kozlowski

On Fri, Sep 2, 2022 at 6:13 PM Gregory CLEMENT
<gregory.clement@bootlin.com> wrote:
>
> Gregory CLEMENT <gregory.clement@bootlin.com> writes:
>
> > Robert Marko <robert.marko@sartura.hr> writes:
> >
> >> On Tue, Aug 30, 2022 at 9:42 AM Gregory CLEMENT
> >> <gregory.clement@bootlin.com> wrote:
> >>>
> >>> Robert Marko <robert.marko@sartura.hr> writes:
> >>>
> >>> > On Mon, May 16, 2022 at 2:48 PM Robert Marko <robert.marko@sartura.hr> wrote:
> >>> >>
> >>> >> Methode eDPU is an Armada 3720 powered board based on the Methode uDPU.
> >>> >>
> >>> >> They feature the same CPU, RAM, and storage as well as the form factor.
> >>> >>
> >>> >> However, eDPU only has one SFP slot plus a copper G.hn port.
> >>> >>
> >>> >> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> >>> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>> >> ---
> >>> >> Changes in v2:
> >>> >> * Make the DTS split a separate commit
> >>> >> ---
> >>> >>  arch/arm64/boot/dts/marvell/Makefile             |  1 +
> >>> >>  arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts | 14 ++++++++++++++
> >>> >>  2 files changed, 15 insertions(+)
> >>> >>  create mode 100644 arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
> >>> >>
> >>> >> diff --git a/arch/arm64/boot/dts/marvell/Makefile b/arch/arm64/boot/dts/marvell/Makefile
> >>> >> index 1c794cdcb8e6..104d7d7e8215 100644
> >>> >> --- a/arch/arm64/boot/dts/marvell/Makefile
> >>> >> +++ b/arch/arm64/boot/dts/marvell/Makefile
> >>> >> @@ -1,6 +1,7 @@
> >>> >>  # SPDX-License-Identifier: GPL-2.0
> >>> >>  # Mvebu SoC Family
> >>> >>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-db.dtb
> >>> >> +dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-eDPU.dtb
> >>> >>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin.dtb
> >>> >>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-emmc.dtb
> >>> >>  dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-ultra.dtb
> >>> >> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
> >>> >> new file mode 100644
> >>> >> index 000000000000..57fc698e55d0
> >>> >> --- /dev/null
> >>> >> +++ b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
> >>> >> @@ -0,0 +1,14 @@
> >>> >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> >>> >> +
> >>> >> +/dts-v1/;
> >>> >> +
> >>> >> +#include "armada-3720-uDPU.dtsi"
> >>> >> +
> >>> >> +/ {
> >>> >> +       model = "Methode eDPU Board";
> >>> >> +       compatible = "methode,edpu", "marvell,armada3720", "marvell,armada3710";
> >>> >> +};
> >>> >> +
> >>> >> +&eth0 {
> >>> >> +       phy-mode = "2500base-x";
> >>> >> +};
> >>> >> --
> >>> >> 2.36.1
> >>> >>
> >>> >
> >>> > Hi Gregory,
> >>> Hello Roberto,
> >>>
> >>> > Is there something else that I can improve in the series?
> >>>
> >>> Sorry for having missed this series. At first view it seems OK, I am
> >>> going to have a closer look this week.
> >>
> >> Thanks, that sounds good.
> >
> > Hello,
> >
> > could you send again patch 8, I managed to apply all the other ones
> > excepting this one.
>
> Finally I managed to sort it out, all the series is applied on mvebu/dt64

Thanks,
Regards
Robert
>
> Thanks,
>
> Gregory
> >
> >
> >>
> >> Regards,
> >> Robert
> >>>
> >>> Gregory
> >>>
> >>>
> >>> >
> >>> > Regards,
> >>> > Robert
> >>> >
> >>> > --
> >>> > Robert Marko
> >>> > Staff Embedded Linux Engineer
> >>> > Sartura Ltd.
> >>> > Lendavska ulica 16a
> >>> > 10000 Zagreb, Croatia
> >>> > Email: robert.marko@sartura.hr
> >>> > Web: www.sartura.hr
> >>>
> >>> --
> >>> Gregory Clement, Bootlin
> >>> Embedded Linux and Kernel engineering
> >>> http://bootlin.com
> >>
> >>
> >>
> >> --
> >> Robert Marko
> >> Staff Embedded Linux Engineer
> >> Sartura Ltd.
> >> Lendavska ulica 16a
> >> 10000 Zagreb, Croatia
> >> Email: robert.marko@sartura.hr
> >> Web: www.sartura.hr
> >
> > --
> > Gregory Clement, Bootlin
> > Embedded Linux and Kernel engineering
> > http://bootlin.com
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
> --
> Gregory Clement, Bootlin
> Embedded Linux and Kernel engineering
> http://bootlin.com



-- 
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@sartura.hr
Web: www.sartura.hr

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2022-09-02 17:26 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-16 12:48 [PATCH v4 01/10] dt-bindings: vendor-prefixes: add Methode Electronics Robert Marko
2022-05-16 12:48 ` [PATCH v4 02/10] dt-bindings: marvell: convert Armada 37xx compatibles to YAML Robert Marko
2022-05-16 12:48 ` [PATCH v4 03/10] arm64: dts: marvell: espressobin-ultra: add generic Espressobin compatible Robert Marko
2022-05-16 12:48 ` [PATCH v4 04/10] arm64: dts: marvell: uDPU: add missing SoC compatible Robert Marko
2022-05-16 12:48 ` [PATCH v4 05/10] arm64: dts: marvell: uDPU: align LED-s with bindings Robert Marko
2022-05-16 12:48 ` [PATCH v4 06/10] arm64: dts: marvell: uDPU: remove LED node pinctrl-names Robert Marko
2022-05-16 12:48 ` [PATCH v4 07/10] arm64: dts: marvell: rename temp sensor nodes Robert Marko
2022-05-16 12:48 ` [PATCH v4 08/10] arm64: dts: marvell: split Methode uDPU DTS Robert Marko
2022-05-16 12:48 ` [PATCH v4 09/10] dt-bindings: marvell: armada-37xx: add Methode eDPU compatible Robert Marko
2022-05-16 12:48 ` [PATCH v4 10/10] arm64: dts: marvell: add support for Methode eDPU Robert Marko
2022-08-08 11:42   ` Robert Marko
2022-08-30  7:42     ` Gregory CLEMENT
2022-08-31 11:12       ` Robert Marko
2022-09-02 15:22         ` Gregory CLEMENT
2022-09-02 16:13           ` Gregory CLEMENT
2022-09-02 17:26             ` Robert Marko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).