From: Dan Carpenter <dan.carpenter@oracle.com>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>, Qu Wenruo <wqu@suse.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: Fix an error handling path in btrfs_read_sys_array()
Date: Mon, 16 May 2022 16:54:07 +0300 [thread overview]
Message-ID: <20220516135407.GM4009@kadam> (raw)
In-Reply-To: <120e4c34-da48-7d86-4a50-c31a3804600d@gmx.com>
On Sun, May 15, 2022 at 06:57:25AM +0800, Qu Wenruo wrote:
>
>
> On 2022/5/14 20:01, Christophe JAILLET wrote:
> > If alloc_dummy_extent_buffer() we should return an error code, not 0 that
> > would mean success.
> >
> > Fixes: a1fc41ac28d3 ("btrfs: use dummy extent buffer for super block sys chunk array read")
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>
> Reviewed-by: Qu Wenruo <wqu@suse.com>
>
> All my fault, thanks for catching it.
> Qu
>
I sent this patch in January and David was going to fold it into the
original patch but it got lost. Thanks, Christophe!
regards,
dan carpenter
next prev parent reply other threads:[~2022-05-16 13:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-14 12:01 [PATCH] btrfs: Fix an error handling path in btrfs_read_sys_array() Christophe JAILLET
2022-05-14 22:57 ` Qu Wenruo
2022-05-16 13:54 ` Dan Carpenter [this message]
2022-05-16 15:01 ` David Sterba
2022-05-16 17:42 ` Christophe JAILLET
2022-05-17 5:55 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220516135407.GM4009@kadam \
--to=dan.carpenter@oracle.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).