From: Pratyush Yadav <p.yadav@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: <linux-spi@vger.kernel.org>, <linux-mtd@lists.infradead.org>,
<clg@kaod.org>, <andrew@aj.id.au>, <robh+dt@kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <richard@nod.at>,
<joel@jms.id.au>, <tudor.ambarus@microchip.com>,
<miquel.raynal@bootlin.com>, <chin-ting_kuo@aspeedtech.com>,
<linux-aspeed@lists.ozlabs.org>, <vigneshr@ti.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: (subset) [PATCH v7 00/11] spi: spi-mem: Convert Aspeed SMC driver to spi-mem
Date: Tue, 17 May 2022 16:35:09 +0530 [thread overview]
Message-ID: <20220517110509.2e6xbwot63yl6a3c@ti.com> (raw)
In-Reply-To: <165272636363.750911.14933122170662994904.b4-ty@kernel.org>
Hi Cedric,
On 16/05/22 07:39PM, Mark Brown wrote:
> On Mon, 9 May 2022 19:56:05 +0200, Cédric Le Goater wrote:
> > This series adds a new SPI driver using the spi-mem interface for the
> > Aspeed static memory controllers of the AST2600, AST2500 and AST2400
> > SoCs.
> >
> > * AST2600 Firmware SPI Memory Controller (FMC)
> > * AST2600 SPI Flash Controller (SPI1 and SPI2)
> > * AST2500 Firmware SPI Memory Controller (FMC)
> > * AST2500 SPI Flash Controller (SPI1 and SPI2)
> > * AST2400 New Static Memory Controller (also referred as FMC)
> > * AST2400 SPI Flash Controller (SPI)
> >
> > [...]
>
> Applied to
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
>
> Thanks!
>
> [02/11] dt-bindings: spi: Convert the Aspeed SMC controllers device tree binding
> commit: ce9858ea499da025684a7a5f19823c2c3f14bdce
> [03/11] spi: spi-mem: Convert Aspeed SMC driver to spi-mem
> commit: 9c63b846e6df43e5b3d31263f7db545f32deeda3
> [04/11] spi: aspeed: Add support for direct mapping
> commit: 9da06d7bdec7dad8018c23b180e410ef2e7a4367
> [05/11] spi: aspeed: Adjust direct mapping to device size
> commit: bb084f94e1bca4a5c4f689d7aa9b410220c1ed71
> [06/11] spi: aspeed: Workaround AST2500 limitations
> commit: 5785eedee42c34cfec496199a80fa8ec9ddcf7fe
> [07/11] spi: aspeed: Add support for the AST2400 SPI controller
> commit: 53526ab27d9c256504f267713aea60db7af18fb0
> [08/11] spi: aspeed: Calibrate read timings
> commit: eeaec1ea05c0e0f08e04c6844f20cc24a2fcc0f4
I have repeatedly objected to this patch [0][1][2] and you have
repeatedly decided to not address my objections. I won't spend any more
time fighting it. But I will say that you should not expect any
guarantees that SPI NOR or SPI NAND will not break your calibration in
the future if they decide to move the dirmap_create() call around.
> [11/11] mtd: spi-nor: aspeed: set the decoding size to at least 2MB for AST2600
> commit: 73ae97e3cabb580639f02f12a192324a53c4bebb
>
[0] https://patchwork.kernel.org/project/spi-devel-general/patch/20220325100849.2019209-9-clg@kaod.org/
[1] https://patchwork.kernel.org/project/spi-devel-general/patch/20220214094231.3753686-9-clg@kaod.org/
[2] https://lore.kernel.org/all/20220208190636.h6dubktkmuosvdxo@ti.com/
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
next prev parent reply other threads:[~2022-05-17 11:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 17:56 [PATCH v7 00/11] spi: spi-mem: Convert Aspeed SMC driver to spi-mem Cédric Le Goater
2022-05-09 17:56 ` [PATCH v7 01/11] ARM: dts: aspeed: Adjust "reg" property of FMC/SPI controllers Cédric Le Goater
2022-05-09 17:56 ` [PATCH v7 02/11] dt-bindings: spi: Convert the Aspeed SMC controllers device tree binding Cédric Le Goater
2022-05-09 17:56 ` [PATCH v7 03/11] spi: spi-mem: Convert Aspeed SMC driver to spi-mem Cédric Le Goater
2022-05-09 17:56 ` [PATCH v7 04/11] spi: aspeed: Add support for direct mapping Cédric Le Goater
2022-05-09 17:56 ` [PATCH v7 05/11] spi: aspeed: Adjust direct mapping to device size Cédric Le Goater
2022-05-09 17:56 ` [PATCH v7 06/11] spi: aspeed: Workaround AST2500 limitations Cédric Le Goater
2022-05-09 17:56 ` [PATCH v7 07/11] spi: aspeed: Add support for the AST2400 SPI controller Cédric Le Goater
2022-05-09 17:56 ` [PATCH v7 08/11] spi: aspeed: Calibrate read timings Cédric Le Goater
2022-05-09 17:56 ` [PATCH v7 09/11] ARM: dts: aspeed: Enable Dual SPI RX transfers Cédric Le Goater
2022-05-09 17:56 ` [PATCH v7 10/11] ARM: dts: aspeed-g4: Set spi-max-frequency for all flashes Cédric Le Goater
2022-05-09 17:56 ` [PATCH v7 11/11] mtd: spi-nor: aspeed: set the decoding size to at least 2MB for AST2600 Cédric Le Goater
2022-05-16 18:39 ` (subset) [PATCH v7 00/11] spi: spi-mem: Convert Aspeed SMC driver to spi-mem Mark Brown
2022-05-17 11:05 ` Pratyush Yadav [this message]
2022-05-17 12:03 ` Cédric Le Goater
2022-05-17 12:33 ` Pratyush Yadav
2022-05-17 12:37 ` Miquel Raynal
2022-05-17 13:41 ` Cédric Le Goater
2022-05-17 12:10 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517110509.2e6xbwot63yl6a3c@ti.com \
--to=p.yadav@ti.com \
--cc=andrew@aj.id.au \
--cc=broonie@kernel.org \
--cc=chin-ting_kuo@aspeedtech.com \
--cc=clg@kaod.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).