From: Jason Wang <jasowang@redhat.com>
To: mst@redhat.com, jasowang@redhat.com,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, peterz@infradead.org, paulmck@kernel.org,
maz@kernel.org, pasic@linux.ibm.com, cohuck@redhat.com,
eperezma@redhat.com, lulu@redhat.com, sgarzare@redhat.com,
xuanzhuo@linux.alibaba.com
Subject: [PATCH V5 0/9] rework on the IRQ hardening of virtio
Date: Wed, 18 May 2022 11:59:42 +0800 [thread overview]
Message-ID: <20220518035951.94220-1-jasowang@redhat.com> (raw)
Hi All:
This is a rework on the IRQ hardening for virtio which is done
previously by the following commits are reverted:
9e35276a5344 ("virtio_pci: harden MSI-X interrupts")
080cd7c3ac87 ("virtio-pci: harden INTX interrupts")
The reason is that it depends on the IRQF_NO_AUTOEN which may conflict
with the assumption of the affinity managed IRQ that is used by some
virtio drivers. And what's more, it is only done for virtio-pci but
not other transports.
In this rework, I try to implement a general virtio solution which
borrows the idea of the INTX hardening by re-using per virtqueue
boolean vq->broken and toggle it in virtio_device_ready() and
virtio_reset_device(). Then we can simply reuse the existing checks in
the vring_interrupt() and return early if the driver is not ready.
Note that, I only did compile test on ccw and MMIO transport.
Please review.
Changes since V4:
- use spin_lock_irq()/spin_unlock_irq() to synchronize with
vring_interrupt() for ccw
- use spin_lock()/spin_unlock() to protect vring_interrupt() for non
airq
- add comment to explain the ordering implications of set_status() for
PCI, ccw and MMIO
- various tweaks on the comments and changelogs
Changes since V3:
- Rename synchornize_vqs() to synchronize_cbs()
- tweak the comment for synchronize_cbs()
- switch to use a dedicated helper __virtio_unbreak_device() and
document it should be only used for probing
- switch to use rwlock to synchornize the non airq for ccw
Changes since V2:
- add ccw and MMIO support
- rename synchronize_vqs() to synchronize_cbs()
- switch to re-use vq->broken instead of introducing new device
attributes for the future virtqueue reset support
- remove unnecssary READ_ONCE()/WRITE_ONCE()
- a new patch to remove device triggerable BUG_ON()
- more tweaks on the comments
Changes since v1:
- Use transport specific irq synchronization method when possible
- Drop the module parameter and enable the hardening unconditonally
- Tweak the barrier/ordering facilities used in the code
- Reanme irq_soft_enabled to driver_ready
- Avoid unnecssary IRQ synchornization (e.g during boot)
Jason Wang (8):
virtio: use virtio_reset_device() when possible
virtio: introduce config op to synchronize vring callbacks
virtio-pci: implement synchronize_cbs()
virtio-mmio: implement synchronize_cbs()
virtio-ccw: implement synchronize_cbs()
virtio: allow to unbreak virtqueue
virtio: harden vring IRQ
virtio: use WARN_ON() to warning illegal status value
Stefano Garzarella (1):
virtio: use virtio_device_ready() in virtio_device_restore()
drivers/s390/virtio/virtio_ccw.c | 31 +++++++++++++++++
drivers/virtio/virtio.c | 24 +++++++++----
drivers/virtio/virtio_mmio.c | 14 ++++++++
drivers/virtio/virtio_pci_legacy.c | 1 +
drivers/virtio/virtio_pci_modern.c | 2 ++
drivers/virtio/virtio_pci_modern_dev.c | 5 +++
drivers/virtio/virtio_ring.c | 32 +++++++++++++++---
include/linux/virtio.h | 1 +
include/linux/virtio_config.h | 47 +++++++++++++++++++++++++-
9 files changed, 145 insertions(+), 12 deletions(-)
--
2.25.1
next reply other threads:[~2022-05-18 4:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 3:59 Jason Wang [this message]
2022-05-18 3:59 ` [PATCH V5 1/9] virtio: use virtio_device_ready() in virtio_device_restore() Jason Wang
2022-05-18 3:59 ` [PATCH V5 2/9] virtio: use virtio_reset_device() when possible Jason Wang
2022-05-19 8:32 ` Stefano Garzarella
2022-05-18 3:59 ` [PATCH V5 3/9] virtio: introduce config op to synchronize vring callbacks Jason Wang
2022-05-19 8:34 ` Stefano Garzarella
2022-05-18 3:59 ` [PATCH V5 4/9] virtio-pci: implement synchronize_cbs() Jason Wang
2022-05-18 3:59 ` [PATCH V5 5/9] virtio-mmio: " Jason Wang
2022-05-18 3:59 ` [PATCH V5 6/9] virtio-ccw: " Jason Wang
2022-05-18 9:32 ` Cornelia Huck
2022-05-19 8:02 ` Jason Wang
2022-05-24 16:29 ` Halil Pasic
2022-05-18 3:59 ` [PATCH V5 7/9] virtio: allow to unbreak virtqueue Jason Wang
2022-05-18 10:03 ` Cornelia Huck
2022-05-19 8:08 ` Jason Wang
2022-05-18 3:59 ` [PATCH V5 8/9] virtio: harden vring IRQ Jason Wang
2022-05-18 3:59 ` [PATCH V5 9/9] virtio: use WARN_ON() to warn illegal status value Jason Wang
2022-05-19 8:34 ` Stefano Garzarella
2022-05-23 8:53 ` [PATCH V5 0/9] rework on the IRQ hardening of virtio Halil Pasic
2022-05-24 16:27 ` Halil Pasic
2022-05-25 2:33 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220518035951.94220-1-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=cohuck@redhat.com \
--cc=eperezma@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=maz@kernel.org \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=sgarzare@redhat.com \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).