From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B6E4C4332F for ; Wed, 18 May 2022 18:53:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241678AbiERSxR (ORCPT ); Wed, 18 May 2022 14:53:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241708AbiERSxO (ORCPT ); Wed, 18 May 2022 14:53:14 -0400 Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE6D020EE20; Wed, 18 May 2022 11:53:10 -0700 (PDT) Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-e5e433d66dso3914370fac.5; Wed, 18 May 2022 11:53:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=8MjJCE/8K8+TV18DiRjp4WnXk9vy6w8u4Ub+xfkaiUo=; b=NWb6Q3Xp8TjvfEuECfIQr9df1jw+ayPwuRvx0niNBQuVXPSTM+UUV9YoaOuxuK70MH C2pCHplp1VP4eV5d0Pkihl3CYLiitDTRasrd+7p/pYXn+DV89pSXfMOKLllydTfH8NeF 7mRQub4QFL+L6RR4mfEjJhA+SRKn9X+zHqtPYelTGz0gstgzPRNP5StkaljSpjCOS0Lq hJKA51WujP9e9c8K4GzLG7mBFm8hsli0kcmWSUjyNZAzQ3EkU7kVgoHwjV+IDP5DcEMe T09kJRO94G5ogh7TMRGPX24aDGQmFNkOZzkFi+Iia2gp6lr3twPg9GB3BZ6KSMNxpOxg m7oQ== X-Gm-Message-State: AOAM531rZ1Jh8K+slVqKDs6Wjlg0WgEukSX7nEhxc664egcU3G5Gj/5J piGvk4IjSs5kLkyCKqhEbA== X-Google-Smtp-Source: ABdhPJw+P/6QyDD9F7P5YoNd1qUPUMDZ8vwFg4Y7o7BJFW/d3h8QUhanxfXSfGfLfywzFxVJbjIodA== X-Received: by 2002:a05:6870:f61a:b0:f1:7484:8eca with SMTP id ek26-20020a056870f61a00b000f174848ecamr546312oab.107.1652899989566; Wed, 18 May 2022 11:53:09 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id a9-20020a056870618900b000edda81f868sm1267659oah.10.2022.05.18.11.53.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 11:53:08 -0700 (PDT) Received: (nullmailer pid 3685342 invoked by uid 1000); Wed, 18 May 2022 18:53:07 -0000 Date: Wed, 18 May 2022 13:53:07 -0500 From: Rob Herring To: =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= Cc: Vladimir Oltean , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Geert Uytterhoeven , Magnus Damm , Heiner Kallweit , Russell King , Thomas Petazzoni , Herve Codina , =?iso-8859-1?Q?Miqu=E8l?= Raynal , Milan Stevanovic , Jimmy Lalande , Pascal Eberhard , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next v4 05/12] dt-bindings: net: dsa: add bindings for Renesas RZ/N1 Advanced 5 port switch Message-ID: <20220518185307.GL3302100-robh@kernel.org> References: <20220509131900.7840-1-clement.leger@bootlin.com> <20220509131900.7840-6-clement.leger@bootlin.com> <20220511152221.GA334055-robh@kernel.org> <20220511153337.deqxawpbbk3actxf@skbuf> <20220518015924.GC2049643-robh@kernel.org> <20220518120503.3m2zfw7kmhsfg336@skbuf> <20220518144111.135c7d0d@fixe.home> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220518144111.135c7d0d@fixe.home> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 18, 2022 at 02:41:11PM +0200, Clément Léger wrote: > Le Wed, 18 May 2022 15:05:03 +0300, > Vladimir Oltean a écrit : > > > On Tue, May 17, 2022 at 08:59:24PM -0500, Rob Herring wrote: > > > On Wed, May 11, 2022 at 06:33:37PM +0300, Vladimir Oltean wrote: > > > > On Wed, May 11, 2022 at 10:22:21AM -0500, Rob Herring wrote: > > > > > > +patternProperties: > > > > > > + "^ethernet-ports$": > > > > > > > > > > Move to 'properties', not a pattern. > > > > > > > > > > With that, > > > > > > > > > > Reviewed-by: Rob Herring > > > > > > > > Even if it should have been "^(ethernet-)?ports$"? > > > > > > Why? Allowing 'ports' is for existing users. New ones don't need the > > > variability and should use just 'ethernet-ports'. > > > > > > Rob > > > > Yeah, ok, somehow the memo that new DSA drivers shouldn't support "ports" > > didn't reach me. They invariably will though, since the DSA framework is > > the main parser of the property, and that is shared by both old and new > > drivers. > > Should also the subnodes of "ethernet-ports" use the > "ethernet-port@[0-9]*" naming ? Or keeping the existing pattern is ok > (ie "^(ethernet-)?port@[0-4]$") ? I prefer the former, but care less. The whole reason for 'ethernet-' prefix is to make this distinct from the graph binding that uses ports and port. Rob