From: Andrew Morton <akpm@linux-foundation.org>
To: kernel test robot <lkp@intel.com>
Cc: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Eric Biederman <ebiederm@xmission.com>,
kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
kexec@lists.infradead.org
Subject: Re: [PATCH v2] kexec_file: Drop weak attribute from arch_kexec_apply_relocations[_add]
Date: Thu, 19 May 2022 10:29:48 -0700 [thread overview]
Message-ID: <20220519102948.f5c990db0e5f9cfb35c2a68f@linux-foundation.org> (raw)
In-Reply-To: <202205192320.CoXevcfR-lkp@intel.com>
On Thu, 19 May 2022 23:17:48 +0800 kernel test robot <lkp@intel.com> wrote:
> Hi "Naveen,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on f993aed406eaf968ba3867a76bb46c95336a33d0]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Naveen-N-Rao/kexec_file-Drop-weak-attribute-from-arch_kexec_apply_relocations-_add/20220519-171432
> base: f993aed406eaf968ba3867a76bb46c95336a33d0
> config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20220519/202205192320.CoXevcfR-lkp@intel.com/config)
> compiler: s390-linux-gcc (GCC) 11.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/intel-lab-lkp/linux/commit/67171688c71cb5b05f26e0dfc45eec8d8d1428ff
> git remote add linux-review https://github.com/intel-lab-lkp/linux
> git fetch --no-tags linux-review Naveen-N-Rao/kexec_file-Drop-weak-attribute-from-arch_kexec_apply_relocations-_add/20220519-171432
> git checkout 67171688c71cb5b05f26e0dfc45eec8d8d1428ff
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash arch/s390/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> In file included from arch/s390/kernel/machine_kexec_reloc.c:3:
> >> arch/s390/include/asm/kexec.h:89:38: error: unknown type name 'Elf_Shdr'; did you mean 'elf_shdr'?
> 89 | Elf_Shdr *section,
> | ^~~~~~~~
> | elf_shdr
> arch/s390/include/asm/kexec.h:90:44: error: unknown type name 'Elf_Shdr'
> 90 | const Elf_Shdr *relsec,
> | ^~~~~~~~
> arch/s390/include/asm/kexec.h:91:44: error: unknown type name 'Elf_Shdr'
> 91 | const Elf_Shdr *symtab);
> | ^~~~~~~~
Thanks, I did this:
--- a/arch/s390/include/asm/kexec.h~kexec_file-drop-weak-attribute-from-arch_kexec_apply_relocations-fix
+++ a/arch/s390/include/asm/kexec.h
@@ -9,6 +9,8 @@
#ifndef _S390_KEXEC_H
#define _S390_KEXEC_H
+#include <linux/module.h>
+
#include <asm/processor.h>
#include <asm/page.h>
#include <asm/setup.h>
_
next prev parent reply other threads:[~2022-05-19 17:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 9:12 [PATCH v2] kexec_file: Drop weak attribute from arch_kexec_apply_relocations[_add] Naveen N. Rao
2022-05-19 15:17 ` kernel test robot
2022-05-19 17:29 ` Andrew Morton [this message]
2022-05-29 6:56 ` Uwe Kleine-König
2022-05-29 9:46 ` Christophe Leroy
2022-05-29 14:06 ` Uwe Kleine-König
2022-05-30 1:43 ` liaochang (A)
2022-05-30 7:42 ` [PATCH] RISC-V: Prepare dropping week " Uwe Kleine-König
2022-05-30 18:58 ` Palmer Dabbelt
2022-05-30 19:41 ` Uwe Kleine-König
2022-05-30 23:11 ` Palmer Dabbelt
2022-05-31 5:58 ` Uwe Kleine-König
2022-05-31 15:45 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220519102948.f5c990db0e5f9cfb35c2a68f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=kbuild-all@lists.01.org \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).