From: Stafford Horne <shorne@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Openrisc <openrisc@lists.librecores.org>,
Stafford Horne <shorne@gmail.com>,
Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Randy Dunlap <rdunlap@infradead.org>,
Qi Zheng <zhengqi.arch@bytedance.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: [PATCH v3 12/13] openrisc/fault: Fix symbol scope warnings
Date: Sat, 21 May 2022 22:13:22 +0900 [thread overview]
Message-ID: <20220521131323.631209-13-shorne@gmail.com> (raw)
In-Reply-To: <20220521131323.631209-1-shorne@gmail.com>
Sparse reported the following warning:
arch/openrisc/mm/fault.c:27:15: warning: symbol 'pte_misses' was not declared. Should it be static?
arch/openrisc/mm/fault.c:28:15: warning: symbol 'pte_errors' was not declared. Should it be static?
arch/openrisc/mm/fault.c:33:16: warning: symbol 'current_pgd' was not declared. Should it be static?
This patch fixes these by:
- Remove unused pte_misses and pte_errors counters which are no longer
used.
- Add asm/mmu_context.h include to provide the current_pgd declaration.
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
arch/openrisc/mm/fault.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/openrisc/mm/fault.c b/arch/openrisc/mm/fault.c
index 80bb66ad42f6..516cba14dec9 100644
--- a/arch/openrisc/mm/fault.c
+++ b/arch/openrisc/mm/fault.c
@@ -18,15 +18,13 @@
#include <linux/perf_event.h>
#include <linux/uaccess.h>
+#include <asm/mmu_context.h>
#include <asm/siginfo.h>
#include <asm/signal.h>
#define NUM_TLB_ENTRIES 64
#define TLB_OFFSET(add) (((add) >> PAGE_SHIFT) & (NUM_TLB_ENTRIES-1))
-unsigned long pte_misses; /* updated by do_page_fault() */
-unsigned long pte_errors; /* updated by do_page_fault() */
-
/* __PHX__ :: - check the vmalloc_fault in do_page_fault()
* - also look into include/asm/mmu_context.h
*/
--
2.31.1
next prev parent reply other threads:[~2022-05-21 13:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-21 13:13 [PATCH v3 00/13] OpenRISC misc cleanups for 5.19 Stafford Horne
2022-05-21 13:13 ` [PATCH v3 01/13] openrisc: Add gcc machine instruction flag configuration Stafford Horne
2022-05-21 13:13 ` [PATCH v3 02/13] openrisc: Cleanup emergency print handling Stafford Horne
2022-05-21 13:13 ` [PATCH v3 03/13] openrisc: Add support for liteuart emergency printing Stafford Horne
2022-05-21 13:13 ` [PATCH v3 04/13] openrisc: Add syscall details to emergency syscall debugging Stafford Horne
2022-05-21 13:13 ` [PATCH v3 05/13] openrisc: Pretty print show_registers memory dumps Stafford Horne
2022-05-21 13:13 ` [PATCH v3 06/13] openrisc: Update litex defconfig to support glibc userland Stafford Horne
2022-05-21 13:13 ` [PATCH v3 07/13] openrisc/traps: Declare file scope symbols as static Stafford Horne
2022-05-21 13:13 ` [PATCH v3 08/13] openrisc/traps: Remove die_if_kernel function Stafford Horne
2022-05-21 13:13 ` [PATCH v3 09/13] openrisc/traps: Declare unhandled_exception for asmlinkage Stafford Horne
2022-05-21 13:13 ` [PATCH v3 10/13] openrisc/time: Fix symbol scope warnings Stafford Horne
2022-05-21 13:13 ` [PATCH v3 11/13] openrisc/delay: Add include to fix symbol not declared warning Stafford Horne
2022-05-21 13:13 ` Stafford Horne [this message]
2022-05-21 13:13 ` [PATCH v3 13/13] openrisc: Remove unused IMMU tlb workardound Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220521131323.631209-13-shorne@gmail.com \
--to=shorne@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=jonas@southpole.se \
--cc=linux-kernel@vger.kernel.org \
--cc=openrisc@lists.librecores.org \
--cc=rdunlap@infradead.org \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).