From: Sudeep Holla <sudeep.holla@arm.com>
To: cgel.zte@gmail.com
Cc: cristian.marussi@arm.com, linux-arm-kernel@lists.infradead.org,
Sudeep Holla <sudeep.holla@arm.com>,
linux-kernel@vger.kernel.org,
Minghao Chi <chi.minghao@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] firmware: arm_scmi: Avoid leak OF node on error
Date: Mon, 23 May 2022 14:27:28 +0100 [thread overview]
Message-ID: <20220523132728.lfk6mskynqk636m4@bogus> (raw)
In-Reply-To: <20220523111116.2898-1-chi.minghao@zte.com.cn>
On Mon, May 23, 2022 at 11:11:16AM +0000, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> The OF node should be put before returning error in smc_chan_available(),
> otherwise node's refcount will be leaked.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
> drivers/firmware/arm_scmi/smc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/arm_scmi/smc.c b/drivers/firmware/arm_scmi/smc.c
> index 745acfdd0b3d..43018be70edc 100644
> --- a/drivers/firmware/arm_scmi/smc.c
> +++ b/drivers/firmware/arm_scmi/smc.c
> @@ -55,10 +55,10 @@ static irqreturn_t smc_msg_done_isr(int irq, void *data)
> static bool smc_chan_available(struct device *dev, int idx)
> {
> struct device_node *np = of_parse_phandle(dev->of_node, "shmem", 0);
> + of_node_put(np);
While this may work as of_node_put handles NULL as argument, what is the
point of unnecessary of_node_put(NULL) here ?
--
Regards,
Sudeep
prev parent reply other threads:[~2022-05-23 13:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 11:11 [PATCH] firmware: arm_scmi: Avoid leak OF node on error cgel.zte
2022-05-23 11:53 ` Johan Hovold
2022-05-23 13:27 ` Sudeep Holla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220523132728.lfk6mskynqk636m4@bogus \
--to=sudeep.holla@arm.com \
--cc=cgel.zte@gmail.com \
--cc=chi.minghao@zte.com.cn \
--cc=cristian.marussi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).