From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E305C433FE for ; Mon, 23 May 2022 16:41:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239000AbiEWQlT (ORCPT ); Mon, 23 May 2022 12:41:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238979AbiEWQlQ (ORCPT ); Mon, 23 May 2022 12:41:16 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E0111834B for ; Mon, 23 May 2022 09:41:13 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id jx22so16578492ejb.12 for ; Mon, 23 May 2022 09:41:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=iUGGPEpEBvIWHgX5WmkSro+WwIlgJC8zd/HjCtR8Q4c=; b=H3XfY74DTshOhN9sVQxtYdLk3vb8+vVSWvfYXd8FmbjGu9PKT5P9hkqc6GDpTJRtpR AuayBey8pE3g+5B7/74w0rcBqxGaBNlDcXcJBD7UAoKASVPM1/xojk5Etdm4dJ38uEFH YH4Td6rXuPGroFATKKmQeZ9qdGzAiPNVCchLQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iUGGPEpEBvIWHgX5WmkSro+WwIlgJC8zd/HjCtR8Q4c=; b=MawiUgUiJE0TQaqaGHYCxQcmh/j93+oUfwFghOaB7EwWso2ltww4rtD9KlkfxPfS1l dckKAIBwbhg660bxoNiEjNku/+askOCNSRXHyHUUQYNMDYUWm/sDmw5ALtUq6eWZXyHU QIlzG5ivlFUxlGt8H0C+fyZJLRoJ7YOt4r2g/ZzFN0IlUSa2zhJS4S+qxqk/ueungamN bNyZdJlrat7UrOA4ZObYOW76o/1Cxw5N4G+DY96YbR6K374Q0N7WI6w9FpjoVK8ox8u2 6pUyUfUCk3Zq131SEhu8IgUg87oZ/ML/+Kh4FVi/egpsxzjxKq4sL/UBSDoqo2HtNied 7/rQ== X-Gm-Message-State: AOAM533qH3rXlOxB/40u0m9yG0/HB27pXgA3DnZ9oI+a1r/Ah55IIN44 Z4nSbIZHiWsQ2WNS0StQCzjkZwWNAItWRA== X-Google-Smtp-Source: ABdhPJzUjwcf7OH53MGed2OB9aRdAWP195mx3cAjRfMxFGJesJ5BWL2DFnSYtmnPrZrVXDQiO+tRdA== X-Received: by 2002:a17:907:3da1:b0:6fe:ae46:997d with SMTP id he33-20020a1709073da100b006feae46997dmr13878511ejc.633.1653324071808; Mon, 23 May 2022 09:41:11 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i (net-188-217-53-154.cust.vodafonedsl.it. [188.217.53.154]) by smtp.gmail.com with ESMTPSA id d23-20020a50fe97000000b0042ac2b71078sm8380787edt.55.2022.05.23.09.41.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 09:41:11 -0700 (PDT) Date: Mon, 23 May 2022 18:41:08 +0200 From: Tommaso Merciai To: Andrew Lunn Cc: michael@amarulasolutions.com, alberto.bianchi@amarulasolutions.com, linux-amarula@amarulasolutions.com, linuxfancy@googlegroups.com, Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] net: phy: DP83822: enable rgmii mode if phy_interface_is_rgmii Message-ID: <20220523164108.GA3635492@tom-ThinkPad-T14s-Gen-2i> References: <20220520235846.1919954-1-tommaso.merciai@amarulasolutions.com> <20220523065754.GJ1589864@tom-ThinkPad-T14s-Gen-2i> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 23, 2022 at 02:16:56PM +0200, Andrew Lunn wrote: > On Mon, May 23, 2022 at 08:57:54AM +0200, Tommaso Merciai wrote: > > On Sat, May 21, 2022 at 08:39:02PM +0200, Andrew Lunn wrote: > > > On Sat, May 21, 2022 at 01:58:46AM +0200, Tommaso Merciai wrote: > > > > RGMII mode can be enable from dp83822 straps, and also writing bit 9 > > > > of register 0x17 - RMII and Status Register (RCSR). > > > > When phy_interface_is_rgmii rgmii mode must be enabled, same for > > > > contrary, this prevents malconfigurations of hw straps > > > > > > > > References: > > > > - https://www.ti.com/lit/gpn/dp83822i p66 > > > > > > > > Signed-off-by: Tommaso Merciai > > > > Co-developed-by: Michael Trimarchi > > > > Suggested-by: Alberto Bianchi > > > > Tested-by: Tommaso Merciai > > > > > > Reviewed-by: Andrew Lunn > > > > > > If you want to, you could go further. If bit 9 is clear, bit 5 defines > > > the mode, either RMII or MII. There are interface modes defined for > > > these, so you could get bit 5 as well. > > > > Hi Andrew, > > Thanks for the review and for your time. > > I'll try to go further, like you suggest :) > > Hi Tomaso > > This patch has been accepted, so you will need to submit an > incremental patch. I also expect net-next to close soon for the merge > window, so you might want to wait two weeks before submitting. > > Andrew Hi Andrew, Thanks for the info. I'll wait for the close of the merge window then. Regards, Tommaso -- Tommaso Merciai Embedded Linux Engineer tommaso.merciai@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com