linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Paul E. McKenney" <paulmck@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Kernel Team <kernel-team@fb.com>
Subject: Re: [GIT PULL] nolibc changes for v5.19
Date: Mon, 23 May 2022 21:56:05 +0200	[thread overview]
Message-ID: <20220523195605.GA13032@1wt.eu> (raw)
In-Reply-To: <CAHk-=wgpAHhPVSqBWb4gYT=CRJzKAZ4inmrL_kcpeNWGkcg3pg@mail.gmail.com>

Hi Linus,

On Mon, May 23, 2022 at 11:42:48AM -0700, Linus Torvalds wrote:
> On Fri, May 20, 2022 at 11:24 AM Paul E. McKenney <paulmck@kernel.org> wrote:
> >
> > This pull request adds a number of library functions and splits this
> > library into multiple files.
> 
> Well, this is annoying.
> 
> You add the rule to test and install this, and "make help" will list
> "nolibc" as a target, but that is not actually true at all.
> 
> So what's the appropriate way to actually test this pull somehow?
> 
> I'm guessing it's along the lines of
> 
>     make ARCH=x86 nolibc_headers
> 
> in the tools directory, but then I got bored and decided I need to
> just continue the merge window.
> 
> I've pulled this, but it all makes me go "Hmm, I'd have liked to maybe
> even build test it".

I did. I must confess I'm embarrassed now because when I added the
entries there, exactly in order to reuse what was in place, I found
it a bit tricky to launch the tests, but after that I felt OK with
it. Now it's been a quite some time now and I don't remember the exact
way to trigger the tests there, so it's likely that I didn't leave
enough info in the commit messages :-( Let me have a look and figure
again how to start the tests.

Sorry about that,
Willy

  reply	other threads:[~2022-05-23 19:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-20 18:24 [GIT PULL] nolibc changes for v5.19 Paul E. McKenney
2022-05-23 18:42 ` Linus Torvalds
2022-05-23 19:56   ` Willy Tarreau [this message]
2022-05-23 20:23     ` Willy Tarreau
2022-05-23 20:30       ` Linus Torvalds
2022-05-23 20:50         ` Willy Tarreau
2022-05-23 21:04           ` Willy Tarreau
2022-05-23 21:13             ` Linus Torvalds
2022-05-23 22:01               ` Willy Tarreau
2022-05-23 19:20 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220523195605.GA13032@1wt.eu \
    --to=w@1wt.eu \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).