From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08D3EC433EF for ; Mon, 23 May 2022 22:01:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230484AbiEWWBQ (ORCPT ); Mon, 23 May 2022 18:01:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230444AbiEWWBN (ORCPT ); Mon, 23 May 2022 18:01:13 -0400 Received: from relay02.th.seeweb.it (relay02.th.seeweb.it [5.144.164.163]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58D946170 for ; Mon, 23 May 2022 15:01:10 -0700 (PDT) Received: from SoMainline.org (94-209-165-62.cable.dynamic.v4.ziggo.nl [94.209.165.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id 0F6FC2013A; Tue, 24 May 2022 00:01:09 +0200 (CEST) Date: Tue, 24 May 2022 00:01:07 +0200 From: Marijn Suijten To: Pavel Machek Cc: Bjorn Andersson , Richard Purdie , Jacek Anaszewski , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, linux-arm-msm@vger.kernel.org, Rob Herring , Mark Rutland , devicetree@vger.kernel.org Subject: Re: [PATCH 1/2] leds: Add driver for Qualcomm LPG Message-ID: <20220523220107.6wmpp2ohw63p4mjh@SoMainline.org> References: <20170323055435.29197-1-bjorn.andersson@linaro.org> <20220523163038.GA9124@duo.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220523163038.GA9124@duo.ucw.cz> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-05-23 18:30:38, Pavel Machek wrote: > Hi! > > > The Light Pulse Generator (LPG) is a PWM-block found in a wide range of > > PMICs from Qualcomm. It can operate on fixed parameters or based on a > > lookup-table, altering the duty cycle over time - which provides the > > means for e.g. hardware assisted transitions of LED brightness. > > > > Signed-off-by: Bjorn Andersson > > I'd really like to see the patch fixing the pattern interface (or > disabling it). I don't want to push the tree to Linus with that bug. (I couldn't help but be confused for a minute by this being a reply to the original v1 patchset from March 2017 :) ) Does that mean there's still some time to review / pick up [1] (LPG enablement for PM660L)? And even more so for [2] (fixing the use of a software-pattern variable in the hardware-pattern code) which complements Bjorn's series but hasn't been looked at ever since last year. I wouldn't mind picking up this issue (discussed in the v14 series at [3]) and unblock you sending the tree to Linus without reverting, if Bjorn doesn't have the bandwidth for it currently. But I will need confirmation that patches sent in my name actually get looked at... Thanks! - Marijn [1]: https://lore.kernel.org/linux-leds/20220511190718.764445-1-marijn.suijten@somainline.org/ [2]: https://lore.kernel.org/linux-leds/20210915080252.69147-1-marijn.suijten@somainline.org/ [3]: https://lore.kernel.org/linux-leds/YnvhleAI5RW0ZvkV@ripper/T/#m6cb0d8df051bbcd3772d068640ccd784678ad47b