On Tue 2022-05-24 00:01:07, Marijn Suijten wrote: > On 2022-05-23 18:30:38, Pavel Machek wrote: > > Hi! > > > > > The Light Pulse Generator (LPG) is a PWM-block found in a wide range of > > > PMICs from Qualcomm. It can operate on fixed parameters or based on a > > > lookup-table, altering the duty cycle over time - which provides the > > > means for e.g. hardware assisted transitions of LED brightness. > > > > > > Signed-off-by: Bjorn Andersson > > > > I'd really like to see the patch fixing the pattern interface (or > > disabling it). I don't want to push the tree to Linus with that bug. > > (I couldn't help but be confused for a minute by this being a reply to > the original v1 patchset from March 2017 :) ) > > Does that mean there's still some time to review / pick up [1] > (LPG enablement for PM660L)? And even more so for [2] (fixing the use > of a software-pattern variable in the hardware-pattern code) which > complements Bjorn's series but hasn't been looked at ever since last > year. There's still time if the patches are perfect. Pavel -- People of Russia, stop Putin before his war on Ukraine escalates.