From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH] rethook: Reject getting a rethook if RCU is not watching
Date: Thu, 26 May 2022 23:25:30 +0900 [thread overview]
Message-ID: <20220526232530.cb7d0aed0c60625ef093a735@kernel.org> (raw)
In-Reply-To: <20220524192301.0c2ab08a@gandalf.local.home>
On Tue, 24 May 2022 19:23:01 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Sat, 7 May 2022 13:46:52 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> Is this expected to go through the BPF tree?
>
Yes, since rethook (fprobe) is currently used only from eBPF.
Jiri, can you check this is good for your test case?
Thank you,
> -- Steve
>
>
> > Since the rethook_recycle() will involve the call_rcu() for reclaiming
> > the rethook_instance, the rethook must be set up at the RCU available
> > context (non idle). This rethook_recycle() in the rethook trampoline
> > handler is inevitable, thus the RCU available check must be done before
> > setting the rethook trampoline.
> >
> > This adds a rcu_is_watching() check in the rethook_try_get() so that
> > it will return NULL if it is called when !rcu_is_watching().
> >
> > Fixes: 54ecbe6f1ed5 ("rethook: Add a generic return hook")
> > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> > ---
> > kernel/trace/rethook.c | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/kernel/trace/rethook.c b/kernel/trace/rethook.c
> > index b56833700d23..c69d82273ce7 100644
> > --- a/kernel/trace/rethook.c
> > +++ b/kernel/trace/rethook.c
> > @@ -154,6 +154,15 @@ struct rethook_node *rethook_try_get(struct rethook *rh)
> > if (unlikely(!handler))
> > return NULL;
> >
> > + /*
> > + * This expects the caller will set up a rethook on a function entry.
> > + * When the function returns, the rethook will eventually be reclaimed
> > + * or released in the rethook_recycle() with call_rcu().
> > + * This means the caller must be run in the RCU-availabe context.
> > + */
> > + if (unlikely(!rcu_is_watching()))
> > + return NULL;
> > +
> > fn = freelist_try_get(&rh->pool);
> > if (!fn)
> > return NULL;
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2022-05-26 14:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-07 4:46 [PATCH] rethook: Reject getting a rethook if RCU is not watching Masami Hiramatsu
2022-05-24 23:23 ` Steven Rostedt
2022-05-26 14:25 ` Masami Hiramatsu [this message]
2022-05-26 14:49 ` Jiri Olsa
2022-05-26 16:14 ` Masami Hiramatsu
2022-05-27 22:10 ` Jiri Olsa
2022-05-28 1:19 ` Masami Hiramatsu
2022-06-03 19:21 ` Andrii Nakryiko
2022-06-06 16:02 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220526232530.cb7d0aed0c60625ef093a735@kernel.org \
--to=mhiramat@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).