From: "Michal Koutný" <mkoutny@suse.com>
To: Tadeusz Struk <tadeusz.struk@linaro.org>
Cc: Tejun Heo <tj@kernel.org>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Bui Quang Minh <minhquangbui99@gmail.com>
Subject: Re: [PATCH 2/2] cgroup: Use separate work structs on css release path
Date: Fri, 27 May 2022 18:54:29 +0200 [thread overview]
Message-ID: <20220527165429.GJ11007@blackbody.suse.cz> (raw)
In-Reply-To: <904ef8af-13a5-e566-b760-74519f70fa62@linaro.org>
Hello Tadeusz.
On Fri, May 27, 2022 at 09:39:20AM -0700, Tadeusz Struk <tadeusz.struk@linaro.org> wrote:
> As far as I can see we are trying to test the same thing suggested by Tejun.
> I just sent a test request to try this:
> https://github.com/tstruk/linux/commit/master
Yup, I've added few more prints to get more fine-grained resolution.
Also, I decided to use ftrace printk not to interfere with timing too
much (due to the original race hypothesis).
> Let me know if you have any more tests to run and I will hold off until
> you are done.
My latest attempt is [1] (tip 5500e05d82fd5b5db2203eedb3f786857d3ccbea).
So far, I'm not convinced, I extract the complete ftrace buffer from the
syzbot runs, so I'm not drawing any conclusions from the traces I've
got. I'm not going to continue today. You may have more luck with your
plain printk (if it's just imbalance and it avoids printk locking
sensitive paths).
HTH,
Michal
[1] https://github.com/Werkov/linux/tree/cgroup-ml/css-lifecycle-b2
next prev parent reply other threads:[~2022-05-27 16:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 15:15 [PATCH 0/2] cgroup_subsys_state lifecycle fixups Michal Koutný
2022-05-25 15:15 ` [PATCH 1/2] cgroup: Wait for cgroup_subsys_state offlining on unmount Michal Koutný
2022-05-25 15:15 ` [PATCH 2/2] cgroup: Use separate work structs on css release path Michal Koutný
2022-05-25 16:14 ` Michal Koutný
2022-05-26 9:56 ` Michal Koutný
2022-05-26 18:15 ` Tejun Heo
2022-05-27 16:39 ` Tadeusz Struk
2022-05-27 16:54 ` Michal Koutný [this message]
2022-05-27 17:23 ` Tejun Heo
2022-06-01 23:13 ` Tadeusz Struk
2022-06-01 23:20 ` Tejun Heo
2022-06-01 23:37 ` Tadeusz Struk
2022-06-01 23:43 ` Tejun Heo
2022-06-02 0:00 ` Tadeusz Struk
2022-06-02 0:07 ` Tejun Heo
2022-06-02 0:26 ` Tadeusz Struk
2022-06-02 0:29 ` Tejun Heo
2022-06-02 0:40 ` Tadeusz Struk
2022-06-02 11:47 ` Michal Koutný
2022-06-02 14:28 ` Tadeusz Struk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220527165429.GJ11007@blackbody.suse.cz \
--to=mkoutny@suse.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=minhquangbui99@gmail.com \
--cc=tadeusz.struk@linaro.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).