From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6A94C433F5 for ; Mon, 30 May 2022 10:53:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235488AbiE3Kxy (ORCPT ); Mon, 30 May 2022 06:53:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235296AbiE3Kxw (ORCPT ); Mon, 30 May 2022 06:53:52 -0400 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0CDA47550 for ; Mon, 30 May 2022 03:53:49 -0700 (PDT) Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24U8hF83003487; Mon, 30 May 2022 05:53:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=CA7nSWc/bxcs60/+XFOKN9BKEj4sNIHLXQRef45Ouz4=; b=itK/QRvas1VOFmAx1tGQVS8tXAkZrU0HtCz5g0+ns/oy+9uJoYx7Sp14C9UPYgSEaEFa s26TqFGUHhFnRGWO7TRynmdViDpFgRVwYJfe5FUO2GRIlrlfO1xRHGiQbmB1qIhn+qTS 9FANWfOsdO9yodylCu3pAP6zwXfLqTX4Dl7oaaoTOssh0j87lrxDn5fLEICe0TysvuO+ 0W0uBGRqfRI4yGSZvVVLyYbVkNAawnHXv6L8oapfMebVzYkiRW2fKeicyZXgeDdfm4t7 e9vB7499KaUGezMa6qLpyXaMf6KUyL/xYdUG/02WhMc59KoOPKfCssJ1OSRAJKvZj83+ +g== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3gbg5nhnm0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Mon, 30 May 2022 05:53:31 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 30 May 2022 11:53:29 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Mon, 30 May 2022 11:53:29 +0100 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 876A946C; Mon, 30 May 2022 10:53:29 +0000 (UTC) Date: Mon, 30 May 2022 10:53:29 +0000 From: Charles Keepax To: Takashi Iwai CC: Vitaly Rodionov , Jaroslav Kysela , Takashi Iwai , Mark Brown , , , Subject: Re: [PATCH v4 00/17] ALSA: hda: cirrus: Add initial DSP support and firmware loading Message-ID: <20220530105329.GV38351@ediswmail.ad.cirrus.com> References: <20220525131638.5512-1-vitalyr@opensource.cirrus.com> <871qwf0x8t.wl-tiwai@suse.de> <20220530090846.GS38351@ediswmail.ad.cirrus.com> <87czfvxtsc.wl-tiwai@suse.de> <20220530093639.GT38351@ediswmail.ad.cirrus.com> <87a6azxr7h.wl-tiwai@suse.de> <20220530103415.GU38351@ediswmail.ad.cirrus.com> <871qwbxpsb.wl-tiwai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <871qwbxpsb.wl-tiwai@suse.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-ORIG-GUID: 8UOBs33TfOfRbSmlXAAfeQgRZvOOO0el X-Proofpoint-GUID: 8UOBs33TfOfRbSmlXAAfeQgRZvOOO0el X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 30, 2022 at 12:45:08PM +0200, Takashi Iwai wrote: > On Mon, 30 May 2022 12:34:15 +0200, > Charles Keepax wrote: > Well, if an ALSA control can trigger the firmware loading, that's > already fragile. A firmware loading is a heavy task, which should > happen only at probing and/or resuming in general. Do we have other > drivers doing the f/w loading triggered by a kctl...? > > > I guess we could look at adding locked versions of the add > > control functions as well if that might be preferred? > > If the patterns of additional kctls (specific for firmware?) are > fixed, we may create all such kctls beforehand and let them inactive > unless the corresponding firmware is really loaded, too. > I am afraid we do, basically all the Wolfson/Cirrus audio devices allow you to select the firmware through a kctl. The patterns of controls are specific to the firmwares, so we can't really create them ahead of time. One could maybe look at changing when the firmwares are loaded, such as attempting to load all possible firmwares on boot or something but its a fairly sizable change that isn't without some side effects. Thanks, Charles