From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
mark@msapiro.net, workflows@vger.kernel.org,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
MTD Maling List <linux-mtd@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: Getting rid of infradead.org - corrupted subjects
Date: Tue, 31 May 2022 21:59:44 +0200 [thread overview]
Message-ID: <20220531195944.a4gyevqfxdafo5qa@pengutronix.de> (raw)
In-Reply-To: <20220525192329.iomxf2imkaymbjc3@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 3695 bytes --]
Hello,
On Wed, May 25, 2022 at 09:23:32PM +0200, Uwe Kleine-König wrote:
> On Wed, May 25, 2022 at 10:55:18AM +0100, David Woodhouse wrote:
> > On Wed, 2022-05-25 at 10:34 +0200, Geert Uytterhoeven wrote:
> > > CC dwmw2
> >
> > Thanks, Geert.
> >
> > > On Wed, May 25, 2022 at 10:07 AM Krzysztof Kozlowski
> > > <krzysztof.kozlowski@linaro.org> wrote:
> > >
> > > > The address list is semi-random as I don't know whom to approach.
> > > > Problem: infradead.org corrupts email subjects by changing:
> > > > s/,/, /
> >
> > I found an old thread on mailman-users which appears to be claiming
> > that it's just standard folding as described in RFC2822 §2.2.3.
> >
> > https://mail.python.org/pipermail/mailman-users/2007-May/057119.html
> >
> > 2.2.3. Long Header Fields
> >
> > Each header field is logically a single line of characters comprising
> > the field name, the colon, and the field body. For convenience
> > however, and to deal with the 998/78 character limitations per line,
> > the field body portion of a header field can be split into a multiple
> > line representation; this is called "folding". The general rule is
> > that wherever this standard allows for folding white space (not
> > simply WSP characters), a CRLF may be inserted before any WSP. For
> > example, the header field:
> >
> > Subject: This is a test
> >
> > can be represented as:
> >
> > Subject: This
> > is a test
> >
> > But this is folding at a *comma*, not at whitespace. The original
> > subject line was (in a single line):
> >
> > Subject: [PATCH v2] dt-bindings: mtd: jedec,spi-nor: remove unneeded properties
> >
> > ... and Mailman 'folded' it in the wrong place to:
> >
> > Subject: [PATCH v2] dt-bindings: mtd: jedec,
> > spi-nor: remove unneeded properties
> >
> > That *isn't* proper folding because it didn't happen at a whitespace.
> >
> > I do need to upgrade to Mailman 3 at some point; I've been
> > procrastinating on the basis that it "ain't broke". For the time being
> > I've just disabled folding in MM2 with a trivial hack:
> >
> > --- Message.py.orig 2022-05-25 02:51:05.917145192 -0700
> > +++ Message.py 2022-05-25 02:50:44.137142069 -0700
> > @@ -49,7 +49,7 @@ class Generator(email.Generator.Generato
> > Headers will by default _not_ be folded in attachments.
> > """
> > def __init__(self, outfp, mangle_from_=True,
> > - maxheaderlen=78, children_maxheaderlen=0):
> > + maxheaderlen=0, children_maxheaderlen=0):
> > email.Generator.Generator.__init__(self, outfp,
> > mangle_from_=mangle_from_, maxheaderlen=maxheaderlen)
> > self.__children_maxheaderlen = children_maxheaderlen
>
> For the record: Some time ago I debugged that myself, too and found an
> equivalent change. So this looks good to me.
small supplement: I found the change I did back then:
--- /usr/lib/python2.7/email/header.py 2018-09-26 20:42:22.000000000 +0200
+++ /usr/lib/python2.7/email/header.py 2018-09-26 20:42:22.000000000 +0200
@@ -371,7 +371,7 @@
joiner = NL + self._continuation_ws
return joiner.join(chunks)
- def encode(self, splitchars=';, '):
+ def encode(self, splitchars=' '):
"""Encode a message header into an RFC-compliant format.
There are many issues involved in converting a given string for use in
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-05-31 20:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 8:07 Getting rid of infradead.org - corrupted subjects Krzysztof Kozlowski
2022-05-25 8:34 ` Geert Uytterhoeven
2022-05-25 9:55 ` David Woodhouse
2022-05-25 14:30 ` Rob Herring
2022-05-25 15:16 ` David Woodhouse
2022-06-14 9:47 ` Chen-Yu Tsai
2022-05-25 19:23 ` Uwe Kleine-König
2022-05-31 19:59 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220531195944.a4gyevqfxdafo5qa@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=arnd@arndb.de \
--cc=dwmw2@infradead.org \
--cc=geert@linux-m68k.org \
--cc=konstantin@linuxfoundation.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mark@msapiro.net \
--cc=miquel.raynal@bootlin.com \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).