From: Sudeep Holla <sudeep.holla@arm.com>
To: Gavin Shan <gshan@redhat.com>
Cc: linux-kernel@vger.kernel.org, Atish Patra <atishp@atishpatra.org>,
Atish Patra <atishp@rivosinc.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Qing Wang <wangqing@vivo.com>,
linux-arm-kernel@lists.infradead.org,
linux-riscv@lists.infradead.org, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v3 02/16] cacheinfo: Add helper to access any cache index for a given CPU
Date: Wed, 1 Jun 2022 13:45:01 +0100 [thread overview]
Message-ID: <20220601124501.v4ylb4oqs4uq2oxj@bogus> (raw)
In-Reply-To: <9a70f2b2-e45c-b125-1c14-d5a06097be58@redhat.com>
On Wed, Jun 01, 2022 at 10:44:20AM +0800, Gavin Shan wrote:
> Hi Sudeep,
>
> On 5/25/22 4:14 PM, Sudeep Holla wrote:
> > The cacheinfo for a given CPU at a given index is used at quite a few
> > places by fetching the base point for index 0 using the helper
> > per_cpu_cacheinfo(cpu) and offseting it by the required index.
> >
> > Instead, add another helper to fetch the required pointer directly and
> > use it to simplify and improve readability.
> >
> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> > ---
> > drivers/base/cacheinfo.c | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
> >
>
> s/offseting/offsetting
>
> It looks good to me with below nits fixed:
>
> Reviewed-by: Gavin Shan <gshan@redhat.com>
>
>
> > diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c
> > index b0bde272e2ae..c4547d8ac6f3 100644
> > --- a/drivers/base/cacheinfo.c
> > +++ b/drivers/base/cacheinfo.c
> > @@ -25,6 +25,8 @@ static DEFINE_PER_CPU(struct cpu_cacheinfo, ci_cpu_cacheinfo);
> > #define ci_cacheinfo(cpu) (&per_cpu(ci_cpu_cacheinfo, cpu))
> > #define cache_leaves(cpu) (ci_cacheinfo(cpu)->num_leaves)
> > #define per_cpu_cacheinfo(cpu) (ci_cacheinfo(cpu)->info_list)
> > +#define per_cpu_cacheinfo_idx(cpu, idx) \
> > + (per_cpu_cacheinfo(cpu) + (idx))
> > struct cpu_cacheinfo *get_cpu_cacheinfo(unsigned int cpu)
> > {
> > @@ -172,7 +174,7 @@ static int cache_setup_of_node(unsigned int cpu)
> > }
> > while (index < cache_leaves(cpu)) {
> > - this_leaf = this_cpu_ci->info_list + index;
> > + this_leaf = per_cpu_cacheinfo_idx(cpu, index);
> > if (this_leaf->level != 1)
> > np = of_find_next_cache_node(np);
> > else
> > @@ -231,7 +233,7 @@ static int cache_shared_cpu_map_setup(unsigned int cpu)
> > for (index = 0; index < cache_leaves(cpu); index++) {
> > unsigned int i;
> > - this_leaf = this_cpu_ci->info_list + index;
> > + this_leaf = per_cpu_cacheinfo_idx(cpu, index);
> > /* skip if shared_cpu_map is already populated */
> > if (!cpumask_empty(&this_leaf->shared_cpu_map))
> > continue;
> > @@ -242,7 +244,7 @@ static int cache_shared_cpu_map_setup(unsigned int cpu)
> > if (i == cpu || !sib_cpu_ci->info_list)
> > continue;/* skip if itself or no cacheinfo */
> > - sib_leaf = sib_cpu_ci->info_list + index;
> > + sib_leaf = per_cpu_cacheinfo_idx(i, index);
> > if (cache_leaves_are_shared(this_leaf, sib_leaf)) {
> > cpumask_set_cpu(cpu, &sib_leaf->shared_cpu_map);
> > cpumask_set_cpu(i, &this_leaf->shared_cpu_map);
> > @@ -258,12 +260,11 @@ static int cache_shared_cpu_map_setup(unsigned int cpu)
> > static void cache_shared_cpu_map_remove(unsigned int cpu)
> > {
> > - struct cpu_cacheinfo *this_cpu_ci = get_cpu_cacheinfo(cpu);
> > struct cacheinfo *this_leaf, *sib_leaf;
> > unsigned int sibling, index;
> > for (index = 0; index < cache_leaves(cpu); index++) {
> > - this_leaf = this_cpu_ci->info_list + index;
> > + this_leaf = per_cpu_cacheinfo_idx(cpu, index);
> > for_each_cpu(sibling, &this_leaf->shared_cpu_map) {
> > struct cpu_cacheinfo *sib_cpu_ci;
> >
>
> In cache_shared_cpu_map_remove(), the newly introduced macro
> can be applied when the sibling CPU's cache info is fetched.
>
> sib_leaf = sib_cpu_ci->info_list + index;
>
> to
>
> sib_leaf = per_cpu_cacheinfo_idx(sibling, index);
>
Right, I clearly missed to identify this. Thanks again for the review, all
other comments are now fixed locally and pushed @[1], will post them as part
of next version.
--
Regards,
Sudeep
[1] https://git.kernel.org/sudeep.holla/h/arch_topology
next prev parent reply other threads:[~2022-06-01 12:46 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 8:14 [PATCH v3 00/16] arch_topology: Updates to add socket support and fix cluster ids Sudeep Holla
2022-05-25 8:14 ` [PATCH v3 01/16] cacheinfo: Use of_cpu_device_node_get instead cpu_dev->of_node Sudeep Holla
2022-05-25 8:14 ` [PATCH v3 02/16] cacheinfo: Add helper to access any cache index for a given CPU Sudeep Holla
2022-05-25 8:14 ` [PATCH v3 03/16] cacheinfo: Move cache_leaves_are_shared out of CONFIG_OF Sudeep Holla
2022-05-25 8:14 ` [PATCH v3 04/16] cacheinfo: Add support to check if last level cache(LLC) is valid or shared Sudeep Holla
2022-05-25 8:14 ` [PATCH v3 05/16] cacheinfo: Allow early detection and population of cache attributes Sudeep Holla
2022-05-25 8:14 ` [PATCH v3 06/16] arch_topology: Add support to parse and detect " Sudeep Holla
2022-05-25 8:14 ` [PATCH v3 07/16] arch_topology: Use the last level cache information from the cacheinfo Sudeep Holla
2022-05-25 8:14 ` [PATCH v3 08/16] arm64: topology: Remove redundant setting of llc_id in CPU topology Sudeep Holla
2022-05-25 8:14 ` [PATCH v3 09/16] arch_topology: Drop LLC identifier stash from the " Sudeep Holla
2022-05-25 8:14 ` [PATCH v3 10/16] arch_topology: Set thread sibling cpumask only within the cluster Sudeep Holla
2022-05-25 8:14 ` [PATCH v3 11/16] arch_topology: Check for non-negative value rather than -1 for IDs validity Sudeep Holla
2022-05-25 8:14 ` [PATCH v3 12/16] arch_topology: Avoid parsing through all the CPUs once a outlier CPU is found Sudeep Holla
2022-05-25 8:14 ` [PATCH v3 13/16] arch_topology: Don't set cluster identifier as physical package identifier Sudeep Holla
2022-05-25 8:14 ` [PATCH v3 14/16] arch_topology: Drop unnecessary check for uninitialised package_id Sudeep Holla
2022-05-25 8:14 ` [PATCH v3 15/16] arch_topology: Set cluster identifier in each core/thread from /cpu-map Sudeep Holla
2022-05-25 8:14 ` [PATCH v3 16/16] arch_topology: Add support for parsing sockets in /cpu-map Sudeep Holla
2022-06-03 12:30 ` [PATCH v3 15/16] arch_topology: Set cluster identifier in each core/thread from /cpu-map Dietmar Eggemann
2022-06-06 10:21 ` Sudeep Holla
2022-06-10 10:08 ` Vincent Guittot
2022-06-10 10:27 ` Sudeep Holla
2022-06-13 9:19 ` Dietmar Eggemann
2022-06-13 11:17 ` Sudeep Holla
2022-06-16 16:02 ` Dietmar Eggemann
2022-06-17 11:16 ` Sudeep Holla
2022-06-20 13:27 ` Dietmar Eggemann
2022-06-21 16:00 ` Sudeep Holla
2022-06-14 17:59 ` Vincent Guittot
2022-06-15 17:00 ` Sudeep Holla
2022-06-15 22:44 ` Vincent Guittot
2022-06-15 22:45 ` Vincent Guittot
2022-06-01 3:40 ` [PATCH v3 12/16] arch_topology: Avoid parsing through all the CPUs once a outlier CPU is found Gavin Shan
2022-06-01 3:38 ` [PATCH v3 11/16] arch_topology: Check for non-negative value rather than -1 for IDs validity Gavin Shan
2022-06-01 3:36 ` [PATCH v3 10/16] arch_topology: Set thread sibling cpumask only within the cluster Gavin Shan
2022-06-01 3:35 ` [PATCH v3 09/16] arch_topology: Drop LLC identifier stash from the CPU topology Gavin Shan
2022-06-01 12:06 ` Sudeep Holla
2022-06-02 6:44 ` Gavin Shan
2022-06-02 6:42 ` Gavin Shan
2022-06-02 6:42 ` [PATCH v3 08/16] arm64: topology: Remove redundant setting of llc_id in " Gavin Shan
2022-06-01 3:31 ` [PATCH v3 07/16] arch_topology: Use the last level cache information from the cacheinfo Gavin Shan
2022-06-02 14:26 ` Dietmar Eggemann
2022-06-06 9:54 ` Sudeep Holla
2022-06-01 3:29 ` [PATCH v3 06/16] arch_topology: Add support to parse and detect cache attributes Gavin Shan
2022-06-01 3:25 ` [PATCH v3 05/16] cacheinfo: Allow early detection and population of " Gavin Shan
2022-06-01 3:20 ` [PATCH v3 04/16] cacheinfo: Add support to check if last level cache(LLC) is valid or shared Gavin Shan
2022-06-01 2:51 ` [PATCH v3 03/16] cacheinfo: Move cache_leaves_are_shared out of CONFIG_OF Gavin Shan
2022-06-01 2:44 ` [PATCH v3 02/16] cacheinfo: Add helper to access any cache index for a given CPU Gavin Shan
2022-06-01 12:45 ` Sudeep Holla [this message]
2022-06-01 2:45 ` [PATCH v3 01/16] cacheinfo: Use of_cpu_device_node_get instead cpu_dev->of_node Gavin Shan
2022-06-01 3:49 ` [PATCH v3 00/16] arch_topology: Updates to add socket support and fix cluster ids Gavin Shan
2022-06-01 12:03 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220601124501.v4ylb4oqs4uq2oxj@bogus \
--to=sudeep.holla@arm.com \
--cc=atishp@atishpatra.org \
--cc=atishp@rivosinc.com \
--cc=dietmar.eggemann@arm.com \
--cc=gshan@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=morten.rasmussen@arm.com \
--cc=robh+dt@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=wangqing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).