From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87EF7C433EF for ; Thu, 2 Jun 2022 13:07:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235202AbiFBNHh (ORCPT ); Thu, 2 Jun 2022 09:07:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234759AbiFBNHc (ORCPT ); Thu, 2 Jun 2022 09:07:32 -0400 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FD0113C4F0; Thu, 2 Jun 2022 06:07:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1654175249; x=1685711249; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=igVQzMsvYIknX+6hwmBJ6y9KRsEJXUWoIejU+JY2Qok=; b=QtBipm910kshKcDjf2ClJkCpa2AH/xktD5kQcS+AJ87QgwrzlJUsb6sp cwiAc58MvhIiGkQ5ImIOcBjMypIWP1X8wagp80nDIViq4906FyBis2cJx eNPldvnkzEOhdiTUPXRrvcIt6XGRQqNlprUXYB9KezcZv5hb73ymZIsYf k=; Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-02.qualcomm.com with ESMTP; 02 Jun 2022 06:07:28 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg05-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2022 06:07:28 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 2 Jun 2022 06:07:27 -0700 Received: from hu-pkondeti-hyd.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 2 Jun 2022 06:07:21 -0700 Date: Thu, 2 Jun 2022 18:37:17 +0530 From: Pavan Kondeti To: Krishna Kurapati CC: Krzysztof Kozlowski , Rob Herring , Andy Gross , Bjorn Andersson , Greg Kroah-Hartman , Felipe Balbi , Stephen Boyd , Doug Anderson , "Matthias Kaehlcke" , Mathias Nyman , , , , , , , , , Sandeep Maheswaram Subject: Re: [PATCH v20 4/5] usb: dwc3: qcom: Configure wakeup interrupts during suspend Message-ID: <20220602130717.GA2521@hu-pkondeti-hyd.qualcomm.com> References: <1654158277-12921-1-git-send-email-quic_kriskura@quicinc.com> <1654158277-12921-5-git-send-email-quic_kriskura@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1654158277-12921-5-git-send-email-quic_kriskura@quicinc.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 02, 2022 at 01:54:36PM +0530, Krishna Kurapati wrote: > From: Sandeep Maheswaram > > Configure DP/DM line interrupts based on the USB2 device attached to > the root hub port. When HS/FS device is connected, configure the DP line > as falling edge to detect both disconnect and remote wakeup scenarios. When > LS device is connected, configure DM line as falling edge to detect both > disconnect and remote wakeup. When no device is connected, configure both > DP and DM lines as rising edge to detect HS/HS/LS device connect scenario. > > Signed-off-by: Sandeep Maheswaram > Signed-off-by: Krishna Kurapati > --- > drivers/usb/dwc3/dwc3-qcom.c | 72 ++++++++++++++++++++++++++++++++++++++------ > 1 file changed, 62 insertions(+), 10 deletions(-) > > diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c > index 7352124..9395d79 100644 > --- a/drivers/usb/dwc3/dwc3-qcom.c > +++ b/drivers/usb/dwc3/dwc3-qcom.c > @@ -20,7 +20,8 @@ > #include > #include > #include > - > +#include > +#include > #include "core.h" > > /* USB QSCRATCH Hardware registers */ > @@ -76,6 +77,7 @@ struct dwc3_qcom { > int dp_hs_phy_irq; > int dm_hs_phy_irq; > int ss_phy_irq; > + enum usb_device_speed usb2_speed; > > struct extcon_dev *edev; > struct extcon_dev *host_edev; > @@ -296,11 +298,34 @@ static void dwc3_qcom_interconnect_exit(struct dwc3_qcom *qcom) > icc_put(qcom->icc_path_apps); > } > > -static void dwc3_qcom_enable_wakeup_irq(int irq) > +enum usb_device_speed dwc3_qcom_read_usb2_speed(struct dwc3_qcom *qcom) > +{ > + struct dwc3 *dwc = platform_get_drvdata(qcom->dwc3); > + struct usb_hcd *hcd = platform_get_drvdata(dwc->xhci); > + struct usb_device *udev; > + > + /* > + * It is possible to query the speed of all children of > + * USB2.0 root hub via usb_hub_for_each_child(). DWC3 code > + * currently supports only 1 port per controller. So > + * this is sufficient. > + */ > + udev = usb_hub_find_child(hcd->self.root_hub, 1); > + > + if (!udev) > + return USB_SPEED_UNKNOWN; > + > + return udev->speed; > +} > + > +static void dwc3_qcom_enable_wakeup_irq(int irq, unsigned int polarity) > { > if (!irq) > return; > > + if (polarity) > + irq_set_irq_type(irq, polarity); > + > enable_irq(irq); > enable_irq_wake(irq); > } > @@ -318,22 +343,47 @@ static void dwc3_qcom_disable_interrupts(struct dwc3_qcom *qcom) > { > dwc3_qcom_disable_wakeup_irq(qcom->hs_phy_irq); > > - dwc3_qcom_disable_wakeup_irq(qcom->dp_hs_phy_irq); > - > - dwc3_qcom_disable_wakeup_irq(qcom->dm_hs_phy_irq); > + if (qcom->usb2_speed == USB_SPEED_LOW) { > + dwc3_qcom_disable_wakeup_irq(qcom->dm_hs_phy_irq); > + } else if ((qcom->usb2_speed == USB_SPEED_HIGH) || > + (qcom->usb2_speed == USB_SPEED_FULL)) { > + dwc3_qcom_disable_wakeup_irq(qcom->dp_hs_phy_irq); > + } else { > + dwc3_qcom_disable_wakeup_irq(qcom->dp_hs_phy_irq); > + dwc3_qcom_disable_wakeup_irq(qcom->dm_hs_phy_irq); > + } > > dwc3_qcom_disable_wakeup_irq(qcom->ss_phy_irq); > } > > static void dwc3_qcom_enable_interrupts(struct dwc3_qcom *qcom) > { > - dwc3_qcom_enable_wakeup_irq(qcom->hs_phy_irq); > + dwc3_qcom_enable_wakeup_irq(qcom->hs_phy_irq, 0); > > - dwc3_qcom_enable_wakeup_irq(qcom->dp_hs_phy_irq); > + /* > + * Configure DP/DM line interrupts based on the USB2 device attached to > + * the root hub port. When HS/FS device is connected, configure the DP line > + * as falling edge to detect both disconnect and remote wakeup scenarios. When > + * LS device is connected, configure DM line as falling edge to detect both > + * disconnect and remote wakeup. When no device is connected, configure both > + * DP and DM lines as rising edge to detect HS/HS/LS device connect scenario. > + */ > > - dwc3_qcom_enable_wakeup_irq(qcom->dm_hs_phy_irq); > + if (qcom->usb2_speed == USB_SPEED_LOW) { > + dwc3_qcom_enable_wakeup_irq(qcom->dm_hs_phy_irq, > + IRQ_TYPE_EDGE_FALLING); > + } else if ((qcom->usb2_speed == USB_SPEED_HIGH) || > + (qcom->usb2_speed == USB_SPEED_FULL)) { > + dwc3_qcom_enable_wakeup_irq(qcom->dp_hs_phy_irq, > + IRQ_TYPE_EDGE_FALLING); > + } else { > + dwc3_qcom_enable_wakeup_irq(qcom->dp_hs_phy_irq, > + IRQ_TYPE_EDGE_RISING); > + dwc3_qcom_enable_wakeup_irq(qcom->dm_hs_phy_irq, > + IRQ_TYPE_EDGE_RISING); > + } > > - dwc3_qcom_enable_wakeup_irq(qcom->ss_phy_irq); > + dwc3_qcom_enable_wakeup_irq(qcom->ss_phy_irq, 0); > } > > static int dwc3_qcom_suspend(struct dwc3_qcom *qcom) > @@ -355,8 +405,10 @@ static int dwc3_qcom_suspend(struct dwc3_qcom *qcom) > if (ret) > dev_warn(qcom->dev, "failed to disable interconnect: %d\n", ret); > > - if (device_may_wakeup(qcom->dev)) > + if (device_may_wakeup(qcom->dev)) { > + qcom->usb2_speed = dwc3_qcom_read_usb2_speed(qcom); > dwc3_qcom_enable_interrupts(qcom); > + } > > qcom->is_suspended = true; > Looks good to me. Reviewed-by: Pavankumar Kondeti Thanks, Pavan