From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Ira Weiny <ira.weiny@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Alison Schofield <alison.schofield@intel.com>,
"Vishal Verma" <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
"Ben Widawsky" <ben@bwidawsk.net>, <linux-kernel@vger.kernel.org>,
<linux-cxl@vger.kernel.org>, <linux-pci@vger.kernel.org>
Subject: Re: [PATCH V9 6/9] cxl/port: Read CDAT table
Date: Mon, 6 Jun 2022 15:49:52 +0100 [thread overview]
Message-ID: <20220606154952.000008c7@Huawei.com> (raw)
In-Reply-To: <Ypk+Cc0fWelIcamX@iweiny-desk3>
On Thu, 2 Jun 2022 15:47:37 -0700
Ira Weiny <ira.weiny@intel.com> wrote:
> On Thu, Jun 02, 2022 at 11:31:56AM -0700, Ira wrote:
> > On Wed, Jun 01, 2022 at 05:31:13PM +0100, Jonathan Cameron wrote:
> > > On Wed, 1 Jun 2022 16:35:40 +0100
> > > Jonathan Cameron <Jonathan.Cameron@Huawei.com> wrote:
> > >
> > > > On Tue, 31 May 2022 08:26:29 -0700
> > > > ira.weiny@intel.com wrote:
> > > >
> > > > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > > > >
> > > > > The OS will need CDAT data from CXL devices to properly set up
> > > > > interleave sets. Currently this is supported through a DOE mailbox
> > > > > which supports CDAT.
> > > > >
> > > > > Cache the CDAT data for later parsing. Provide a sysfs binary attribute
> > > > > to allow dumping of the CDAT.
> > > > >
> > > > > Binary dumping is modeled on /sys/firmware/ACPI/tables/
> > > > >
> > > > > The ability to dump this table will be very useful for emulation of real
> > > > > devices once they become available as QEMU CXL type 3 device emulation will
> > > > > be able to load this file in.
> > > > >
> > > > > This does not support table updates at runtime. It will always provide
> > > > > whatever was there when first cached. Handling of table updates can be
> > > > > implemented later.
> > > > >
> > > > > Finally create a complete list of DOE defines within cdat.h for code
> > > > > wishing to decode the CDAT table.
> > > > >
> > > > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > > > > Co-developed-by: Ira Weiny <ira.weiny@intel.com>
> > > > > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> > > > >
> > > >
> > > > Fun question of ownership inline...
> > >
> > > And a follow up due to triggering a bug that predated this series...
> > >
> > > I'd send a fix, but I'm off on a long weekend shortly :)
> >
> > NP I discussed with Dan and the use of dev_groups should allow me to move this
> > to port probe where it belongs. I put it here for the sysfs stuff.
>
> Not to make a habit of replying to my own mails but this works.
>
> So I'm going to go forward with spinning this again.
It's the right solution - cleaner than moving the ownership.
Jonathan
>
> Ira
next prev parent reply other threads:[~2022-06-06 14:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 15:26 [PATCH V9 0/9] CXL: Read CDAT and DSMAS data ira.weiny
2022-05-31 15:26 ` [PATCH V9 1/9] PCI: Add vendor ID for the PCI SIG ira.weiny
2022-05-31 17:00 ` [PATCH v9 " Davidlohr Bueso
2022-05-31 15:26 ` [PATCH V9 2/9] PCI: Replace magic constant for PCI Sig Vendor ID ira.weiny
2022-05-31 17:00 ` [PATCH v9 " Davidlohr Bueso
2022-05-31 15:26 ` [PATCH V9 3/9] PCI: Create PCI library functions in support of DOE mailboxes ira.weiny
2022-05-31 17:25 ` [PATCH v9 " Davidlohr Bueso
2022-05-31 17:56 ` Davidlohr Bueso
2022-06-01 4:53 ` Ira Weiny
2022-06-01 13:59 ` Davidlohr Bueso
2022-06-01 16:55 ` Ira Weiny
2022-05-31 15:26 ` [PATCH V9 4/9] cxl/pci: Create PCI DOE mailbox's for memory devices ira.weiny
2022-05-31 17:50 ` Ben Widawsky
2022-06-01 14:35 ` Jonathan Cameron
2022-06-01 23:01 ` Ira Weiny
2022-05-31 15:26 ` [PATCH V9 5/9] cxl/port: Find a DOE mailbox which supports CDAT ira.weiny
2022-05-31 17:57 ` Ben Widawsky
2022-06-01 22:03 ` Ira Weiny
2022-05-31 15:26 ` [PATCH V9 6/9] cxl/port: Read CDAT table ira.weiny
2022-06-01 15:35 ` Jonathan Cameron
2022-06-01 16:31 ` Jonathan Cameron
2022-06-02 18:31 ` Ira Weiny
2022-06-02 22:47 ` Ira Weiny
2022-06-06 14:49 ` Jonathan Cameron [this message]
2022-05-31 15:26 ` [PATCH V9 7/9] cxl/port: Introduce cxl_cdat_valid() ira.weiny
2022-05-31 17:21 ` Alison Schofield
2022-06-01 22:10 ` Ira Weiny
2022-05-31 15:26 ` [PATCH V9 8/9] cxl/port: Retry reading CDAT on failure ira.weiny
2022-05-31 17:07 ` Alison Schofield
2022-06-01 4:54 ` Ira Weiny
2022-05-31 19:30 ` [PATCH v9 " Davidlohr Bueso
2022-05-31 15:26 ` [PATCH V9 9/9] cxl/port: Parse out DSMAS data from CDAT table ira.weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220606154952.000008c7@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=ben@bwidawsk.net \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).