From: Henning Schild <henning.schild@siemens.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Mark Gross <markgross@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
linux-watchdog@vger.kernel.org, Enrico Weigelt <lkml@metux.net>,
Gerd Haeussler <gerd.haeussler.ext@siemens.com>
Subject: Re: [PATCH v3 0/4] simatic-ipc additions to p2sb apl lake gpio
Date: Tue, 7 Jun 2022 18:15:15 +0200 [thread overview]
Message-ID: <20220607181515.3f1e240c@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <Yp9sLePHn9RqcXcU@smile.fi.intel.com>
Am Tue, 7 Jun 2022 18:18:05 +0300
schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>:
> On Mon, May 23, 2022 at 07:24:08PM +0300, Andy Shevchenko wrote:
> > On Fri, May 13, 2022 at 10:36:48AM +0200, Henning Schild wrote:
> > > changed since v2:
> > > - put GPIO led module under same config switch
> > > - some style changes from review
> > > - init gpios with gpiod_get_index and drop gpiod_set_value
> > > - drop bogus "if" from watchdog Kconfig
> > >
> > > changed since v1:
> > > - rebased
> > > - split p1 into p1-3
> > >
> > > This switches the simatic-ipc modules to using the upcoming p2sb
> > > interface introduced by Andy with
> > > "platform/x86: introduce p2sb_bar() helper".
> > > The series relies on these p2sb changes already applied and Andy
> > > will likely take them into his series at some point.
> > >
> > > It also switches to one apollo lake device to using gpio leds.
> >
> > Hmm... This series misses LEDS maintainer. Okay, I will include
> > them when sending v6 after v5.19-rc1.
>
> I have sent v6 [1], please make sure everything is okay.
I received that and had a quick look over my bits. That all looked like
i sent it so i have no reason to doubt it would be working as expected.
In the coming two weeks i will not be able to get my hands on hardware,
so can not test but am pretty sure it is not needed another time.
regards,
Henning
> [1]:
> https://lore.kernel.org/platform-driver-x86/20220606164138.66535-1-andriy.shevchenko@linux.intel.com/
prev parent reply other threads:[~2022-06-07 16:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 8:36 [PATCH v3 0/4] simatic-ipc additions to p2sb apl lake gpio Henning Schild
2022-05-13 8:36 ` [PATCH v3 1/4] leds: simatic-ipc-leds: convert to use P2SB accessor Henning Schild
2022-05-13 8:36 ` [PATCH v3 2/4] watchdog: simatic-ipc-wdt: " Henning Schild
2022-05-13 13:01 ` Guenter Roeck
2022-05-13 8:36 ` [PATCH v3 3/4] platform/x86: simatic-ipc: drop custom P2SB bar code Henning Schild
2022-05-23 16:22 ` Andy Shevchenko
2022-05-13 8:36 ` [PATCH v3 4/4] leds: simatic-ipc-leds-gpio: add GPIO version of Siemens driver Henning Schild
2022-05-23 16:24 ` [PATCH v3 0/4] simatic-ipc additions to p2sb apl lake gpio Andy Shevchenko
2022-06-07 15:18 ` Andy Shevchenko
2022-06-07 16:15 ` Henning Schild [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220607181515.3f1e240c@md1za8fc.ad001.siemens.net \
--to=henning.schild@siemens.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gerd.haeussler.ext@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkml@metux.net \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).