From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, wens@csie.org,
jic23@kernel.org, lee.jones@linaro.org, broonie@kernel.org,
gregkh@linuxfoundation.org, lgirdwood@gmail.com, lars@metafoo.de,
rafael@kernel.org, quic_gurus@quicinc.com,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 16/17] power: axp20x_battery: Support battery status without fuel gauge
Date: Thu, 9 Jun 2022 23:11:56 +0200 [thread overview]
Message-ID: <20220609211156.fvrb6jvwnnhvu3mq@mercury.elektranox.org> (raw)
In-Reply-To: <20220607155324.118102-17-aidanmacdonald.0x0@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3480 bytes --]
Hi,
On Tue, Jun 07, 2022 at 04:53:23PM +0100, Aidan MacDonald wrote:
> Add a "has_fg" flag to indicate that the chip has a fuel gauge.
> Report battery full status on chips with no fuel gauge using the
> battery voltage.
>
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
> ---
Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com>
-- Sebastian
> drivers/power/supply/axp20x_battery.c | 34 ++++++++++++++++++++++++++-
> 1 file changed, 33 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/axp20x_battery.c b/drivers/power/supply/axp20x_battery.c
> index 87fb958f2224..e9547e2d7c48 100644
> --- a/drivers/power/supply/axp20x_battery.c
> +++ b/drivers/power/supply/axp20x_battery.c
> @@ -62,6 +62,7 @@ struct axp_data {
> int ccc_scale;
> int ccc_offset;
> const int *ccc_table;
> + bool has_fg;
> bool has_fg_valid;
> int (*get_max_voltage)(struct axp20x_batt_ps *batt, int *val);
> int (*set_max_voltage)(struct axp20x_batt_ps *batt, int val);
> @@ -190,7 +191,7 @@ static int axp20x_battery_get_prop(struct power_supply *psy,
> union power_supply_propval *val)
> {
> struct axp20x_batt_ps *axp20x_batt = power_supply_get_drvdata(psy);
> - int ret = 0, reg, val1;
> + int ret = 0, reg, val1, val2;
>
> switch (psp) {
> case POWER_SUPPLY_PROP_PRESENT:
> @@ -224,6 +225,34 @@ static int axp20x_battery_get_prop(struct power_supply *psy,
> return 0;
> }
>
> + /*
> + * If the chip does not have a fuel gauge, we check battery full status
> + * using voltage instead.
> + */
> + if (!axp20x_batt->data->has_fg) {
> + ret = axp20x_batt->data->get_max_voltage(axp20x_batt, &val1);
> + if (ret)
> + return ret;
> +
> + ret = iio_read_channel_processed(axp20x_batt->batt_v, &val2);
> + if (ret)
> + return ret;
> +
> + /* IIO subsystem reports voltage in mV but we need uV */
> + val2 *= 1000;
> +
> + /*
> + * According to the AXP192 datasheet, charging will restart if
> + * the battery voltage drops below V_rch = V_tgt - 0.1 V, so we
> + * report the battery is full if its voltage is at least V_rch.
> + */
> + if (val2 >= val1 - 100000)
> + val->intval = POWER_SUPPLY_STATUS_FULL;
> + else
> + val->intval = POWER_SUPPLY_STATUS_NOT_CHARGING;
> + break;
> + }
> +
> ret = regmap_read(axp20x_batt->regmap, AXP20X_FG_RES, &val1);
> if (ret)
> return ret;
> @@ -546,6 +575,7 @@ static const struct power_supply_desc axp20x_batt_ps_desc = {
> static const struct axp_data axp209_data = {
> .ccc_scale = 100000,
> .ccc_offset = 300000,
> + .has_fg = true,
> .get_max_voltage = axp20x_battery_get_max_voltage,
> .set_max_voltage = axp20x_battery_set_max_voltage,
> };
> @@ -553,6 +583,7 @@ static const struct axp_data axp209_data = {
> static const struct axp_data axp221_data = {
> .ccc_scale = 150000,
> .ccc_offset = 300000,
> + .has_fg = true,
> .has_fg_valid = true,
> .get_max_voltage = axp22x_battery_get_max_voltage,
> .set_max_voltage = axp22x_battery_set_max_voltage,
> @@ -561,6 +592,7 @@ static const struct axp_data axp221_data = {
> static const struct axp_data axp813_data = {
> .ccc_scale = 200000,
> .ccc_offset = 200000,
> + .has_fg = true,
> .has_fg_valid = true,
> .get_max_voltage = axp813_battery_get_max_voltage,
> .set_max_voltage = axp20x_battery_set_max_voltage,
> --
> 2.35.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-06-09 21:12 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 15:53 [PATCH v2 00/17] Add support for AXP192 PMIC Aidan MacDonald
2022-06-07 15:53 ` [PATCH v2 01/17] regmap-irq: Use sub_irq_reg() to calculate unmask register address Aidan MacDonald
2022-06-09 16:39 ` Guru Das Srinagesh
2022-06-11 14:32 ` Aidan MacDonald
2022-06-07 15:53 ` [PATCH v2 02/17] regmap-irq: Add get_irq_reg to support unusual register layouts Aidan MacDonald
2022-06-08 16:17 ` Mark Brown
2022-06-10 15:40 ` Aidan MacDonald
2022-06-10 16:47 ` Mark Brown
2022-06-11 14:22 ` Aidan MacDonald
2022-06-23 8:54 ` Matti Vaittinen
2022-06-23 20:35 ` Aidan MacDonald
2022-06-07 15:53 ` [PATCH v2 03/17] dt-bindings: mfd: add bindings for AXP192 MFD device Aidan MacDonald
2022-06-08 10:48 ` Krzysztof Kozlowski
2022-06-09 17:52 ` Aidan MacDonald
2022-06-07 15:53 ` [PATCH v2 04/17] dt-bindings: iio: adc: axp209: Add AXP192 compatible Aidan MacDonald
2022-06-08 10:49 ` Krzysztof Kozlowski
2022-06-07 15:53 ` [PATCH v2 05/17] dt-bindings: power: supply: axp20x: " Aidan MacDonald
2022-06-08 10:50 ` Krzysztof Kozlowski
2022-06-07 15:53 ` [PATCH v2 06/17] dt-bindings: gpio: Add AXP192 GPIO bindings Aidan MacDonald
2022-06-09 20:24 ` Rob Herring
2022-06-07 15:53 ` [PATCH v2 07/17] dt-bindings: power: axp20x-battery: Add AXP192 compatible Aidan MacDonald
2022-06-09 20:24 ` Rob Herring
2022-06-07 15:53 ` [PATCH v2 08/17] mfd: axp20x: Add support for AXP192 Aidan MacDonald
2022-06-07 15:53 ` [PATCH v2 09/17] regulator: " Aidan MacDonald
2022-06-07 15:53 ` [PATCH v2 10/17] iio: adc: axp20x_adc: Minor code cleanups Aidan MacDonald
2022-06-08 13:22 ` Jonathan Cameron
2022-06-08 22:58 ` Aidan MacDonald
2022-06-07 15:53 ` [PATCH v2 11/17] iio: adc: axp20x_adc: Consolidate ADC raw read functions Aidan MacDonald
2022-06-08 13:28 ` Jonathan Cameron
2022-06-08 23:13 ` Aidan MacDonald
2022-06-11 18:23 ` Jonathan Cameron
2022-06-08 13:30 ` Jonathan Cameron
2022-06-07 15:53 ` [PATCH v2 12/17] iio: adc: axp20x_adc: Add support for AXP192 Aidan MacDonald
2022-06-08 13:35 ` Jonathan Cameron
2022-06-07 15:53 ` [PATCH v2 13/17] power: supply: axp20x_usb_power: " Aidan MacDonald
2022-06-09 20:53 ` Sebastian Reichel
2022-06-07 15:53 ` [PATCH v2 14/17] pinctrl: Add AXP192 pin control driver Aidan MacDonald
2022-06-07 15:53 ` [PATCH v2 15/17] power: axp20x_battery: Add constant charge current table Aidan MacDonald
2022-06-09 21:11 ` Sebastian Reichel
2022-06-10 15:40 ` Aidan MacDonald
2022-06-07 15:53 ` [PATCH v2 16/17] power: axp20x_battery: Support battery status without fuel gauge Aidan MacDonald
2022-06-09 21:11 ` Sebastian Reichel [this message]
2022-06-07 15:53 ` [PATCH v2 17/17] power: axp20x_battery: Add support for AXP192 Aidan MacDonald
2022-06-09 21:12 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220609211156.fvrb6jvwnnhvu3mq@mercury.elektranox.org \
--to=sebastian.reichel@collabora.com \
--cc=aidanmacdonald.0x0@gmail.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_gurus@quicinc.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).