linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: Arnd Bergmann <arnd@arndb.de>, Philipp Zabel <p.zabel@pengutronix.de>
Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>,
	Serge Semin <fancer.lancer@gmail.com>,
	Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
	Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
	<soc@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/2] bus: bt1-apb: Don't print error on -EPROBE_DEFER
Date: Fri, 10 Jun 2022 11:01:02 +0300	[thread overview]
Message-ID: <20220610080103.10689-1-Sergey.Semin@baikalelectronics.ru> (raw)

The Baikal-T1 APB bus driver correctly handles the deferred probe
situation, but still pollutes the system log with a misleading error
message. Let's fix that by using the dev_err_probe() method to print the
log message in case of the clocks/resets request errors.

Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
---
 drivers/bus/bt1-apb.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/bt1-apb.c b/drivers/bus/bt1-apb.c
index b25ff941e7c7..ac13b5b97107 100644
--- a/drivers/bus/bt1-apb.c
+++ b/drivers/bus/bt1-apb.c
@@ -176,7 +176,8 @@ static int bt1_apb_request_rst(struct bt1_apb *apb)
 
 	apb->prst = devm_reset_control_get_optional_exclusive(apb->dev, "prst");
 	if (IS_ERR(apb->prst)) {
-		dev_warn(apb->dev, "Couldn't get reset control line\n");
+		dev_err_probe(apb->dev, PTR_ERR(apb->prst),
+			      "Couldn't get reset control line\n");
 		return PTR_ERR(apb->prst);
 	}
 
@@ -200,7 +201,8 @@ static int bt1_apb_request_clk(struct bt1_apb *apb)
 
 	apb->pclk = devm_clk_get(apb->dev, "pclk");
 	if (IS_ERR(apb->pclk)) {
-		dev_err(apb->dev, "Couldn't get APB clock descriptor\n");
+		dev_err_probe(apb->dev, PTR_ERR(apb->pclk),
+			      "Couldn't get APB clock descriptor\n");
 		return PTR_ERR(apb->pclk);
 	}
 
-- 
2.35.1


             reply	other threads:[~2022-06-10  8:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-10  8:01 Serge Semin [this message]
2022-06-10  8:01 ` [PATCH 2/2] bus: bt1-axi: Don't print error on -EPROBE_DEFER Serge Semin
2022-06-10  9:35 ` [PATCH 1/2] bus: bt1-apb: " Philipp Zabel
2022-06-10  9:39   ` Serge Semin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220610080103.10689-1-Sergey.Semin@baikalelectronics.ru \
    --to=sergey.semin@baikalelectronics.ru \
    --cc=Alexey.Malahov@baikalelectronics.ru \
    --cc=Pavel.Parkhomenko@baikalelectronics.ru \
    --cc=arnd@arndb.de \
    --cc=fancer.lancer@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=soc@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).