From: Aaron Tomlin <atomlin@redhat.com>
To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, joro@8bytes.org, will@kernel.org,
dwmw2@infradead.org, baolu.lu@linux.intel.com, hpa@zytor.com
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
atomlin@atomlin.com
Subject: [RFC PATCH 3/3] iommu/vt-d: Show region type in arch_rmrr_sanity_check()
Date: Sat, 11 Jun 2022 21:48:59 +0100 [thread overview]
Message-ID: <20220611204859.234975-3-atomlin@redhat.com> (raw)
In-Reply-To: <20220611204859.234975-1-atomlin@redhat.com>
This patch will attempt to describe the region type in the event
that a given RMRR entry is not within a reserved region.
Signed-off-by: Aaron Tomlin <atomlin@redhat.com>
---
arch/x86/include/asm/iommu.h | 9 ++++++---
arch/x86/kernel/e820.c | 5 +++--
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/arch/x86/include/asm/iommu.h b/arch/x86/include/asm/iommu.h
index bf1ed2ddc74b..d21366644520 100644
--- a/arch/x86/include/asm/iommu.h
+++ b/arch/x86/include/asm/iommu.h
@@ -17,12 +17,15 @@ arch_rmrr_sanity_check(struct acpi_dmar_reserved_memory *rmrr)
{
u64 start = rmrr->base_address;
u64 end = rmrr->end_address + 1;
+ struct e820_entry *entry;
- if (e820__mapped_all(start, end, E820_TYPE_RESERVED))
+ entry = __e820__mapped_all(start, end, 0);
+
+ if (entry && entry->type == E820_TYPE_RESERVED)
return 0;
- pr_err(FW_BUG "No firmware reserved region can cover this RMRR [%#018Lx-%#018Lx], contact BIOS vendor for fixes\n",
- start, end - 1);
+ pr_err(FW_BUG "No firmware reserved region can cover this RMRR [%s: %#018Lx-%#018Lx], contact BIOS vendor for fixes\n",
+ e820_type_to_string(entry), start, end - 1);
return -EINVAL;
}
diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
index 95b994cf80cd..165e9a444bb9 100644
--- a/arch/x86/kernel/e820.c
+++ b/arch/x86/kernel/e820.c
@@ -1073,7 +1073,7 @@ void __init e820__finish_early_params(void)
const char *__init e820_type_to_string(struct e820_entry *entry)
{
- switch (entry->type) {
+ switch (entry && entry->type) {
case E820_TYPE_RESERVED_KERN: /* Fall-through: */
case E820_TYPE_RAM: return "System RAM";
case E820_TYPE_ACPI: return "ACPI Tables";
@@ -1083,8 +1083,9 @@ const char *__init e820_type_to_string(struct e820_entry *entry)
case E820_TYPE_PMEM: return "Persistent Memory";
case E820_TYPE_RESERVED: return "Reserved";
case E820_TYPE_SOFT_RESERVED: return "Soft Reserved";
- default: return "Unknown E820 type";
+ default: break;
}
+ return "Unknown E820 type";
}
static unsigned long __init e820_type_to_iomem_type(struct e820_entry *entry)
--
2.34.1
next prev parent reply other threads:[~2022-06-11 20:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-11 20:48 [RFC PATCH 1/3] x86/boot/e820: Make __e820__mapped_all() external Aaron Tomlin
2022-06-11 20:48 ` [RFC PATCH 2/3] x86/boot/e820: Make e820_type_to_string() external Aaron Tomlin
2022-06-11 20:48 ` Aaron Tomlin [this message]
2022-07-03 15:36 ` [RFC PATCH 3/3] iommu/vt-d: Show region type in arch_rmrr_sanity_check() Aaron Tomlin
2022-07-04 10:39 ` Robin Murphy
2022-07-04 11:15 ` Aaron Tomlin
2022-09-29 8:25 ` [RFC PATCH 1/3] x86/boot/e820: Make __e820__mapped_all() external Aaron Tomlin
2022-09-29 13:51 ` Aaron Tomlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220611204859.234975-3-atomlin@redhat.com \
--to=atomlin@redhat.com \
--cc=atomlin@atomlin.com \
--cc=baolu.lu@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).