From: sunliming <sunliming@kylinos.cn>
To: Ramesh.Errabolu@amd.com, alexander.deucher@amd.com,
Felix.Kuehling@amd.com
Cc: linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
sunliming@kylinos.cn, kelulanainsley@gmail.com,
kernel test robot <lkp@intel.com>
Subject: [PATCH] drm/amdkfd: Add missing #if defined(CONFIG_HSA_AMD_P2P)
Date: Sun, 12 Jun 2022 14:40:50 +0800 [thread overview]
Message-ID: <20220612064050.1175083-1-sunliming@kylinos.cn> (raw)
The variable 'i' in function kfd_dev_create_p2p_links is only used in
codes that gaurded by '#if defined(CONFIG_HSA_AMD_P2P)' check. So adding
CONFIG_HSA_AMD_P2P #ifdef check around variable 'i' too.
Fixes the following w1 warning:
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:1542:11: warning: variable 'i' set but not used [-Wunused-but-set-variable]
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: sunliming <sunliming@kylinos.cn>
---
drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
index 304322ac39e6..4bfce71f7fa9 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
@@ -1539,7 +1539,10 @@ static int kfd_dev_create_p2p_links(void)
{
struct kfd_topology_device *dev;
struct kfd_topology_device *new_dev;
- uint32_t i, k;
+ uint32_t k;
+#if defined(CONFIG_HSA_AMD_P2P)
+ uint32_t i = 0;
+#endif
int ret = 0;
k = 0;
@@ -1553,7 +1556,6 @@ static int kfd_dev_create_p2p_links(void)
return 0;
k--;
- i = 0;
/* create in-direct links */
ret = kfd_create_indirect_link_prop(new_dev, k);
--
2.25.1
reply other threads:[~2022-06-12 6:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220612064050.1175083-1-sunliming@kylinos.cn \
--to=sunliming@kylinos.cn \
--cc=Felix.Kuehling@amd.com \
--cc=Ramesh.Errabolu@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=kelulanainsley@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).