linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <andrea.merello@iit.it>
To: <jic23@kernel.org>, <mchehab+huawei@kernel.org>,
	<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>
Cc: <lars@metafoo.de>, <robh+dt@kernel.org>,
	<andy.shevchenko@gmail.com>, <matt.ranostay@konsulko.com>,
	<ardeleanalex@gmail.com>, <jacopo@jmondi.org>,
	Andrea Merello <andrea.merello@iit.it>
Subject: [v6 07/14] iio: add support for binary attributes
Date: Mon, 13 Jun 2022 14:05:27 +0200	[thread overview]
Message-ID: <20220613120534.36991-8-andrea.merello@iit.it> (raw)
In-Reply-To: <20220613120534.36991-1-andrea.merello@iit.it>

From: Andrea Merello <andrea.merello@iit.it>

When a IIO device is registered, the IIO core creates an attribute group on
its own, where it puts the channel attributes, and where it copies the
attributes in indio_dev->info->attrs.

Unfortunately it doesn't take care of binary attributes (i.e. it only
consider indio_dev->info->attrs->attrs, and it ignores
indio_dev->info->attrs->bin_attrs).

Fix this by making the IIO layer take care also of the binary attributes.

Note that while it is necessary to copy the non-binary attributes because
the IIO layer needs more room to add the channels attribute, it should be
enough to assign the bin_attrs pointer to the binary attributes pointed by
indio_dev->info->attrs->bin_attrs.

Signed-off-by: Andrea Merello <andrea.merello@iit.it>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---
 drivers/iio/industrialio-core.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
index 4d95d4df5e91..2ea5e19ea56a 100644
--- a/drivers/iio/industrialio-core.c
+++ b/drivers/iio/industrialio-core.c
@@ -1581,7 +1581,7 @@ static int iio_device_register_sysfs(struct iio_dev *indio_dev)
 		ret = -ENOMEM;
 		goto error_clear_attrs;
 	}
-	/* Copy across original attributes */
+	/* Copy across original attributes, and point to original binary attributes */
 	if (indio_dev->info->attrs) {
 		memcpy(iio_dev_opaque->chan_attr_group.attrs,
 		       indio_dev->info->attrs->attrs,
@@ -1589,6 +1589,8 @@ static int iio_device_register_sysfs(struct iio_dev *indio_dev)
 		       *attrcount_orig);
 		iio_dev_opaque->chan_attr_group.is_visible =
 			indio_dev->info->attrs->is_visible;
+		iio_dev_opaque->chan_attr_group.bin_attrs =
+			indio_dev->info->attrs->bin_attrs;
 	}
 	attrn = attrcount_orig;
 	/* Add all elements from the list. */
-- 
2.17.1


  parent reply	other threads:[~2022-06-14 12:29 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-13 12:05 [v6 00/14] Add support for Bosch BNO055 IMU andrea.merello
2022-06-13 12:05 ` [v6 01/14] iio: add modifiers for linear acceleration andrea.merello
2022-06-13 12:05 ` [v6 02/14] iio: document linear acceleration modifiers andrea.merello
2022-06-13 12:05 ` [v6 03/14] iio: event_monitor: add " andrea.merello
2022-06-13 12:05 ` [v6 04/14] iio: add modifers for pitch, yaw, roll andrea.merello
2022-06-13 12:05 ` [v6 05/14] iio: document pitch, yaw, roll modifiers andrea.merello
2022-06-13 12:05 ` [v6 06/14] iio: event_monitor: add pitch, yaw and " andrea.merello
2022-06-13 12:05 ` andrea.merello [this message]
2022-06-13 12:05 ` [v6 08/14] iio: imu: add Bosch Sensortec BNO055 core driver andrea.merello
2022-06-13 16:44   ` Andy Shevchenko
2022-06-14  9:11     ` Andrea Merello
2022-06-14 10:58       ` Andy Shevchenko
2022-06-14 12:15         ` Andrea Merello
2022-06-14 15:10           ` Andy Shevchenko
2022-06-14 15:27             ` Andrea Merello
2022-06-18 17:26   ` Jonathan Cameron
2022-06-13 12:05 ` [v6 09/14] iio: document bno055 private sysfs attributes andrea.merello
2022-06-13 12:05 ` [v6 10/14] iio: document "serialnumber" sysfs attribute andrea.merello
2022-06-13 12:05 ` [v6 11/14] dt-bindings: iio/imu: Add Bosch BNO055 andrea.merello
2022-06-13 12:05 ` [v6 12/14] iio: imu: add BNO055 serdev driver andrea.merello
2022-06-13 16:52   ` Andy Shevchenko
2022-06-15 20:57   ` kernel test robot
2022-06-15 21:13     ` Andy Shevchenko
2022-06-15 21:15       ` Andy Shevchenko
2022-07-03  1:52   ` kernel test robot
2022-06-13 12:05 ` [v6 13/14] iio: imu: add BNO055 I2C driver andrea.merello
2022-06-13 12:05 ` [v6 14/14] docs: iio: add documentation for BNO055 driver andrea.merello
2022-07-03  7:58   ` kernel test robot
2022-07-03 13:11     ` Bagas Sanjaya
2022-07-03 14:00       ` Andy Shevchenko
2022-07-04  1:21         ` Bagas Sanjaya
2022-07-04  3:40       ` [PATCH v2] Documentation: bno055: separate SPDX identifier and page title Bagas Sanjaya
2022-07-04 19:49         ` Andy Shevchenko
2022-07-05  1:13           ` Bagas Sanjaya
2022-07-05  9:02             ` Andy Shevchenko
2022-07-13 16:09               ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220613120534.36991-8-andrea.merello@iit.it \
    --to=andrea.merello@iit.it \
    --cc=andy.shevchenko@gmail.com \
    --cc=ardeleanalex@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jacopo@jmondi.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.ranostay@konsulko.com \
    --cc=mchehab+huawei@kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).