From: Tyler Hicks <tyhicks@linux.microsoft.com>
To: Dominique Martinet <asmadeus@codewreck.org>
Cc: Christian Schoenebeck <linux_oss@crudebyte.com>,
v9fs-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/06] fid refcounting improvements and fixes
Date: Mon, 13 Jun 2022 15:20:53 -0500 [thread overview]
Message-ID: <20220613202053.GI7401@sequoia> (raw)
In-Reply-To: <20220612085330.1451496-1-asmadeus@codewreck.org>
On 2022-06-12 17:53:23, Dominique Martinet wrote:
> So:
> - I could reproduce Tyler's generic 531 leak, fixed it by the first
> commit in v9fs_vfs_atomic_open_dotl
> - Found another less likely leak while reworking code
> - Christian's comment that it's not obvious that clunk is just a
> refcount decrease was very true: I think it's worth the churn,
> so I've rename this all through a new helper...
> - ... with the not-so-hidden intent to improve debugging by adding
> a tracepoint for them, which I have also done.
>
> I've also taken my comment in the other thread further and went ahead
> and made it in its own commit. Tyler, if you're ok with this I'll just
> squash it up. You can see rebased patches here:
> https://github.com/martinetd/linux/
>
> Note that I also took the permission to add back '/* clone */' as a
> comment to your changing p9_client_walk's arguments: while I can agree
> variables are hard to track, figuring out what the heck that boolean
> argument means is much harder to me and I honestly preferred the
> variable.
> Having both through a comment is good enough for me if you'll accept
> this:
> ----
> @@ -222,7 +221,8 @@ static struct p9_fid *v9fs_fid_lookup_with_uid(struct dentry *dentry,
> * We need to hold rename lock when doing a multipath
> * walk to ensure none of the patch component change
> */
> - fid = p9_client_walk(old_fid, l, &wnames[i], clone);
> + fid = p9_client_walk(old_fid, l, &wnames[i],
> + old_fid == root_fid /* clone */);
This is no problem at all. The rebased patches look good to me. Squash
your fix to my fix and it should be ready to go.
Thanks again!
Tyler
> /* non-cloning walk will return the same fid */
> if (fid != old_fid) {
> p9_client_clunk(old_fid);
> ----
>
>
> The last commit is just cleanups and should be no real change.
>
> Dominique Martinet (6):
> 9p: fix fid refcount leak in v9fs_vfs_atomic_open_dotl
> 9p: fix fid refcount leak in v9fs_vfs_get_link
> 9p: v9fs_fid_lookup_with_uid fix's fix suggestion
> 9p fid refcount: add p9_fid_get/put wrappers
> 9p fid refcount: add a 9p_fid_ref tracepoint
> 9p fid refcount: cleanup p9_fid_put calls
>
>
> (diff stats include Tyler's commits)
>
> fs/9p/fid.c | 71 +++++++++++++++-------------
> fs/9p/fid.h | 6 +--
> fs/9p/vfs_addr.c | 4 +-
> fs/9p/vfs_dentry.c | 4 +-
> fs/9p/vfs_dir.c | 2 +-
> fs/9p/vfs_file.c | 9 ++--
> fs/9p/vfs_inode.c | 97 +++++++++++++++++----------------------
> fs/9p/vfs_inode_dotl.c | 79 ++++++++++++-------------------
> fs/9p/vfs_super.c | 8 ++--
> fs/9p/xattr.c | 8 ++--
> include/net/9p/client.h | 3 ++
> include/trace/events/9p.h | 48 +++++++++++++++++++
> net/9p/client.c | 42 +++++++++++------
> 13 files changed, 211 insertions(+), 170 deletions(-)
>
> --
> 2.35.1
>
next prev parent reply other threads:[~2022-06-13 20:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-12 8:53 [PATCH 00/06] fid refcounting improvements and fixes Dominique Martinet
2022-06-12 8:53 ` [PATCH 01/06] 9p: fix fid refcount leak in v9fs_vfs_atomic_open_dotl Dominique Martinet
2022-06-13 16:27 ` Tyler Hicks
2022-06-14 13:17 ` Christian Schoenebeck
2022-06-12 8:53 ` [PATCH 02/06] 9p: fix fid refcount leak in v9fs_vfs_get_link Dominique Martinet
2022-06-13 16:29 ` Tyler Hicks
2022-06-14 13:19 ` Christian Schoenebeck
2022-06-12 8:53 ` [PATCH 03/06] 9p: v9fs_fid_lookup_with_uid fix's fix suggestion Dominique Martinet
2022-06-13 20:08 ` Tyler Hicks
2022-06-12 8:53 ` [PATCH 04/06] 9p fid refcount: add p9_fid_get/put wrappers Dominique Martinet
2022-06-12 23:45 ` [PATCH v2 " Dominique Martinet
2022-06-13 17:31 ` Tyler Hicks
2022-06-14 13:55 ` Christian Schoenebeck
2022-06-14 14:27 ` Dominique Martinet
2022-06-15 3:16 ` [PATCH v3 " Dominique Martinet
2022-06-15 13:00 ` Christian Schoenebeck
2022-06-15 13:47 ` Dominique Martinet
2022-06-12 8:53 ` [PATCH 05/06] 9p fid refcount: add a 9p_fid_ref tracepoint Dominique Martinet
2022-06-12 22:46 ` Steven Rostedt
2022-06-12 23:46 ` [PATCH v2 " Dominique Martinet
2022-06-13 7:00 ` Dominique Martinet
2022-06-12 8:53 ` [PATCH 06/06] 9p fid refcount: cleanup p9_fid_put calls Dominique Martinet
2022-06-13 17:55 ` Tyler Hicks
2022-06-13 19:50 ` Dominique Martinet
2022-06-13 20:12 ` Tyler Hicks
2022-06-13 20:20 ` Tyler Hicks [this message]
2022-06-13 21:00 ` [PATCH 00/06] fid refcounting improvements and fixes Dominique Martinet
2022-06-14 1:14 ` Tyler Hicks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220613202053.GI7401@sequoia \
--to=tyhicks@linux.microsoft.com \
--cc=asmadeus@codewreck.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).