linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lu Baolu <baolu.lu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>, Kevin Tian <kevin.tian@intel.com>,
	Ashok Raj <ashok.raj@intel.com>,
	Christoph Hellwig <hch@infradead.org>,
	Jason Gunthorpe <jgg@nvidia.com>
Cc: Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Liu Yi L <yi.l.liu@intel.com>,
	Jacob jun Pan <jacob.jun.pan@intel.com>,
	iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
	Lu Baolu <baolu.lu@linux.intel.com>
Subject: [PATCH v2 00/12] iommu/vt-d: Optimize the use of locks
Date: Tue, 14 Jun 2022 10:51:25 +0800	[thread overview]
Message-ID: <20220614025137.1632762-1-baolu.lu@linux.intel.com> (raw)

Hi folks,

This series tries to optimize the uses of two locks in the Intel IOMMU
driver:

- The intel_iommu::lock is used to protect the IOMMU resources shared by
  devices. They include the IOMMU root and context tables, the pasid
  tables and the domain IDs.
- The global device_domain_lock is used to protect the global and the
  per-domain device tracking lists.

The optimization includes:

- Remove the unnecessary global device tracking list;
- Remove unnecessary locking;
- Reduce the scope of the lock as much as possible, that is, use the
  lock only where necessary;
- The global lock is transformed into a local lock to improve the
  efficiency.

This series is also available on github:
https://github.com/LuBaolu/intel-iommu/commits/intel-iommu-lock-optimization-v2

Your comments and suggestions are very appreciated.

Best regards,
baolu

Change log:

v2:
 - Split the lock-free page walk issue into a new patch:
   https://lore.kernel.org/linux-iommu/20220609070811.902868-1-baolu.lu@linux.intel.com/
 - Drop the conversion from spinlock to mutex and make this series
   cleanup purpose only.
 - Address several comments received during v1 review.

v1:
 - https://lore.kernel.org/linux-iommu/20220527063019.3112905-1-baolu.lu@linux.intel.com/
 - Initial post.

Lu Baolu (12):
  iommu/vt-d: debugfs: Remove device_domain_lock usage
  iommu/vt-d: Remove for_each_device_domain()
  iommu/vt-d: Remove clearing translation data in disable_dmar_iommu()
  iommu/vt-d: Use pci_get_domain_bus_and_slot() in pgtable_walk()
  iommu/vt-d: Unnecessary spinlock for root table alloc and free
  iommu/vt-d: Acquiring lock in domain ID allocation helpers
  iommu/vt-d: Acquiring lock in pasid manipulation helpers
  iommu/vt-d: Replace spin_lock_irqsave() with spin_lock()
  iommu/vt-d: Check device list of domain in domain free path
  iommu/vt-d: Fold __dmar_remove_one_dev_info() into its caller
  iommu/vt-d: Use device_domain_lock accurately
  iommu/vt-d: Convert global spinlock into per domain ones

 drivers/iommu/intel/iommu.h   |   5 +-
 drivers/iommu/intel/pasid.h   |   1 +
 drivers/iommu/intel/debugfs.c |  55 ++++---
 drivers/iommu/intel/iommu.c   | 279 ++++++++++------------------------
 drivers/iommu/intel/pasid.c   | 149 +++++++++---------
 drivers/iommu/intel/svm.c     |   5 +-
 6 files changed, 185 insertions(+), 309 deletions(-)

-- 
2.25.1


             reply	other threads:[~2022-06-14  3:00 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14  2:51 Lu Baolu [this message]
2022-06-14  2:51 ` [PATCH v2 01/12] iommu/vt-d: debugfs: Remove device_domain_lock usage Lu Baolu
2022-06-14  6:43   ` Tian, Kevin
2022-06-14  7:15     ` Baolu Lu
2022-06-15  1:53     ` Baolu Lu
2022-06-15  6:13       ` Tian, Kevin
2022-06-15 13:02         ` Baolu Lu
2022-06-14  2:51 ` [PATCH v2 02/12] iommu/vt-d: Remove for_each_device_domain() Lu Baolu
2022-06-14  2:51 ` [PATCH v2 03/12] iommu/vt-d: Remove clearing translation data in disable_dmar_iommu() Lu Baolu
2022-06-14  6:49   ` Tian, Kevin
2022-06-14  7:21     ` Baolu Lu
2022-06-15  6:22       ` Tian, Kevin
2022-06-15 13:10         ` Baolu Lu
2022-06-16  4:00           ` Tian, Kevin
2022-06-14  2:51 ` [PATCH v2 04/12] iommu/vt-d: Use pci_get_domain_bus_and_slot() in pgtable_walk() Lu Baolu
2022-06-14  2:51 ` [PATCH v2 05/12] iommu/vt-d: Unnecessary spinlock for root table alloc and free Lu Baolu
2022-06-14  2:51 ` [PATCH v2 06/12] iommu/vt-d: Acquiring lock in domain ID allocation helpers Lu Baolu
2022-06-14  6:52   ` Tian, Kevin
2022-06-14  7:22     ` Baolu Lu
2022-06-14  2:51 ` [PATCH v2 07/12] iommu/vt-d: Acquiring lock in pasid manipulation helpers Lu Baolu
2022-06-14  2:51 ` [PATCH v2 08/12] iommu/vt-d: Replace spin_lock_irqsave() with spin_lock() Lu Baolu
2022-06-14  6:56   ` Tian, Kevin
2022-06-14  2:51 ` [PATCH v2 09/12] iommu/vt-d: Check device list of domain in domain free path Lu Baolu
2022-06-14  6:57   ` Tian, Kevin
2022-06-14  2:51 ` [PATCH v2 10/12] iommu/vt-d: Fold __dmar_remove_one_dev_info() into its caller Lu Baolu
2022-06-14  7:07   ` Tian, Kevin
2022-06-14  7:44     ` Baolu Lu
2022-06-14  2:51 ` [PATCH v2 11/12] iommu/vt-d: Use device_domain_lock accurately Lu Baolu
2022-06-14  7:16   ` Tian, Kevin
2022-06-14  7:47     ` Baolu Lu
2022-06-14  2:51 ` [PATCH v2 12/12] iommu/vt-d: Convert global spinlock into per domain ones Lu Baolu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220614025137.1632762-1-baolu.lu@linux.intel.com \
    --to=baolu.lu@linux.intel.com \
    --cc=ashok.raj@intel.com \
    --cc=hch@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jacob.jun.pan@intel.com \
    --cc=jgg@nvidia.com \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    --cc=yi.l.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).