From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2406EC433EF for ; Tue, 14 Jun 2022 23:01:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357456AbiFNXBh (ORCPT ); Tue, 14 Jun 2022 19:01:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231812AbiFNXBc (ORCPT ); Tue, 14 Jun 2022 19:01:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6060F52E6F; Tue, 14 Jun 2022 16:01:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EEFF66189B; Tue, 14 Jun 2022 23:01:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EEE1C3411B; Tue, 14 Jun 2022 23:01:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655247690; bh=0uCD3AXwENO/Bxz69LYMMOQrPnOqlOLGdU2KJqwaCX4=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=eFWD1zQ5yiMvhfQ5Jytt3I/far5PQRv7d1h4eCpI+rsb0iF3OI4f1TnsZY3mvcuk8 NP4MpkRZgSswh3eMRZl/fAYke9hBR64YvUCtB4ttC0/xYvOE93t+//LziPpT/WbGQn e7ceGkopIGC3w5P7xIaUKdnRna8u0N5keaXaEgU3eNmS3cNKKNBf5u5WkZMeUxxo0I y5t/V0+/yjyYbOH5WuKBRfdcnfzAlMve9oyied4NAeJVcfEloxxkAYd0k3bpmmdpqE 5P4eJbtzARugGiokJYLBlLYJehe/DN4Oc8xiztb5Jk7b5ScUbdmT4iYnsVykjPZP0Z Ld+ipjnaHCoYA== Date: Tue, 14 Jun 2022 18:01:28 -0500 From: Bjorn Helgaas To: "Guilherme G. Piccoli" Cc: Hans de Goede , "Rafael J . Wysocki" , Mika Westerberg , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Myron Stowe , Juha-Pekka Heikkila , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Benoit =?iso-8859-1?Q?Gr=E9goire?= , Hui Wang , linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org Subject: Re: [PATCH] x86/PCI: Revert: "Clip only host bridge windows for E820 regions" Message-ID: <20220614230128.GA901712@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6eae37ce-dd44-9c32-3f68-2b4e102dce8e@igalia.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [+cc NVMe folks] On Tue, Jun 14, 2022 at 07:49:27PM -0300, Guilherme G. Piccoli wrote: > On 14/06/2022 12:47, Hans de Goede wrote: > > [...] > > > > Have you looked at the log of the failed boot in the Steam Deck kernel > > bugzilla? Everything there seems to work just fine and then the system > > just hangs. I think that maybe it cannot find its root disk, so maybe > > an NVME issue ? > > *Exactly* that - NVMe device is the root disk, it cannot boot since the > device doesn't work, hence no rootfs =) Beginning of thread: https://lore.kernel.org/r/20220612144325.85366-1-hdegoede@redhat.com Steam Deck broke because we erroneously trimmed out the PCI host bridge window where BIOS had placed most devices, successfully reassigned all the PCI bridge windows and BARs, but some devices, apparently including NVMe, didn't work at the new addresses. Do you NVMe folks know of gotchas in this area? I want to know because we'd like to be able to move devices around someday to make room for hot-added devices. This reassignment happened before drivers claimed the devices, so from a PCI point of view, I don't know why the NVMe device wouldn't work at the new address. Bjorn