From: Yang Yingliang <yangyingliang@huawei.com>
To: <linux-kernel@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>
Cc: <mpe@ellerman.id.au>, <benh@kernel.crashing.org>
Subject: [PATCH -next] powerpc/fsl_rio: add missing of_node_put() in fsl_rio_setup()
Date: Wed, 15 Jun 2022 11:21:37 +0800 [thread overview]
Message-ID: <20220615032137.1878219-1-yangyingliang@huawei.com> (raw)
of_find_compatible_node() and for_each_child_of_node() will increase
the refcount of 'np', so add of_node_put() after using it to avoid
refcount leak.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
arch/powerpc/sysdev/fsl_rio.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/powerpc/sysdev/fsl_rio.c b/arch/powerpc/sysdev/fsl_rio.c
index 1bfc9afa8a1a..97bbecb259dc 100644
--- a/arch/powerpc/sysdev/fsl_rio.c
+++ b/arch/powerpc/sysdev/fsl_rio.c
@@ -542,9 +542,11 @@ int fsl_rio_setup(struct platform_device *dev)
if (!dt_range) {
pr_err("%pOF: unable to find 'reg' property\n",
np);
+ of_node_put(np);
rc = -ENOMEM;
goto err_pw;
}
+ of_node_put(np);
range_start = of_read_number(dt_range, aw);
dbell->dbell_regs = (struct rio_dbell_regs *)(rmu_regs_win +
(u32)range_start);
@@ -570,9 +572,11 @@ int fsl_rio_setup(struct platform_device *dev)
if (!dt_range) {
pr_err("%pOF: unable to find 'reg' property\n",
np);
+ of_node_put(np);
rc = -ENOMEM;
goto err;
}
+ of_node_put(np);
range_start = of_read_number(dt_range, aw);
pw->pw_regs = (struct rio_pw_regs *)(rmu_regs_win + (u32)range_start);
@@ -582,6 +586,7 @@ int fsl_rio_setup(struct platform_device *dev)
if (!port_index) {
dev_err(&dev->dev, "Can't get %pOF property 'cell-index'\n",
np);
+ of_node_put(np);
continue;
}
@@ -589,6 +594,7 @@ int fsl_rio_setup(struct platform_device *dev)
if (!dt_range) {
dev_err(&dev->dev, "Can't get %pOF property 'ranges'\n",
np);
+ of_node_put(np);
continue;
}
@@ -611,6 +617,7 @@ int fsl_rio_setup(struct platform_device *dev)
dev_info(&dev->dev, "%pOF: LAW start 0x%016llx, size 0x%016llx.\n",
np, range_start, range_size);
+ of_node_put(np);
port = kzalloc(sizeof(struct rio_mport), GFP_KERNEL);
if (!port)
--
2.25.1
reply other threads:[~2022-06-15 3:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220615032137.1878219-1-yangyingliang@huawei.com \
--to=yangyingliang@huawei.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).