From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26DE1C433EF for ; Wed, 15 Jun 2022 23:25:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245307AbiFOXZV (ORCPT ); Wed, 15 Jun 2022 19:25:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230172AbiFOXZT (ORCPT ); Wed, 15 Jun 2022 19:25:19 -0400 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4F9810FFF for ; Wed, 15 Jun 2022 16:25:15 -0700 (PDT) Authenticated-By: X-SpamFilter-By: ArmorX SpamTrap 5.73 with qID 25FNP2Qg8014168, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36505.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.71/5.88) with ESMTPS id 25FNP2Qg8014168 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Thu, 16 Jun 2022 07:25:02 +0800 Received: from RTEXMBS03.realtek.com.tw (172.21.6.96) by RTEXH36505.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 16 Jun 2022 07:25:02 +0800 Received: from localhost.localdomain (172.21.177.191) by RTEXMBS03.realtek.com.tw (172.21.6.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 16 Jun 2022 07:25:01 +0800 From: Edward Wu To: Andrew Morton , , CC: , , Subject: [PATCH v2] mm: cma: sync everything after EBUSY Date: Thu, 16 Jun 2022 07:24:55 +0800 Message-ID: <20220615232455.26451-1-edwardwu@realtek.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220615021504.23358-1-edwardwu@realtek.com> References: <20220615021504.23358-1-edwardwu@realtek.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.21.177.191] X-ClientProxiedBy: RTEXH36504.realtek.com.tw (172.21.6.27) To RTEXMBS03.realtek.com.tw (172.21.6.96) X-KSE-ServerInfo: RTEXMBS03.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: trusted connection X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Deterministic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 06/15/2022 23:03:00 X-KSE-AttachmentFiltering-Interceptor-Info: no applicable attachment filtering rules found X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: =?big5?B?Q2xlYW4sIGJhc2VzOiAyMDIyLzYvMTUgpFWkyCAxMDowMTowMA==?= X-KSE-BulkMessagesFiltering-Scan-Result: protection disabled X-KSE-ServerInfo: RTEXH36505.realtek.com.tw, 9 X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: protection disabled Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since file-backed memory on CMA area could take long-term pinning. By Minchan Kim's debug commit 151e084af494 ("mm: page_alloc: dump migrate-failed pages only at -EBUSY") We know the pinned page comes from buffer_head, ext4 journal, FS metadata. Sync everything after EBUSY that can unpin most file-system pages. And raise the success rate at next time try. Link: https://lkml.kernel.org/r/20220615021504.23358-1-edwardwu@realtek.com Signed-off-by: Edward Wu --- v2: - Fix compile warning mm/cma.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/mm/cma.c b/mm/cma.c index eaa4b5c920a2..28391f8ce0fd 100644 --- a/mm/cma.c +++ b/mm/cma.c @@ -31,6 +31,7 @@ #include #include #include +#include #include #include "cma.h" @@ -410,6 +411,24 @@ static void cma_debug_show_areas(struct cma *cma) static inline void cma_debug_show_areas(struct cma *cma) { } #endif +static inline void cma_sync_work(struct work_struct *work) +{ + ksys_sync(); + kfree(work); + pr_debug("%s(): EBUSY Sync complete\n", __func__); +} + +static void cma_ebusy_sync_pinned_pages(void) +{ + struct work_struct *work; + + work = kmalloc(sizeof(*work), GFP_ATOMIC); + if (work) { + INIT_WORK(work, cma_sync_work); + schedule_work(work); + } +} + /** * cma_alloc() - allocate pages from contiguous area * @cma: Contiguous memory region for which the allocation is performed. @@ -430,6 +449,7 @@ struct page *cma_alloc(struct cma *cma, unsigned long count, unsigned long i; struct page *page = NULL; int ret = -ENOMEM; + bool sys_synchronized = false; if (!cma || !cma->count || !cma->bitmap) goto out; @@ -480,6 +500,11 @@ struct page *cma_alloc(struct cma *cma, unsigned long count, if (ret != -EBUSY) break; + if (!sys_synchronized) { + sys_synchronized = true; + cma_ebusy_sync_pinned_pages(); + } + pr_debug("%s(): memory range at %p is busy, retrying\n", __func__, pfn_to_page(pfn)); -- 2.17.1