From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org,
"Cezary Rojewski" <cezary.rojewski@intel.com>,
"Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>,
"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
"Bard Liao" <yung-chuan.liao@linux.intel.com>,
"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
"Ranjani Sridharan" <ranjani.sridharan@linux.intel.com>,
"Peter Ujfalusi" <peter.ujfalusi@gmail.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 11/11] ASoC: ti: davinci-mcasp: use pm_runtime_resume_and_get()
Date: Thu, 16 Jun 2022 17:04:27 -0500 [thread overview]
Message-ID: <20220616220427.136036-12-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20220616220427.136036-1-pierre-louis.bossart@linux.intel.com>
The use of pm_runtime_get_sync() is buggy with no use of put_noidle on
error.
Use pm_runtime_resume_and_get() instead.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
---
sound/soc/ti/davinci-mcasp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/soc/ti/davinci-mcasp.c b/sound/soc/ti/davinci-mcasp.c
index e2aab4729f3ab..0201000b619f6 100644
--- a/sound/soc/ti/davinci-mcasp.c
+++ b/sound/soc/ti/davinci-mcasp.c
@@ -2111,8 +2111,7 @@ static int davinci_mcasp_gpio_request(struct gpio_chip *chip, unsigned offset)
}
/* Do not change the PIN yet */
-
- return pm_runtime_get_sync(mcasp->dev);
+ return pm_runtime_resume_and_get(mcasp->dev);
}
static void davinci_mcasp_gpio_free(struct gpio_chip *chip, unsigned offset)
--
2.34.1
next prev parent reply other threads:[~2022-06-16 22:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220616220427.136036-1-pierre-louis.bossart@linux.intel.com>
2022-06-16 22:04 ` [PATCH 01/11] ASoC: Intel: catpt: use pm_runtime_resume_and_get() Pierre-Louis Bossart
2022-06-17 12:18 ` Cezary Rojewski
2022-06-16 22:04 ` [PATCH 02/11] ASoC: Intel: skylake: skl-pcm: " Pierre-Louis Bossart
2022-06-17 12:19 ` Cezary Rojewski
2022-06-16 22:04 ` [PATCH 03/11] ASoC: soc-component: " Pierre-Louis Bossart
2022-06-17 19:47 ` Pierre-Louis Bossart
2022-06-16 22:04 ` [PATCH 04/11] ASoC: wcd-mbhc-v2: " Pierre-Louis Bossart
2022-06-17 20:53 ` Srinivas Kandagatla
2022-06-16 22:04 ` [PATCH 05/11] ASoC: wsa881x: " Pierre-Louis Bossart
2022-06-17 20:52 ` Srinivas Kandagatla
2022-06-16 22:04 ` [PATCH 06/11] ASoC: rockchip: i2s_tdm: " Pierre-Louis Bossart
2022-06-16 22:04 ` [PATCH 07/11] ASoC: fsl: fsl_sai: " Pierre-Louis Bossart
2022-06-16 22:04 ` [PATCH 08/11] ASoC: img: img-i2s-out: " Pierre-Louis Bossart
2022-06-16 22:04 ` [PATCH 09/11] ASoC: rockchip: pdm: " Pierre-Louis Bossart
2022-06-16 22:04 ` [PATCH 10/11] ASoC: tas2552: " Pierre-Louis Bossart
2022-06-16 22:04 ` Pierre-Louis Bossart [this message]
2022-06-17 12:28 ` [PATCH 11/11] ASoC: ti: davinci-mcasp: " Péter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220616220427.136036-12-pierre-louis.bossart@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@gmail.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).