From: Lei He <helei.sig11@bytedance.com>
To: herbert@gondor.apana.org.au, davem@davemloft.net,
dhowells@redhat.com, mst@redhat.com
Cc: arei.gonglei@huawei.com, jasowang@redhat.com,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
pizhenwei@bytedance.com, helei.sig11@bytedance.com,
f4bug@amsat.org, berrange@redhat.com
Subject: [PATCH] crypto: testmgr - fix version number of RSA tests
Date: Fri, 17 Jun 2022 15:07:51 +0800 [thread overview]
Message-ID: <20220617070754.73667-3-helei.sig11@bytedance.com> (raw)
In-Reply-To: <20220617070754.73667-1-helei.sig11@bytedance.com>
From: lei he <helei.sig11@bytedance.com>
According to PKCS#1 standard, the 'otherPrimeInfos' field contains
the information for the additional primes r_3, ..., r_u, in order.
It shall be omitted if the version is 0 and shall contain at least
one instance of OtherPrimeInfo if the version is 1, see:
https://www.rfc-editor.org/rfc/rfc3447#page-44
Replace the version number '1' with 0, otherwise, some drivers may
not pass the run-time tests.
Signed-off-by: lei he <helei.sig11@bytedance.com>
---
crypto/testmgr.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/crypto/testmgr.h b/crypto/testmgr.h
index 4d7449fc6a65..d57f24b906f1 100644
--- a/crypto/testmgr.h
+++ b/crypto/testmgr.h
@@ -186,7 +186,7 @@ static const struct akcipher_testvec rsa_tv_template[] = {
#ifndef CONFIG_CRYPTO_FIPS
.key =
"\x30\x81\x9A" /* sequence of 154 bytes */
- "\x02\x01\x01" /* version - integer of 1 byte */
+ "\x02\x01\x00" /* version - integer of 1 byte */
"\x02\x41" /* modulus - integer of 65 bytes */
"\x00\xAA\x36\xAB\xCE\x88\xAC\xFD\xFF\x55\x52\x3C\x7F\xC4\x52\x3F"
"\x90\xEF\xA0\x0D\xF3\x77\x4A\x25\x9F\x2E\x62\xB4\xC5\xD9\x9C\xB5"
@@ -216,7 +216,7 @@ static const struct akcipher_testvec rsa_tv_template[] = {
}, {
.key =
"\x30\x82\x01\x1D" /* sequence of 285 bytes */
- "\x02\x01\x01" /* version - integer of 1 byte */
+ "\x02\x01\x00" /* version - integer of 1 byte */
"\x02\x81\x81" /* modulus - integer of 129 bytes */
"\x00\xBB\xF8\x2F\x09\x06\x82\xCE\x9C\x23\x38\xAC\x2B\x9D\xA8\x71"
"\xF7\x36\x8D\x07\xEE\xD4\x10\x43\xA4\x40\xD6\xB6\xF0\x74\x54\xF5"
@@ -260,7 +260,7 @@ static const struct akcipher_testvec rsa_tv_template[] = {
#endif
.key =
"\x30\x82\x02\x20" /* sequence of 544 bytes */
- "\x02\x01\x01" /* version - integer of 1 byte */
+ "\x02\x01\x00" /* version - integer of 1 byte */
"\x02\x82\x01\x01\x00" /* modulus - integer of 256 bytes */
"\xDB\x10\x1A\xC2\xA3\xF1\xDC\xFF\x13\x6B\xED\x44\xDF\xF0\x02\x6D"
"\x13\xC7\x88\xDA\x70\x6B\x54\xF1\xE8\x27\xDC\xC3\x0F\x99\x6A\xFA"
--
2.20.1
next prev parent reply other threads:[~2022-06-17 7:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 7:07 [PATCH 0/4] virtio-crypto: support ECDSA algorithm Lei He
2022-06-17 7:07 ` [PATCH 1/4] crypto: fix the calculation of max_size for ECDSA Lei He
2022-06-17 7:07 ` Lei He [this message]
2022-06-19 7:09 ` [PATCH] crypto: testmgr - fix version number of RSA tests Michael S. Tsirkin
2022-06-20 2:57 ` [External] " 何磊
2022-06-17 7:07 ` [PATCH 2/4] crypto: pkcs8 parser support ECDSA private keys Lei He
2022-06-17 7:07 ` [PATCH 3/4] crypto: remove unused field in pkcs8_parse_context Lei He
2022-06-17 7:07 ` [PATCH 4/4] virtio-crypto: support ECDSA algorithm Lei He
2022-06-17 14:40 ` kernel test robot
2022-06-17 17:27 ` kernel test robot
2022-06-17 11:02 ` [PATCH 0/4] " Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2022-06-24 10:06 [PATCH] crypto: testmgr - fix version number of RSA tests Lei He
2022-06-30 8:16 ` Herbert Xu
2022-06-15 9:13 Lei He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220617070754.73667-3-helei.sig11@bytedance.com \
--to=helei.sig11@bytedance.com \
--cc=arei.gonglei@huawei.com \
--cc=berrange@redhat.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=f4bug@amsat.org \
--cc=herbert@gondor.apana.org.au \
--cc=jasowang@redhat.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pizhenwei@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).