From: Andrew Morton <akpm@linux-foundation.org>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Ying Huang <ying.huang@intel.com>, <peterx@redhat.com>,
<apopple@nvidia.com>, <osalvador@suse.de>,
<mike.kravetz@oracle.com>, <songmuchun@bytedance.com>,
<hch@lst.de>, <dhowells@redhat.com>, <cl@linux.com>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<naoya.horiguchi@nec.com>
Subject: Re: [PATCH v4 1/4] mm: reduce the rcu lock duration
Date: Fri, 17 Jun 2022 17:23:16 -0700 [thread overview]
Message-ID: <20220617172316.de2d41877e86be344052b9f5@linux-foundation.org> (raw)
In-Reply-To: <a836d04a-d26b-3eea-3e0e-27af0d2d9651@huawei.com>
On Tue, 7 Jun 2022 17:19:53 +0800 Miaohe Lin <linmiaohe@huawei.com> wrote:
> >
> >
> > If the checks are not made to guarantee they are all checking against
> > the same mm, the code needs a comment to say that there is a tiny race.
> > The comment should say we don't care about the tiny race because
> > the worst that can happen is that a page is migrated to a different
> > numa node. And so we don't care.
> >
> >
>
> I tend to do this one. To make sure, is the below code change what you suggest?
Eric went quiet.
As I understand it, any changes arising from this discussion can be
done as a followup patch. So I'm planning on moving this 4-patch
series into the non-rebasing mm-stable branch late next week.
next prev parent reply other threads:[~2022-06-18 0:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-30 11:30 [PATCH v4 0/4] A few cleanup and fixup patches for migration Miaohe Lin
2022-05-30 11:30 ` [PATCH v4 1/4] mm: reduce the rcu lock duration Miaohe Lin
2022-05-31 6:06 ` Ying Huang
2022-05-31 9:01 ` Miaohe Lin
2022-05-31 16:09 ` Eric W. Biederman
2022-06-01 6:33 ` Miaohe Lin
2022-06-01 14:37 ` Eric W. Biederman
2022-06-02 9:22 ` Miaohe Lin
2022-06-03 16:28 ` Eric W. Biederman
2022-06-07 9:19 ` Miaohe Lin
2022-06-18 0:23 ` Andrew Morton [this message]
2022-06-18 2:49 ` Miaohe Lin
2022-05-31 12:50 ` David Hildenbrand
2022-05-31 12:58 ` Matthew Wilcox
2022-05-31 13:05 ` Matthew Wilcox
2022-06-01 3:21 ` Miaohe Lin
2022-05-30 11:30 ` [PATCH v4 2/4] mm/migration: remove unneeded lock page and PageMovable check Miaohe Lin
2022-05-31 12:50 ` David Hildenbrand
2022-05-30 11:30 ` [PATCH v4 3/4] mm/migration: return errno when isolate_huge_page failed Miaohe Lin
2022-05-30 11:30 ` [PATCH v4 4/4] mm/migration: fix potential pte_unmap on an not mapped pte Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220617172316.de2d41877e86be344052b9f5@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=cl@linux.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=hch@lst.de \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=naoya.horiguchi@nec.com \
--cc=osalvador@suse.de \
--cc=peterx@redhat.com \
--cc=songmuchun@bytedance.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).